Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-04 Thread Dmitriy Ermashov
Petr, Thanks for review! With regards, Dmitriy Ermashov > 03 июля 2014 г., в 18:55, Petr Pchelko написал(а): > > Looks good to me. > > With best regards. Petr. > >> On Jul 3, 2014, at 6:49 PM, Dmitriy Ermashov >> wrote: >> >> Hi, >> I've updated the webrev, so could you please review it?

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-03 Thread Petr Pchelko
Looks good to me. With best regards. Petr. > On Jul 3, 2014, at 6:49 PM, Dmitriy Ermashov > wrote: > > Hi, > I've updated the webrev, so could you please review it? > http://cr.openjdk.java.net/~dermashov/8048246/webrev.02/ > > Last changes: > 1. Clipboard folder moved to datatransfer folder.

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-03 Thread Dmitriy Ermashov
Hi, I've updated the webrev, so could you please review it? http://cr.openjdk.java.net/~dermashov/8048246/webrev.02/ Last changes: 1. Clipboard folder moved to datatransfer folder. 2. Removed private fields/methods call from AddFlavorClipboard test 3. Test GetContentsInterruptedTest.java is a rep

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-03 Thread Petr Pchelko
Hello, Dmitriy. As we do not have a Clipboard folder yet, could you please put Clipboard tests under java/awt/datatransfer/Clipboard so that all data transfer tests are in the same folder. AddFlavorTest:80 - here the test is using the private method via reflection. Please remove this part of th

Re: Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-03 Thread Dmitriy Ermashov
Hi all, Please review the updated version of tests to be colocated. http://cr.openjdk.java.net/~dermashov/8048246/webrev.01/ http://cr.openjdk.java.net/~dermashov/8048246/webrev.diff.01/ Last changes: 1. Removed 1 test from closed part. New GetContentsInterruptedTest.java is an up-to-date copy

Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

2014-07-01 Thread Dmitriy Ermashov
Hi, Please review a new batch of functional AWT tests. Clipboard tests this time. http://cr.openjdk.java.net/~dermashov/8048246/webrev.00/ Corresponding bug: https://bugs.openjdk.java.net/browse/JDK-8048246 The changeset is pretty large, but, as always, it is several times smaller than origi