Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-26 Thread Michael Hall
On Jul 26, 2015, at 7:13 AM, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Would these warnings not end up as errors that would stop the build? No, because lwawt library does not set warning as error option for now. OK thanks. Michael Hall

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-26 Thread Sergey Bylokhov
On 26.07.15 1:20, Michael Hall wrote: On Jul 9, 2015, at 5:49 AM, Sergey Bylokhov sergey.bylok...@oracle.com mailto:sergey.bylok...@oracle.com wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-25 Thread Michael Hall
On Jul 9, 2015, at 5:49 AM, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. I may not be understanding this correctly.

AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. This code was integrated in http://cr.openjdk.java.net/~anashaty/8068886/webrev.00. The new clang complains that our constant is

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Alexander Zvegintsev
Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/09/2015 01:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. This code was

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

2015-07-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/9/2015 2:58 PM, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/09/2015 01:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us