Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-08-11 Thread pooja chopra
Hi All, Please review below fix as I need one more approval for this . Regards, Pooja On 7/29/2015 4:09 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/29/2015 10:00 AM, pooja chopra wrote: Hi , As default look and feel in mac is aqua only so there is

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-08-11 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 07/29/2015 01:39 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/29/2015 10:00 AM, pooja chopra wrote: Hi , As default look and feel in mac is aqua only so there is no need of setting system look and feel explicitly.

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-07-29 Thread pooja chopra
Hi , As default look and feel in mac is aqua only so there is no need of setting system look and feel explicitly. Please review updated webrev link below:- 8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-07-29 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 7/29/2015 10:00 AM, pooja chopra wrote: Hi , As default look and feel in mac is aqua only so there is no need of setting system look and feel explicitly. Please review updated webrev link below:- 8081764 [TEST_BUG] Test

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-06-11 Thread pooja chopra
Hi Andrew , The test passes with GTKLookAndFeel on Solaris but with out GTKLookAndFeel test fails with same error as mentioned in the bug . I had explicitly set the look and feel as system look and feel as test was to be run for Mac only and this test was placed in plaf/aqua and it is

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-06-09 Thread Andrew Brygin
Hello Pooja, In general I tend to agree with idea to limit the scope of the test by macosx only. However, could you please clarify following questions: a) the test failure on linux/solaris: doesn't it indicate a similar problem with gtk laf, does it? b) what is purpose of the explicit LaF

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

2015-06-08 Thread pooja chopra
Hi All, Correcting the webrev link below . Please review below fix . Regards, Pooja On 6/8/2015 3:27 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on