Re: [PATCH] wifi: cfg80211: Lock wiphy in cfg80211_get_station

Hi, On 21/05/2024 14:15, Remi Pommarel wrote: On Tue, May 21, 2024 at 09:43:56AM +0200, Antonio Quartulli wrote: Hi, On 18/05/2024 17:50, Remi Pommarel wrote: Wiphy should be locked before calling rdev_get_station() (see lockdep assert in ieee80211_get_station()). Adding the lock is fine

Re: [PATCH] wifi: cfg80211: Lock wiphy in cfg80211_get_station

. Have you checked where in ath10k_sta_statistics this is exactly happening? Do you think some sta was partly released and thus fields were NULLified? Regards, -- Antonio Quartulli

Re: [PATCH net-next] batman-adv: Fix the wrong definition

s not know how many items are stored in the array and thus requires it to be NULL terminated. Please check the following for reference: https://elixir.bootlin.com/linux/v5.15-rc6/source/lib/kobject_uevent.c#L548 OTOH I guess we could still use '{}' for the initialization. Regards, -- Antonio Quartulli

Re: Passing VID-aware ethernet frames on plain batX interfaces

man-adv will instantiate a number of internal data structures, along with routing logic, only when the VLAN is created. Regards, -- Antonio Quartulli

Re: [PATCH] batman-adv: bla: use netif_rx_ni when not in interrupt context

om/linux/latest/source/include/linux/preempt.h#L85 Is that something we should consider or is the comment bogus? Regards, > out: > if (primary_if) > batadv_hardif_put(primary_if); > -- Antonio Quartulli

Re: [PATCH maint] batman-adv: Avoid uninitialized chaddr when handling DHCP

the > correct chaddr but still tried to perform the TT lookup with this > uninitialized memory. > > Reported-by: syzbot+ab16e463b903f5a37...@syzkaller.appspotmail.com > Fixes: 2d5b555644b2 ("batman-adv: send every DHCP packet as bat-unicast") > Signed-off-by: Sven Eckelmann Acked-by: Antonio Quartulli -- Antonio Quartulli

[PATCH] batman-adv: use rcu_replace_pointer() where appropriate

ode slimer. Signed-off-by: Antonio Quartulli --- compat-include/linux/rcupdate.h | 27 +++ net/batman-adv/gateway_client.c | 4 ++-- net/batman-adv/hard-interface.c | 4 ++-- net/batman-adv/routing.c| 4 ++-- 4 files changed, 33 insertions(+), 6 deletions(-) c

Re: Host endianness dependent DHT lookup

> If this is a correct assumption, then we would have this problem since > 3e26722bc9f2 ("batman-adv: make the Distributed ARP Table vlan aware") > That's it. Very nice catch! Will you send a patch? I guess converting the VID into network order before accessing it should be enough,

Re: [PATCH v2 1/2] batman-adv: Only read OGM tvlv_len after buffer len check

herwise it might try read outside of the currently > available skbuff to get the content of tvlv_len. > > Fixes: 0b6aa0d43767 ("batman-adv: tvlv - basic infrastructure") > Reported-by: syzbot+355cab184197dbbfa...@syzkaller.appspotmail.com > Signed-off-by: Sven Eckelmann Acked-by:

Re: [PATCH maint] batman-adv: Only read tvlv_len after checking buffer size

dv_iv_ogm_receive(struct sk_buff *skb, > > /* unpack the aggregated packets and process them one by one */ > while (batadv_iv_ogm_aggr_packet(ogm_offset, skb_headlen(skb), > - ogm_packet->tvlv_len)) { > + _packet->tvlv_len)) { > batadv_iv_ogm_process(skb, ogm_offset, if_incoming); > > ogm_offset += BATADV_OGM_HLEN; > The rest makes sense to me. Regards, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [PATCH] batman-adv: Add Sven to MAINTAINERS file

On 16/08/2019 10:26, Simon Wunderlich wrote: > Sven is taking care of tracking our patches and merging most of them in > our tree. Let's add him to the MAINTAINERS file so he will get all > patch e-mails. > > Signed-off-by: Simon Wunderlich Acked-by: Antonio Quartulli -- An

Re: batman_v default throughput

Hi, On 09/08/2019 10:45, Sven Eckelmann wrote: > On Friday, 9 August 2019 10:26:24 CEST Antonio Quartulli wrote: >> As also mentioned at WBMv10, Marek and I had worked on a patchset that >> enables the tp_meter to measure the speed of a link, when no other >> throughput is av

Re: batman_v default throughput

rg/msg17833.html > Thanks! > > [0]: https://map11.freifunk-ulm.de/meshviewer > -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: allow updating DAT entry timeouts on incoming ARP Replies

> + goto out; > + > /* If BLA is enabled, only forward ARP replies if we have claimed the >* source of the ARP reply or if no one else of the same backbone has >* already claimed that client. This prevents that different gateways > The patch makes

Re: [B.A.T.M.A.N.] batman-adv: Reduce tt_global hash refcnt only for removed entry

t; > refcount_t: underflow; use-after-free. > > Fixes: 7bad46397eff ("batman-adv: protect the local and the global > trans-tables with rcu") > Signed-off-by: Sven Eckelmann > --- Acked-by: Antonio Quartulli -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: allow snooping gratuitous ARP Replies

s a bit too strict in that regard, I think. For > gratuitous ARP it's enough to ignore the (Target MAC/Target IP) > pair. Snooping the (Sender MAC/Sender IP) should be fine. > Is there any situation where an OS would reject a gracious ARP? Or are they always blindly accepted and processed

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Increase purge timeout on DAT DHT candidates

ould fix it, as > last_update is always initialized with "jiffies". +1 the problem is on last_dht_update that gets initializes with 0 (for locally cached entries). If you agree on removing it and using a bool (I like this idea too!), the overflow problem should be gone. Regards,

Re: [B.A.T.M.A.N.] batctl: Add section to explain gateway selection class for BATMAN_V

Hi, On 28/11/2018 00:00, Ruben Barkow wrote: > As mentioned here: https://www.open-mesh.org/issues/366#note-8 > > I added a fix to the formatting, so this is the final patch: > > Signed-off-by: Ruben Barkow Acked-by: Antonio Quartulli -- Antonio Quartulli signature.

Re: [B.A.T.M.A.N.] [RFC maint v2] batman-adv: fix adding VLANs with partial state

:20:28 2018 daemon.notice netifd: Network device 'bat0' link is > up > Sun Feb 25 14:20:28 2018 daemon.notice netifd: Interface 'bat0' has link > connectivity > Sun Feb 25 14:20:28 2018 daemon.notice netifd: Interface 'bat0' is setting up > now > Sun Feb 25 14:20:28 2018 daemon.notice netifd: Interface 'bat0' is now up > ~ > > Which looks like it might have the potential for a race condition? > Also the "HW filter" remark by 8021q seems a bit odd as this is a > virtual interface, doesn't it? This is nothing related to batman-adv, but it's just an internal VLAN that I never fully understood why it is created. What race condition are you talking about? Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH v6] batman-adv: Snoop DHCPACKs for DAT

face.c > @@ -212,6 +212,7 @@ static netdev_tx_t batadv_interface_tx(struct sk_buff > *skb, > enum batadv_forw_mode forw_mode; > struct batadv_orig_node *mcast_single_orig = NULL; > int network_offset = ETH_HLEN; > + __be16 proto; > > if (atomic_read(_p

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Avoid probe ELP information leak

aa92b ("batman-adv: ELP - send unicast ELP packets for > throughput sampling") > Signed-off-by: Sven Eckelmann Acked-by: Antonio Quartulli Great catch Sven! It seems like the leakage can be fairly severe, therefore this patch should definitely be shipped to stable later. Cheers, --

Re: [B.A.T.M.A.N.] Recent test result. Re:Re: Paper "Performance Evaluation of BATMAN-adv Wireless Mesh Network Routing Algorithms "

if you already have enough data over the link, no unicast ELP messages should be sent (thus these constants won't be used). To conclude: if you have no data over the link, sending 2 probes of 200bytes each every 500ms (default ELP interval) won't really eat much airtime, unless you have a lot o

Re: [B.A.T.M.A.N.] [PATCH v3 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

greed! changed that twice...and forgot to remote the other line :) > > Kind regards, > Sven > -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

t; with that. You should look at net/core/devlink.c and net/wireless/nl80211.c > to get some inspiration. Actually we have already implemented a basic netlink API to be used when sending information to userspace (i.e. routing tables, neighbour tables, etc..), therefore I think we might be able t

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

ked by batadv_v_elp_get_throughput(); - batadv_v_elp_get_throughput() is only invoked by batadv_v_elp_throughput_metric_update(); - batadv_v_elp_throughput_metric_update() is a periodic function executed by a timer and we can't have concurrent executions (unless we use crazy interval values). Maybe we should add a comment to make this more clear? -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

must do a check of the divisor (for 0) before > doing this do_div. Thanks for the code and the correction :-) Yes, we wanted to avoid 64 bits explicit divisions and we assumed test_time would have been a power of 2 (otherwise we'd accept a small error). Anyway, the last case brought by Sven depicts what we want to implement. The patch will be changed accordingly. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute

Hi, On 04/08/18 17:02, Sven Eckelmann wrote: > On Samstag, 4. August 2018 10:41:09 CEST Antonio Quartulli wrote: > [...] >>>> Documentation/ABI/testing/sysfs-class-net-batman-adv | 7 +++ >>> >>> Please discuss this with Jiri [1]. >>> >&g

Re: [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available

neral? > This flag prevents scheduling new measurements to this neighbour if one has already been scheduled and has not returned any result yet. What you are looking for is implemented in patch 1/7: a system-wide queue prevents concurrent measurements at all. All the measurements are seria

Re: [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute

tter when sending this code to netdev for merging. I've discussed this with Marek too and he is fine with this approach. Cheers, > > [1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2018-May/017814.html > -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [RFC PATCH] batman-adv: Increase DHCP snooped DAT entry purge timeout in DHT

P replies because we consider them "authoritative answers" that we can effectively trust. Unless somebody has any objection, I think we could consider as such also the "source IP/MAC" in an ARP request and apply the same logic. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Convert batadv_dat_addr_t to proper type

Hi, On 08/07/18 04:01, Sven Eckelmann wrote: > The #define for batadv_dat_addr_t is doing nothing else than giving u16 a > new typename. But C already has the special keyword "typedef" which is also > better supported by kernel-doc. > > Signed-off-by: Sven Eckelmann Ac

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Initialize memory for station_info

ng the sinfo object directly in cfg80211_get_station()? I think it is safe to assume that no user should store anything in this object before passing it to get_station(). At the same time future users of this API won't be able to hit the same issue we just did. (At the moment we are the only user of this

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Drop support for Linux < 3.16

ed to reduce the support overhead. > > [1] > https://lkml.kernel.org/r/a3d2d2b2c3559217eb8315d25df0c5883f922066.ca...@decadent.org.uk > > Signed-off-by: Sven Eckelmann Acked-by: Antonio Quartulli Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

[B.A.T.M.A.N.] [PATCH] batman-adv: enable DAT by default at compile time

DAT (Distributed ARP Table) has been enabled by default in the out-of-tree batman-adv kernel module for several years already. It can now be enabled in the kernel too. Signed-off-by: Antonio Quartulli --- This patch will obviously confict with ("batman-adv: Remove "default n" in

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: disable ethtool link speed detection when auto negotiation off

disabled, we should just assume that the speed is likely to be bogus and it's better to measure it. Does it make sense? Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: enable B.A.T.M.A.N. V compilation by default

On 13/05/18 06:24, Marek Lindner wrote: > Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> Acked-by: Antonio Quartulli <a...@unstable.cc> Once this change will make its way through the openwrt-routing feed, people will finally be able to enable BATMAN_V without recompi

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: disable ethtool link speed detection when auto negotiation off

On 13/05/18 06:02, Marek Lindner wrote: > If link auto-negotiation is disabled the exported link speed can > not be relied on. > > Signed-off-by: Marek Lindner <mareklind...@neomailbox.ch> Acked-by: Antonio Quartulli <a...@unstable.cc> -- Antonio Quartulli signature.

[B.A.T.M.A.N.] [PATCH] batman-adv: don't implement skb_postpush_rcsum() for linux >=4.4.47

skb_postpush_rcsum() has been implemented in 4.4.47 therefore our compat code has to be changed to prevent this function to be implemented when using those kernels. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- compat-include/linux/skbuff.h | 2 +- 1 file changed, 1 insertion

Re: [B.A.T.M.A.N.] [RFC maint] batman-adv: fix adding VLANs with partial state

d_vid and > batadv_softif_create_vlan. Especially because batadv_interface_add_vid calls > batadv_softif_create_vlan. This can probably be re-arranged a bit in the master branch. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH v2 maint] batman-adv: Fix TT sync flags for intermediate TT responses

static bool batadv_send_other_tt_response(struct > batadv_priv *bat_priv, > /* fill the rest of the tvlv with the real TT entries */ > batadv_tt_tvlv_generate(bat_priv, bat_priv->tt.global_hash, > tt_change, tt_len, > -

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix argument name in kernel-doc

On 10/05/18 23:33, Sven Eckelmann wrote: > On Donnerstag, 10. Mai 2018 17:29:46 CEST Antonio Quartulli wrote: >> Signed-off-by: Antonio Quartulli <a...@unstable.cc> >> --- >> net/batman-adv/tp_meter.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

[B.A.T.M.A.N.] [PATCH] batman-adv: fix argument name in kernel-doc

Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/tp_meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index 11520de9..55d8e4c1 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batm

Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: Avoid race in TT TVLV allocator helper

LAN specific") > Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@unstable.cc> Good catch. Unfortunately this issue was caused by my misunderstanding of the RCU mechanism when used with lists. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

much time digging into translation-table.c these days and I managed to confuse him enough. Thanks for pointing this out, Sven! Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix TT sync flags for intermediate TT responses

adv_tt_global_orig_entry_find() call which > already happens in batadv_tt_global_valid(). I like Marek's idea, but I'd suggest to change the name of the tt_*_valid() functions to something a bit more generic. Apart from that I agree that that the flags retrieval could directly be done within the callback which already knows if we are in the local or global case. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses

ese kind of (bogus) results avoids confusions while using things > like batctl's ping or traceroute. > > Reported-by: Andre Kasper <andre.kas...@gmx.de> > Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@unstable.cc> -- Antoni

Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses

On 14/04/18 17:20, Sven Eckelmann wrote: > On Samstag, 14. April 2018 10:11:28 CEST Antonio Quartulli wrote: >> An error message like like "returned invalid all-zero mac address" (or >> "multicast address") might help to distinguish similar "ambiguities

Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses

On 14/04/18 15:10, Sven Eckelmann wrote: > On Samstag, 14. April 2018 04:34:42 CEST Antonio Quartulli wrote: >> >> On 14/04/18 02:16, Sven Eckelmann wrote: > [...] >> We already handle the case of multiple originators handling the same MAC >> address, no? In that

Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses

dle the case of multiple originators handling the same MAC address, no? In that case I think we pick the "best" originator. This case sounds more like a validity check because "a zero MAC should not be in the translation table", or am I wrong? Cheers, -- Antonio Quartulli

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

On 13/03/18 16:52, Sven Eckelmann wrote: > On Dienstag, 13. März 2018 16:22:24 CET Antonio Quartulli wrote: > [...] >> (if we wanted to, we could still rename all the attrs pointing to the >> very same data type and unify them, but I don't have a strong opinion >&g

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

On 13/03/18 16:20, Sven Eckelmann wrote: > On Dienstag, 13. März 2018 16:02:34 CET Antonio Quartulli wrote: > [...] >> Another observation: do these attributes need to be DAT specific? or can >> we just define (or reuse) a generic HWADDRESS attribute that we might >> al

Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

re and not store only IPv4 addresses. This said, shouldn't we use a more specific name for the address? Another observation: do these attributes need to be DAT specific? or can we just define (or reuse) a generic HWADDRESS attribute that we might already be using somewhere else (i.e. for TT)? Regards, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid relation operator comparison with bool

adv_compare_eth return bool"). A relational (<, >, <= or >=) operator > is not the right one for such a check. > > Reported-by: David Binderman <dcb...@hotmail.com> > Signed-off-by: Sven Eckelmann <s...@narfation.org> > --- > Cc: David Binderman &l

Re: [B.A.T.M.A.N.] Can b.a.t.m.a.n. be configured to ARP for unknown clients?

his probe as some sort of "client keep alive" that tell the mesh "hey, I am still here". Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] Can b.a.t.m.a.n. be configured to ARP for unknown clients?

you distinguish between clients that have to be pinged and clients that do not need that? Another thing: consider that performing a simple ICMP ping from the mesh node to the local client won't be enough, because no packet generated by the client will enter the bat0 interface, thus it won't be d

Re: [B.A.T.M.A.N.] Batman -adv no longer backwards compatible with kernels Pre -4.0???

ntentionally so its no > longer backwards compatible with older kernels? > > What can i do? > -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix check of retrieved orig_gw in batadv_v_gw_is_eligible

node is NULL to detect this error. > > Fixes: 80b2d47be2c7 ("batman-adv: B.A.T.M.A.N. V - implement GW selection > logic") > Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> Acked-by: Antonio Quartulli <a...@unstable.cc> -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: Change batman_adv.h license to MIT

d ask for Acked-by from following persons > > Cc: Simon Wunderlich <s...@simonwunderlich.de> > Cc: Matthias Schiffer <mschif...@universe-factory.net> > Cc: Antonio Quartulli <a...@unstable.cc> > Cc: Andrew Lunn <and...@lunn.ch> Acked-by: Antonio Quartulli

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

; will only flood the kernel logs. The warnings must therefore be removed. > > Signed-off-by: Sven Eckelmann <sven.eckelm...@openmesh.com> Yeah, this makes sense. As a read only operation, the lock is not held on purpose, therefore such situation has to be expected. Acked-by: Antonio Quartu

Re: [B.A.T.M.A.N.] batman on top of vlan?

ved. What happens to the inner payload should not be batman's business. If I see this correctly. Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH maint v2] batman-adv: fix TT sync flag inconsistencies

for TT SYNC flags only Version 2 looks good to me. I had some doubts but I managed to clarify them with Linus on IRC. Acked-by: Antonio Quartulli <a...@unstable.cc> Cheers, -- Antonio Quartulli signature.asc Description: OpenPGP digital signature

Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies

d by BATADV_TT_REMOTE_MASK (0x00FF), however you are extracting only those covered by BATADV_TT_SYNC_MASK (0x00F0). Am I wrong or this is preventing the other 4 REMOTE flags (0x000F) to be set in tt_global_entry->common->flags (because you always filter them out when updating the entry)? Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

[B.A.T.M.A.N.] [PATCH] tp_meter: mark init function with __init

batadv_tp_meter_init() is invoked in batadv_init() only which is marked with __init. For this reason batadv_tp_meter_init() can be marked with __init as well and dropped after module load. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/tp_meter.c | 2 +- 1 file c

Re: [B.A.T.M.A.N.] Node freezes but still alive

kipedia.org/wiki/MAC_address#Address_details This is true for the interface MAC address, but this should not apply for the Cell-ID/BSSID. It can be a random ID. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH v7 1/5] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled

Hi, On Mon, Feb 06, 2017 at 07:48:23PM +0800, Antonio Quartulli wrote: > Hi, > > On Mon, Feb 06, 2017 at 10:56:25AM +0100, Sven Eckelmann wrote: > > It is therefore currently unknown how to continue from here. Antonio, > > please > > provide a statement what we

Re: [B.A.T.M.A.N.] bat0 trunk vlans?

eeds to know about all the VLANs in order to learn the MAC addresses of the clients. However, TT gets to know a new VLAN only when this is actually created (i.e. by creating bat0.X). The solution would be to create a VLAN on top of bat0 (i.e. bat0.20) and let the tagging happen at the node. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH v7 1/5] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled

later this week and let you know what I find. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH] alfred: Avoid buffer overflow while querying ARP cache

rface->interface, sizeof(arpreq.arp_dev)); arpreq is already set to 0 few lines above. why not simpling "sizeof(arpreq.arp_dev) - 1" as last argument for the strncpy() and avoid the line below? Or is this required for consistency with the rest of the code? Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] Fail to create tunnels using br-lan

ion. > > Thank you very much in advance. Dear Carlos, this looks pretty much about OpenVPN (if I am not wrong). Are you sure you posted it to the right mailing list? Cheers, -- Antonio Quartulli

[B.A.T.M.A.N.] [PATCH] batman-adv: remove unsed argument from batadv_dbg_arp() function

The argument "type" passed to the batadv_dbg_arp() function is never used. Remove it. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/distributed-arp-table.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/net/batman

Re: [B.A.T.M.A.N.] [PATCH v2] alfred: Externalized synchronization interval

be "Signed-off-by:" > > Shoot! v3 coming...dang fat fingers! tip: if you create the commit using the "-s" option, git will add the signed-off-by line for you ;) cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] Consistent bat0 hardware address?

udev/rules.d?  Or some other mechanism? Yes, I'd suggest using udev for this. batman-adv generates a random address every time it creates a new batX interface, therefore you need to use some userspace tool to make it static. Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Snoop DHCPACKs for DAT

> ARP Requests? have you tried enabling DAT debug and observing step by step what happens ? You could try to study a simple case: i.e. an unknown client that comes and connects for the first time..you can save the full log somewhere and then we can all have a look (knowing the MAC address of this client) Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Snoop DHCPACKs for DAT

ht be wrong, but that's why I ask measuring the effect) Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix speedy join in gateway client mode

e DHCP response. > > Fixes: 9cbc67d9da47 ("batman-adv: change interface_rx to get orig node") > Signed-off-by: Sven Eckelmann <s...@narfation.org> Acked-by: Antonio Quartulli <a...@unstable.cc> -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

On Mon, Jun 27, 2016 at 08:19:22AM +0200, Sven Eckelmann wrote: > On Monday 27 June 2016 10:36:13 Antonio Quartulli wrote: > > On Mon, Jun 13, 2016 at 01:26:31PM +0200, Sven Eckelmann wrote: > > > On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote: > > > &g

Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

On Mon, Jun 13, 2016 at 01:26:31PM +0200, Sven Eckelmann wrote: > On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote: > > + if (orig_throughput < (gw_throughput + threshold)) > > + goto out; > > Possible overflow problem in batadv_v_gw_is_eligib

Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

On Mon, Jun 13, 2016 at 01:12:52PM +0200, Sven Eckelmann wrote: > On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote: > > --- a/net/batman-adv/gateway_client.c > > +++ b/net/batman-adv/gateway_client.c > > @@ -215,6 +215,10 @@ void batadv_gw_election(struct

Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: Free tp_meter ack skb when it was not consumed

On Mon, Jun 20, 2016 at 06:55:49PM +0200, Sven Eckelmann wrote: > On Tuesday 21 June 2016 00:41:15 Antonio Quartulli wrote: > [...] > > However, how about changing the patch this way ? > > > > --- a/net/batman-adv/tp_meter.c > > +++ b/net/batman-adv/tp_meter.c > &

Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: Free tp_meter ack skb when it was not consumed

(r == NET_XMIT_DROP)) { this is the same check we do in batadv_send_skb_unicast(). Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific

On Mon, Jun 13, 2016 at 12:45:17PM +0200, Sven Eckelmann wrote: > On Sunday 12 June 2016 12:14:23 Antonio Quartulli wrote: > [...] > > + if (bat_priv->algo_ops->gw.show_sel_class) > > + return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff); > [..

[B.A.T.M.A.N.] [PATCH v5 4/4] batman-adv: disable sysfs knobs when GW-mode is not implemented

to make sure that settings injected by the user for this feature are rejected. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/sysfs.c | 28 1 file changed, 28 insertions(+) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c

[B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_v.c | 220 +++- net/batman-adv/gateway_client.c | 9 +- net/batman-adv/gateway_client.h | 2 + 3 files changed, 227 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/bat

[B.A.T.M.A.N.] [PATCH v5 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support

hen declaring batadv_gw_node_get() in gateway_client.h - rebased on top of current master Cheers, Antonio Quartulli (4): batman-adv: make the GW selection class algorithm specific batman-adv: make GW election code protocol specific batman-adv: B.A.T.M.A.N. V - implement GW selection logic

[B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific

-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_v.c | 34 ++ net/batman-adv/sysfs.c | 34 -- net/batman-adv/types.h | 13 + 3 files changed, 79 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/b

Re: [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Clean up untagged vlan when destroying via rtnl-link

quot;batman-adv: add per VLAN interface attribute framework") > Signed-off-by: Sven Eckelmann <s...@narfation.org> > Cc: Antonio Quartulli <a...@unstable.cc> Acked-by: Antonio Quartulli <a...@unstable.cc> -- Antonio Quartulli signature.asc Description: Digital signature

Re: [B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

On Fri, May 27, 2016 at 03:48:37PM +0200, Sven Eckelmann wrote: > On Wednesday 25 May 2016 23:27:35 Antonio Quartulli wrote: > > +#ifdef CONFIG_BATMAN_ADV_BATMAN_V > > +struct batadv_gw_node *batadv_gw_node_get(struct batadv_priv *bat_priv, > > +

Re: [B.A.T.M.A.N.] [PATCH v8 05/14] batman-adv: netlink: add translation table query

> because one is a simple check and the other one is a function call with side > effects. So I am not 100% sure at the moment and will leave this untouched for > now. Maybe Simon wants to add it or I will think about it a little bit more > about it. Although having both statements in the

[B.A.T.M.A.N.] [PATCH v4 6/6] batman-adv: disable sysfs knobs when GW-mode is not implemented

to make sure that settings injected by the user for this feature are rejected. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/sysfs.c | 28 1 file changed, 28 insertions(+) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c

[B.A.T.M.A.N.] [PATCH v4 4/6] batman-adv: make GW election code protocol specific

Each routing protocol may have its own specific logic about gateway election which is potentially based on the metric being used. Create two GW specific API functions and move the current election logic in the B.A.T.M.A.N. IV specific code. Signed-off-by: Antonio Quartulli <a...@unstable

[B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_v.c | 220 +++- net/batman-adv/gateway_client.c | 9 +- net/batman-adv/gateway_client.h | 4 + 3 files changed, 229 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/bat

[B.A.T.M.A.N.] [PATCH v4 3/6] batman-adv: statically print gateway table header

To make it easier to search through the code it is better to print static strings directly instead of using format strings printing constants. This was addressed in a previous patch, but the Gateway table header was not updated accordingly. Signed-off-by: Antonio Quartulli <a...@unstable

[B.A.T.M.A.N.] [PATCH v4 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support

"batman-adv: split routing API data structure in subobjects" as patch 1 - check if algo_ops->gw.get_best_gw_node was implemented before calling it - add patch to disable GW mode knobs if API have not been implemented (6/6) Cheers, Antonio Quartulli (6): batman-adv: split rou

Re: [B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Remove unused primary_if variable

tadv_iv_ogm_schedule(), thus primary_if is useless in this function. Simon, comments ? Cheers, -- Antonio Quartulli signature.asc Description: Digital signature

[B.A.T.M.A.N.] [PATCH v3 5/5] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_v.c | 220 +++- net/batman-adv/gateway_client.c | 9 +- net/batman-adv/gateway_client.h | 4 + 3 files changed, 229 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/bat

[B.A.T.M.A.N.] [PATCH v3 4/5] batman-adv: make GW election code protocol specific

Each routing protocol may have its own specific logic about gateway election which is potentially based on the metric being used. Create two GW specific API functions and move the current election logic in the B.A.T.M.A.N. IV specific code. Signed-off-by: Antonio Quartulli <a...@unstable

[B.A.T.M.A.N.] [PATCH v3 0/5] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support

to right patch - remove bat_ prefix from API names - API subobjects redefined as proper struct instead of anonymous ones to fix kernel-doc complaints - bonus kernel-doc added - missing include files added Changes from v2: - minimum default value of gw_sel_class restored to 1 Cheers, Antonio

[B.A.T.M.A.N.] [PATCH v3 1/5] batman-adv: make the GW selection class algorithm specific

-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_v.c | 34 ++ net/batman-adv/sysfs.c | 36 ++-- net/batman-adv/types.h | 13 + 3 files changed, 81 insertions(+), 2 deletions(-) diff --git a/net/batm

[B.A.T.M.A.N.] [PATCH v3 2/5] batman-adv: split routing API data structure in subobjects

elds names. These are batman-adv private structs and there is no need to always prepend such prefix, which only makes function invocations much much longer. Signed-off-by: Antonio Quartulli <a...@unstable.cc> --- net/batman-adv/bat_algo.c | 14 ++--- net/batman-adv/bat_iv_og

Re: [B.A.T.M.A.N.] [PATCH v2 1/5] batman-adv: make the GW selection class algorithm specific

On Mon, May 23, 2016 at 10:09:12PM +0800, Antonio Quartulli wrote: > On Mon, May 23, 2016 at 05:00:33PM +0800, Antonio Quartulli wrote: > > +static ssize_t batadv_store_gw_sel_class(struct kobject *kobj, > > +struct attribute *a

  1   2   3   4   5   6   7   8   9   10   >