[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Split README in kernel and external part

2011-12-23 Thread Sven Eckelmann
by splitting it in a README which contains the same data as available in the kernel and README.external which contains the information that only affect the external module. Signed-off-by: Sven Eckelmann s...@narfation.org --- README | 28 +++- README.external | 45

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix compilation with linux 2.6.29 and 2.6.30

2011-12-23 Thread Sven Eckelmann
Linux v2.6.30-2332-gfddd520 introduced a seventh parameter to __module_param_call. It is used to give a slightly different user experience for bool parameters. Older kernels can just drop this information using a special compat wrapper for __module_param_call. Signed-off-by: Sven Eckelmann s

Re: [B.A.T.M.A.N.] HowTo Test Bla2

2011-12-25 Thread Sven Eckelmann
On Sunday 25 December 2011 22:36:18 Clemens John wrote: Hi, I want to test the Bridge loop avoidance II with our OpenWrt Freifunk firmware. Is there a version that works and can be tested? Which git repo do I have to use and what are the main steps to compile it into openwrt? Simon

Re: [B.A.T.M.A.N.] HowTo Test Bla2

2011-12-27 Thread Sven Eckelmann
On Tuesday 27 December 2011 23:27:51 Clemens John wrote: On Dienstag, 27. Dezember 2011 23:06:36 Clemens John wrote: Simon commited another patchset today so I took the latest snapshot of his blaII_rebase branch [1] and put it on our own server [2]. I changed the name of the folder inside

Re: [B.A.T.M.A.N.] HowTo Test Bla2

2011-12-30 Thread Sven Eckelmann
Sorry for the late reply, but nearly all batman-adv developers are currently without internet access (I've just gone alone to a place with free wifi access to answer you). I am happy that you didn't gave up and are still trying to get it working. We hope that we can react a lot faster again in

[B.A.T.M.A.N.] [PATCH] batctl: Update copyright years

2011-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |2 +- allocate.h|2 +- bat-hosts.c |2 +- bat-hosts.h |2 +- bisect.c |2 +- bisect.h |2 +- debug.c |2 +- debug.h |2 +- functions.c |2 +- functions.h

[B.A.T.M.A.N.] [PATCH] batman-adv: Update copyright years

2011-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile|2 +- Makefile.kbuild |2 +- bat_debugfs.c |2 +- bat_debugfs.h |2 +- bat_iv_ogm.c|2 +- bat_ogm.h |2 +- bat_sysfs.c |2 +- bat_sysfs.h |2

[B.A.T.M.A.N.] [PATCH] batmand: Update copyright years

2011-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile|2 +- allocate.c |2 +- allocate.h |2 +- batman.c|2 +- batman.h|2 +- bitarray.c |2 +- bitarray.h |2 +- hash.c |2

[B.A.T.M.A.N.] [PATCH] vis: Update copyright years

2011-12-31 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- Makefile |2 +- allocate.c|2 +- allocate.h|2 +- hash.c|2 +- hash.h|2 +- list-batman.c |2 +- list-batman.h |2 +- udp_server.c |2 +- vis-types.h |2 +- vis.c

Re: [B.A.T.M.A.N.] HowTo Test Bla2

2012-01-02 Thread Sven Eckelmann
[...] I enabled blaII on one node, and after that all nodes connected to the vpn went unreachable. Most of them use 2011.0.0, some others 2011.4.0, running an ad-hoc iface as bat-adv-iface and bat0, tap0 and ath0(master, for clients) as a bridge. Do the blaII-packets kill all the other nodes?

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: pass the correct header size to interface_rx

2012-01-31 Thread Sven Eckelmann
On Tuesday 31 January 2012 22:35:10 Antonio Quartulli wrote: in recv_unicast_frag(), the third parameter of the interface_rx() invocation, which is the size of the current header, is wrongly computed. Really (actually it is the fourth, but I don't want to talk about that)? Wasn't the

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use ETH_ALEN instead of hardcoded numeric constants

2012-02-04 Thread Sven Eckelmann
On Monday 30 January 2012 20:59:17 Antonio Quartulli wrote: In packet.h the numeric constant 6 is used instead of the more portable ETH_ALEN define. This patch substitute any hardcoded value with such define. Acked-by: Sven Eckelmann s...@narfation.org Can you please also look through batctl

[B.A.T.M.A.N.] [RFCv2] batman-adv: Replace bitarray operations with bitmap

2012-02-04 Thread Sven Eckelmann
bitarray.c consists mostly of functionality that is already available as part of the standard kernel API. batman-adv could use architecture optimized code and reduce the binary size by switching to the standard functions. Signed-off-by: Sven Eckelmann s...@narfation.org --- Just renamed all

Re: [B.A.T.M.A.N.] batctl set different bw not the one passed as paramenter

2012-02-05 Thread Sven Eckelmann
On Sunday 05 February 2012 18:34:39 Gioacchino Mazzurco wrote: as in subject eigenServer gioacchino # batctl gw server 10MBit/5MBit eigenServer gioacchino # batctl gw server (announced bw: 8MBit/5MBit) why? Because it works similar to wifi coverage when you use `iw phy phy0 set distance

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove declaration of only locally used functions

2012-02-05 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- This should help us to find unused code. The test was done with a script that was inspired by another script from d0tslash. I would like to add this to the daily tests when this patch was added to next. set -e defined=`nm -g --defined-only *.o

[B.A.T.M.A.N.] [PATCH] batman-adv: Remove declaration of only locally used functions

2012-02-06 Thread Sven Eckelmann
The blaII code removed references to two functions outside of the own source file. route_unicast_packet can be marked as static since 9c11509d3bbf914060be1bcb4448ea69d571fcb9 and tt_global_del since 7c5289cb52a5cecaeeddc719cd52b50bb17263dd Signed-off-by: Sven Eckelmann s...@narfation.org

Re: [B.A.T.M.A.N.] [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr()

2012-02-09 Thread Sven Eckelmann
On Wednesday 08 February 2012 22:10:47 Danny Kukawka wrote: Use dev_hw_addr_random() instead of calling random_ether_addr() to set addr_assign_type correctly to NET_ADDR_RANDOM. Reset the state to NET_ADDR_PERM as soon as the MAC get changed via .ndo_set_mac_address. Signed-off-by: Danny

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix daily check regression in blaII

2012-02-10 Thread Sven Eckelmann
to distinguish between the used and unused variables because it doesn't see the function call anymore. The second problem was the use of simple subscopes where do {} while(0) whould have been necessary. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.h |5 +++-- soft

[B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove useless branch for NET_ADDR_RANDOM

2012-02-12 Thread Sven Eckelmann
910ccacb9dd2bfac8ce1ac411af514fe72fa84c0 introduced a branch for a statement that doesn't need it. Signed-off-by: Sven Eckelmann s...@narfation.org --- soft-interface.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/soft-interface.c b/soft-interface.c index 0087052

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Backport dev_hw_addr_random

2012-02-12 Thread Sven Eckelmann
910ccacb9dd2bfac8ce1ac411af514fe72fa84c0 introduced the hardware address initialization using dev_hw_addr_random. This function was added to linux with linux 2.6.36. Older kernel versions have to igore the NET_ADDR_RANDOM variable and use random_ether_addr directly. Signed-off-by: Sven Eckelmann

Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-02-17

2012-02-17 Thread Sven Eckelmann
On Friday 17 February 2012 15:23:23 David Miller wrote: From: Marek Lindner lindner_ma...@yahoo.de Date: Fri, 17 Feb 2012 15:18:20 +0800 The following changes since commit dcd6c92267155e70a94b3927bce681ce74b80d1f: Linux 3.3-rc1 (2012-01-19 15:04:48 -0800) are available in the git

[B.A.T.M.A.N.] [PATCH] batman-adv: use eth_hw_addr_random() instead of random_ether_addr()

2012-02-17 Thread Sven Eckelmann
.ndo_set_mac_address. v2: use bitops, adapt to eth_hw_addr_random() Signed-off-by: Danny Kukawka danny.kuka...@bisect.de [s...@narfation.org: Backported it to linux 2.6.29] Signed-off-by: Sven Eckelmann s...@narfation.org --- Important: This patch was already applied by David S. Miller in net

Re: [B.A.T.M.A.N.] mesh: received packet with own address as source address

2012-02-19 Thread Sven Eckelmann
On Monday 20 February 2012 00:45:01 Filippo Sallemi wrote: Hi all, after upgrade of batman package on my nodes I see a very decerase of performance of my mesh network. When I connect to some node i see every time this message: mesh: received packet with own address as source address What

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix indentation of multiline statements

2012-02-28 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- This patch is for *next* bat_sysfs.c |4 ++-- bitarray.c |8 gateway_client.c|2 +- gateway_common.c|4 ++-- hard-interface.c| 30 +++--- originator.c

[B.A.T.M.A.N.] [PATCH] batman-adv: Fix indentation of multiline statements

2012-02-28 Thread Sven Eckelmann
79b67f7add9982115e801e99fcfa92f27ff7bb12 and 0591c25abca985273be2aa47d128df0648184abd introduced a regression of the indentation of multiline statements. Signed-off-by: Sven Eckelmann s...@narfation.org --- This patch is for *master* after next (with the last patch) was merged into master. I can

Re: [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: introduce packet type handler array for incoming packets

2012-03-01 Thread Sven Eckelmann
On Thursday 01 March 2012 15:35:17 Marek Lindner wrote: The packet handler array replaces the growing switch statement, thus dealing with incoming packets in a more efficient way. Usually (there are corner cases) the compiler tries to build such kind of jump table from a large switch block.

[B.A.T.M.A.N.] Fix of nightly checkpatch errors

2012-03-07 Thread Sven Eckelmann
Hi, it seems that checkpatch in linux-next has new checks. I would like to propose some patches that removes these problems from batman-adv. We have some patches for next and some for master. The master patches can only be applied after merging next (after the next patches are applied). There

Re: [B.A.T.M.A.N.] Fix of nightly checkpatch errors [checkpatch.bundle]

2012-03-07 Thread Sven Eckelmann
On Wednesday 07 March 2012 09:05:52 Sven Eckelmann wrote: Here is an example how to use it: $ git pull checkpatch.bundle master:master $ git pull checkpatch.bundle next:next# v2 git bundle -d523a2f417dfdecbee5ef87f7d98694d60c39ac6 batman-adv: Fix indentation of multiline statements

[B.A.T.M.A.N.] [PATCH 1/8-next] batman-adv: Ignore 80-chars per line limits for strings

2012-03-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 54 -- bat_sysfs.c | 16 gateway_client.c| 31 +++-- gateway_common.c|8 ++-- hard-interface.c| 36 +++-- icmp_socket.c

[B.A.T.M.A.N.] [PATCH 2/8-next] batman-adv: Don't begin block comments with only a /* line

2012-03-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c |3 +-- main.h | 13 ++--- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c index 677997b..a6d5d63 100644 --- a/bat_iv_ogm.c +++ b/bat_iv_ogm.c @@ -779,8 +779,7

[B.A.T.M.A.N.] [PATCH 3/8-next] batman-adv: Use {} braces consistent on the arms of a statement

2012-03-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- routing.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/routing.c b/routing.c index 01b66d4..7f8e158 100644 --- a/routing.c +++ b/routing.c @@ -237,8 +237,9 @@ int window_protected(struct bat_priv *bat_priv, int32_t

[B.A.T.M.A.N.] [PATCH 7/8-master] batman-adv: Use {} braces consistent on the arms of a statement

2012-03-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |3 ++- translation-table.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 1d6fb77..da220cf 100644 --- a/bridge_loop_avoidance.c

[B.A.T.M.A.N.] [PATCH 8/8-master] batman-adv: Remove spaces after a cast

2012-03-07 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index da220cf..23bfbed 100644 --- a/bridge_loop_avoidance.c +++ b

[B.A.T.M.A.N.] [PATCH] batman-adv: use shorter pr_warn instead of pr_warning

2012-03-26 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- compat.h |7 +++ hard-interface.c |4 ++-- send.c |2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/compat.h b/compat.h index 95b8706..f2cf35b 100644 --- a/compat.h +++ b/compat.h @@ -57,6

[B.A.T.M.A.N.] [PATCH] batman-adv: Use eth_hw_addr_random compat also for kernel 3.3

2012-03-28 Thread Sven Eckelmann
The changes for eth_hw_addr_random were not merged in linux 3.3. Therefore, the compat layer has to provide it. Signed-off-by: Sven Eckelmann s...@narfation.org --- compat.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/compat.h b/compat.h index 46de8b0..92379ef

[B.A.T.M.A.N.] [PATCH] batman-adv: Add routing_algo to README

2012-03-29 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- README |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 01db663..88e8a1a 100644 --- a/README +++ b/README @@ -65,9 +65,9 @@ To deactivate an interface you have to write none into its All

[B.A.T.M.A.N.] [PATCHv2] batman-adv: Initialize lockdep class keys for hashes

2012-03-29 Thread Sven Eckelmann
. Signed-off-by: Sven Eckelmann s...@narfation.org --- Sry, sent the wrong patch (the checkpatch-unclean one) bridge_loop_avoidance.c | 12 hash.c |8 hash.h |3 +++ 3 files changed, 23 insertions(+), 0 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCH] batman-adv: Add routing_algo to README

2012-04-02 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- Please apply directly to next and merge into master. Thx README |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README b/README index 4ee2f54..82c075f 100644 --- a/README +++ b/README @@ -66,10 +66,11 @@ All

Re: [B.A.T.M.A.N.] Subject: batman-adv Openwrt Kamikaze / 8.09 problem

2012-04-08 Thread Sven Eckelmann
On Sunday 08 April 2012 10:39:16 3zl Trizonelabs wrote: Seeking for hep to get batman-adv running on Openwrt Kamikaze 8.09 build Kernel 2.6.30 Build runs ok, but module not loaded. batctl -v ...batman-adv module not loaded Try to load manually : insmod

Re: [B.A.T.M.A.N.] Question howto build batman-adv Openwrt Kamikaze 8.09 rev 2012 build

2012-04-08 Thread Sven Eckelmann
On Sunday 08 April 2012 14:14:15 3zl Trizonelabs wrote: How could i build a newer release of batman-adv (2012) for Openwrt 8.09 or devel ? I haven't tested kamikaze together with batman-adv 2012.1.x, but here are some things which look a little bit confusing: Or maybe i did something wrong

Re: [B.A.T.M.A.N.] Security for batman-adv

2012-04-09 Thread Sven Eckelmann
On Sunday 08 April 2012 21:59:42 xjod...@gmail.com wrote: Hi, I will like to know if batman-adv have plan to support MACsec (802.1AE) to add security on the layer 2. At the moment, we see this part as we are on top of it or below it [1] and not part of your protocol. Or are you talking about

Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-04-07

2012-04-10 Thread Sven Eckelmann
On Tuesday, April 10, 2012 12:21:19 PM David Miller wrote: From: Antonio Quartulli or...@autistici.org Date: Sat, 7 Apr 2012 20:49:42 +0200 this is the updated and cleaned up version of our last pull request (sent on 2012-04-05). You absolutely must base your tree off the correct tree,

Re: [B.A.T.M.A.N.] [PATCH 0/3] clean up patches

2012-04-12 Thread Sven Eckelmann
On Thursday, April 12, 2012 08:50:23 AM Antonio Quartulli wrote: On Mon, Apr 09, 2012 at 12:37:51AM +0200, Simon Wunderlich wrote: Hey Antonio, thanks a lot for fixing my style bugs!! There is a little bug in one (one line doubled), otherwise: Reviewed-by: Simon Wunderlich

[B.A.T.M.A.N.] [PATCH] net: cleanup unsigned to unsigned int

2012-04-17 Thread Sven Eckelmann
From: Eric Dumazet eric.duma...@gmail.com Use of unsigned int is preferred to bare unsigned in net tree. Signed-off-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: David S. Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- This one is already in net-next

Re: [B.A.T.M.A.N.] Batman as a kernel module

2012-04-17 Thread Sven Eckelmann
On Tuesday, April 17, 2012 02:05:40 PM Mitar wrote: Would some compatibility layer be possible to have to run Batman in user-space? Are there any existing known? KVM Kind regards, Sven signature.asc Description: This is a digitally signed message part.

Re: [B.A.T.M.A.N.] Traffic Control in batman-adv

2012-04-25 Thread Sven Eckelmann
On Wednesday 25 April 2012 17:27:03 gto...@inti.gob.ar wrote: Hi, First thing: Don't reply to random messages when you actually want to start a new topic. We are doing some tests with Traffic Control (tc) in routers with Openwrt running batman-adv, want to be able to share the bandwidth with

Re: [B.A.T.M.A.N.] Batman with Ubiquiti SDK

2012-04-29 Thread Sven Eckelmann
On Sunday 29 April 2012 09:00:02 Antonio Quartulli wrote: On Sun, Apr 29, 2012 at 01:56:02 +0200, Mitar wrote: Hi! Ubiquiti provides OpenWrt based SDK for their firmware. To my information, it contains some proprietary madwifi-based WiFi drivers with some older OpenWrt version. My

[B.A.T.M.A.N.] [RFC 1/2] batman-adv: Free local translation table on error in tt_init

2012-04-29 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/translation-table.c b/translation-table.c index 88c62f1..c3b7773 100644 --- a/translation-table.c +++ b/translation-table.c @@ -1776,8 +1776,10 @@ int

[B.A.T.M.A.N.] [RFC 2/2] batman-adv: Return error codes instead of -1 on failures

2012-04-29 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c |2 +- bridge_loop_avoidance.c |6 +++--- main.c | 27 --- originator.c| 18 +- translation-table.c | 24

[B.A.T.M.A.N.] [RFC 3/2] batman-adv: Free bla hashes on error in bla_init

2012-04-29 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/bridge_loop_avoidance.c b/bridge_loop_avoidance.c index 6d33140..4ac1061 100644 --- a/bridge_loop_avoidance.c +++ b/bridge_loop_avoidance.c

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Change make install path and run depmod

2012-05-03 Thread Sven Eckelmann
On Wednesday, May 02, 2012 11:16:13 PM Antonio Quartulli wrote: would it be cleaner to run depmod -e $(uname -r) instead of using -a ? Why? The module doesn't have to be build for the current kernel. Kind regards, Sven signature.asc Description: This is a digitally signed message

[B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Free local translation table on error in tt_init

2012-05-04 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/translation-table.c b/translation-table.c index 88c62f1..c3b7773 100644 --- a/translation-table.c +++ b/translation-table.c @@ -1776,8 +1776,10 @@ int

Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: Free local translation table on error in tt_init

2012-05-04 Thread Sven Eckelmann
On Friday, May 04, 2012 03:34:18 PM Marek Lindner wrote: On Sunday, April 29, 2012 17:06:42 Sven Eckelmann wrote: Signed-off-by: Sven Eckelmann s...@narfation.org --- translation-table.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/translation-table.c

[B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Return error codes instead of -1 on failures

2012-05-05 Thread Sven Eckelmann
Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c |2 +- bridge_loop_avoidance.c |6 +++--- main.c | 27 --- originator.c| 18 +- translation-table.c | 24

Re: [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Only set hash class after hash is initialized

2012-05-05 Thread Sven Eckelmann
On Saturday 05 May 2012 16:49:41 Antonio Quartulli wrote: if one hash_new succeeds and and the other fails, should we free the allocated structure before returning? Please read 201205041534.18504.lindner_ma...@yahoo.de Kind regards, Sven signature.asc Description: This is a digitally

Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: fix visualization output without neighbors on the primary interface

2012-05-07 Thread Sven Eckelmann
On Monday, May 07, 2012 06:35:31 AM Matthias Schiffer wrote: [] I have some questions about the code though: - Is there any reason vis_seq_print_text() allocates a buffer at all instead of just printing the data directy into the seq_file? Looking at the seq_printf implementation, there

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix locking in hash_add()

2012-05-08 Thread Sven Eckelmann
); hlist_add_head_rcu(data_node, head); - spin_unlock_bh(list_lock); ret = 0; - goto out; -err_unlock: - rcu_read_unlock(); +unlock: + spin_unlock_bh(list_lock); out: return ret; } Acked-by: Sven Eckelmann s...@narfation.org Thanks, Sven signature.asc

Re: [B.A.T.M.A.N.] [PATCH 07/14] batman-adv: split neigh_new function into generic and batman iv specific parts

2012-05-10 Thread Sven Eckelmann
On Wednesday, May 09, 2012 08:41:11 PM David Miller wrote: [...] The namespace pollution of the batman-adv code needs to improve, and I'm putting my foot down starting with this change. If you have a static function which is therefore private to a source file, name it whatever you want.

Re: [B.A.T.M.A.N.] Batman-adv simple configuration example

2012-05-10 Thread Sven Eckelmann
On Thursday 10 May 2012 22:48:54 Pedro Nuno Costa Rodrigues wrote: [] Best regards,Pedro Rodrigues - Portugal The line endings are completely broken in your mail. It is so hard to read that I stopped after the second paragraph. Kind regards, Sven signature.asc Description: This is a

[B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix namespace for hash_set_lock_class

2012-05-11 Thread Sven Eckelmann
This function was introduced in 2c9aa3b4c37bd55148f5f25212c89e7bf5f28497 without a proper namespace prefix. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |7 --- hash.c |3 ++- hash.h |3 ++- 3 files changed, 8

[B.A.T.M.A.N.] [PATCHv2 2/3] batman-adv: Fix namespace for hash_set_lock_class

2012-05-11 Thread Sven Eckelmann
This function was introduced in 2c9aa3b4c37bd55148f5f25212c89e7bf5f28497 without a proper namespace prefix. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |7 --- hash.c |3 ++- hash.h |3 ++- 3 files changed, 8

Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
On Friday, May 11, 2012 09:23:47 PM Andrew Lunn wrote: Two probably dumb questions... 1) Did you use objdump to check for any symbols you missed? Please look at https://lists.open-mesh.org/pipermail/linux-merge/2012-May/000851.html :D 2) A quick look at the patch suggests its changing

Re: [B.A.T.M.A.N.] pull request: batman-adv 2012-05-11

2012-05-11 Thread Sven Eckelmann
On Friday, May 11, 2012 06:01:44 PM David Miller wrote: From: Antonio Quartulli or...@autistici.org Date: Fri, 11 May 2012 14:21:17 +0200 this is a fixed version of the pull request issued on 2012-05-09. Comments introduced in this patchset are not following the net-tree guidelines.

[B.A.T.M.A.N.] [PATCHv3 01/23] batman-adv: Fix namespace for hash_set_lock_class

2012-05-11 Thread Sven Eckelmann
This function was introduced in 2c9aa3b4c37bd55148f5f25212c89e7bf5f28497 without a proper namespace prefix. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |7 --- hash.c |3 ++- hash.h |3 ++- 3 files changed, 8

[B.A.T.M.A.N.] [PATCHv3 02/23] batman-adv: Prefix bat_algo non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_algo.h |2 +- bat_iv_ogm.c |2 +- main.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bat_algo.h b/bat_algo.h index 9852a68

[B.A.T.M.A.N.] [PATCHv3 03/23] batman-adv: Prefix bat_debugfs non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c| 10 +- bat_debugfs.h|8 main.c |4 ++-- main.h |5 +++-- soft-interface.c |6 +++--- 5 files

[B.A.T.M.A.N.] [PATCHv3 04/23] batman-adv: Prefix bat_sysfs non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c | 12 ++-- bat_sysfs.h | 13 +++-- gateway_client.c |6 +++--- hard-interface.c |4 ++-- soft-interface.c |6 +++--- 5

[B.A.T.M.A.N.] [PATCHv3 05/23] batman-adv: Prefix bitarray non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c |6 +++--- bitarray.c |8 bitarray.h |4 ++-- routing.c|4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git

[B.A.T.M.A.N.] [PATCHv3 06/23] batman-adv: Prefix bridge_loop_avoidance non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |3 +- bridge_loop_avoidance.c | 28 +- bridge_loop_avoidance.h | 73 --- hard

[B.A.T.M.A.N.] [PATCHv3 07/23] batman-adv: Prefix compat non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- compat.c |8 compat.h |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/compat.c b/compat.c index 35ad397..702c7c1 100644 --- a/compat.c

[B.A.T.M.A.N.] [PATCHv3 08/23] batman-adv: Prefix distributed-arp-table non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- distributed-arp-table.c | 22 distributed-arp-table.h | 67 +-- hard-interface.c|2

[B.A.T.M.A.N.] [PATCHv3 09/23] batman-adv: Prefix gateway-client non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c|2 +- bat_iv_ogm.c |6 +++--- bat_sysfs.c |4 ++-- gateway_client.c | 40 +--- gateway_client.h

[B.A.T.M.A.N.] [PATCHv3 10/23] batman-adv: Prefix gateway-common non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c |4 ++-- gateway_client.c | 12 +++- gateway_common.c |7 --- gateway_common.h |5 +++-- 4 files changed, 16 insertions(+), 12

[B.A.T.M.A.N.] [PATCHv3 12/23] batman-adv: Prefix hash non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |8 hash.c |4 ++-- hash.h |6 +++--- originator.c|4 ++-- translation-table.c

[B.A.T.M.A.N.] [PATCHv3 15/23] batman-adv: Prefix ring_buffer non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c | 14 +++--- ring_buffer.c |5 +++-- ring_buffer.h |5 +++-- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/bat_iv_ogm.c b

[B.A.T.M.A.N.] [PATCHv3 16/23] batman-adv: Prefix routing non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c | 15 +++--- gateway_client.c |5 +++-- main.c | 16 +++ originator.c |5 +++-- routing.c| 60

[B.A.T.M.A.N.] [PATCHv3 17/23] batman-adv: Prefix send non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c|9 + distributed-arp-table.c |8 ++-- hard-interface.c|4 ++-- icmp_socket.c |2 +- main.c

[B.A.T.M.A.N.] [PATCHv3 18/23] batman-adv: Prefix soft-interface non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- hard-interface.c |8 routing.c|9 + send.c |2 +- soft-interface.c | 16 soft-interface.h | 13

[B.A.T.M.A.N.] [PATCHv3 19/23] batman-adv: Prefix translation-table non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |4 +-- bat_iv_ogm.c| 23 +++-- bridge_loop_avoidance.c |4 +-- distributed-arp-table.c |2 +- gateway_client.c

[B.A.T.M.A.N.] [PATCHv3 21/23] batman-adv: Prefix vis non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |2 +- main.c|4 ++-- routing.c |8 vis.c | 20 ++-- vis.h | 18 +- 5 files

[B.A.T.M.A.N.] [PATCHv3 22/23] batman-adv: Prefix main non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_debugfs.c |6 ++--- bat_iv_ogm.c| 16 ++--- bridge_loop_avoidance.c |2 +- hard-interface.c| 14

[B.A.T.M.A.N.] [PATCHv3 20/23] batman-adv: Prefix unicast non-static functions with batadv_

2012-05-11 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- distributed-arp-table.c |6 +++--- originator.c|4 ++-- routing.c |9 + unicast.c | 34

[B.A.T.M.A.N.] [PATCHv4 07/23] batman-adv: Prefix compat non-static functions with batadv_

2012-05-12 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- Corrected declaration of batadv_free_rcu_* compat.c |8 compat.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/compat.c b

[B.A.T.M.A.N.] [PATCHv4 06/23] batman-adv: Prefix bridge_loop_avoidance non-static functions with batadv_

2012-05-12 Thread Sven Eckelmann
namespace avoids such a problem. Reported-by: David Miller da...@davemloft.net Signed-off-by: Sven Eckelmann s...@narfation.org --- Fixed alignment of arguments in batadv_bla_tx bat_debugfs.c |3 ++- bridge_loop_avoidance.c | 28 ++-- bridge_loop_avoidance.h | 67

[B.A.T.M.A.N.] [PATCH 1/8] batman-adv: Move hash_ipv4 to distributed-arp-table.c

2012-05-12 Thread Sven Eckelmann
hash_ipv4 is only used in distributed-arp-table.c and therefore can be placed inside this file instead of the header. Signed-off-by: Sven Eckelmann s...@narfation.org --- distributed-arp-table.c | 24 +++- distributed-arp-table.h | 22 -- 2 files

[B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Prefix bitarray static inline functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c | 13

[B.A.T.M.A.N.] [PATCH 3/8] batman-adv: Prefix hard-interface static inline functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c| 14

[B.A.T.M.A.N.] [PATCH 5/8] batman-adv: Prefix originator static inline functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c |4

[B.A.T.M.A.N.] [PATCH 6/8] batman-adv: Prefix unicast static inline functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- distributed-arp-table.c |2

[B.A.T.M.A.N.] [PATCH 8/8] batman-adv: Prefix compat static inline functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- compat.h |6 +++--- 1 file

Re: [B.A.T.M.A.N.] [PATCH 1/8] batman-adv: Move hash_ipv4 to distributed-arp-table.c

2012-05-12 Thread Sven Eckelmann
On Saturday 12 May 2012 13:56:55 Antonio Quartulli wrote: On Sat, May 12, 2012 at 01:48:52 +0200, Sven Eckelmann wrote: hash_ipv4 is only used in distributed-arp-table.c and therefore can be placed inside this file instead of the header. Signed-off-by: Sven Eckelmann s...@narfation.org

[B.A.T.M.A.N.] [PATCH 02/18] batman-adv: Prefix bat_iv_ogm local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_iv_ogm.c | 255

[B.A.T.M.A.N.] [PATCH 03/18] batman-adv: Prefix bat_sysfs local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bat_sysfs.c | 250

[B.A.T.M.A.N.] [PATCH 04/18] batman-adv: Prefix bridge_loop_avoidance local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- bridge_loop_avoidance.c | 320

[B.A.T.M.A.N.] [PATCH 05/18] batman-adv: Prefix distributed-arp-table local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- distributed-arp-table.c | 106

[B.A.T.M.A.N.] [PATCH 06/18] batman-adv: Prefix gateway_client local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- gateway_client.c | 67

[B.A.T.M.A.N.] [PATCH 07/18] batman-adv: Prefix gateway_common local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- gateway_common.c | 10

[B.A.T.M.A.N.] [PATCH 08/18] batman-adv: Prefix hard-interface local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- hard-interface.c | 62

[B.A.T.M.A.N.] [PATCH 09/18] batman-adv: Prefix hash local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- hash.c |4 ++-- 1 file

[B.A.T.M.A.N.] [PATCH 10/18] batman-adv: Prefix icmp_socket local static functions with batadv_

2012-05-12 Thread Sven Eckelmann
All non-static symbols of batman-adv were prefixed with batadv_ to avoid collisions with other symbols of the kernel. Other symbols of batman-adv should use the same prefix to keep the naming scheme consistent. Signed-off-by: Sven Eckelmann s...@narfation.org --- icmp_socket.c | 66

<    5   6   7   8   9   10   11   12   13   14   >