__iomem applies to the IOMEM() pointee, not to the auto pointer
that points at it. Move the annotation to correct this.
Signed-off-by: Ahmad Fatoum
---
drivers/clk/imx/clk-vf610.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-vf610.c
Hi Ahmad.
On Thu, May 23, 2019 at 05:39:34PM +0200, Ahmad Fatoum wrote:
> The fixes are the same as in v2. The cleanup was made cleaner
> a bit.
>
> Changes since v2:
> - Collected Sam's Tested-by and Reviewed-by
> - Reinstated *_get_ddram_size helpers, but without #ifdefs,
> as
Hi Ahmad.
On Thu, May 23, 2019 at 04:29:32PM +0200, Ahmad Fatoum wrote:
> sama5d2.c was added alongside the update to the remaining clk drivers
> to support the new upstream device tree bindings, but wasn't wired in
> anywhere.
>
> To prepare for usage in future sama5d2 support, fix compilation
Hi again.
On Thu, May 23, 2019 at 04:29:33PM +0200, Ahmad Fatoum wrote:
> They aren't used anywhere, thus drop them.
Thanks again.
>
> Suggested-by: Sam Ravnborg
> Signed-off-by: Ahmad Fatoum
Reviewed-by: Sam Ravnborg
___
barebox mailing list
Hello Sascha,
On 14/12/18 16:31, Ahmad Fatoum wrote:
> You can still merge the first two patches in this patchset however, they
> are applicable regardless.
I think the first two patches slipped through the cracks. Should I resend
the series without 3/4 and 4/4?
Cheers
>
>
> Cheers
> Ahmad
The fixes are the same as in v2. The cleanup was made cleaner
a bit.
Changes since v2:
- Collected Sam's Tested-by and Reviewed-by
- Reinstated *_get_ddram_size helpers, but without #ifdefs,
as suggested by Sascha
- While doing that, some more unnecessary #ifdef usage unraveled,
so
Use the potentially endianness-changing readl, writel and siblings
directly. They looks prettier and are the correct thing to do, as
even if the CPU is in big-endian mode, the peripherals are little-endian.
Unlike Linux, barebox readl,writel are the same Linux'
{readl,writel}_relaxed (they don't
at91sama5_get_ddram_size() is despite the name specific to the
sama5d3 which it was added alongside of. sama5d4 board code continues
to use it, but accessing SAMA5D3_BASE_MPDDRC (0xea00) on
a sama5d4 should result in a Data Abort (Datasheet Figure 5-1)..
Fix this by giving
These symbols aren't set anywhere in barebox and in some
cases they guard non-existing headers. Remove them.
Signed-off-by: Ahmad Fatoum
---
arch/arm/mach-at91/include/mach/at91_dbgu.h | 2 --
arch/arm/mach-at91/include/mach/hardware.h | 6 --
2 files changed, 8 deletions(-)
diff --git
From: Sam Ravnborg
The code that configure the stack uses sama5d3 constants.
Fix this to use the proper sama5d4 constants.
Boot tested on sama5d4_xplained.
Signed-off-by: Sam Ravnborg
---
arch/arm/boards/sama5d4_xplained/lowlevel.c | 2 +-
arch/arm/boards/sama5d4ek/lowlevel.c| 2 +-
c16bcbc644 ("ARM: at91: remove unused defines") removed the
conflicting defintions from these headers, so it's ok to
include them at the same time now. Do this and remove the
noise.
Suggested-by: Sascha Hauer
Signed-off-by: Ahmad Fatoum
---
.../mach-at91/include/mach/at91sam9_ddrsdr.h | 33
c16bcbc644 ("ARM: at91: remove unused defines") removed conflicting
definitions from the headers, so they can now be included all at
the same time. Do this.
Signed-off-by: Ahmad Fatoum
---
arch/arm/mach-at91/include/mach/hardware.h | 12
1 file changed, 12 deletions(-)
diff --git
This is in line with other platforms such as i.MX, which allow
specifying a debug port. As we can't use port indices because
the UARTs aren't mapped consecutively, allow specifying a hex
base at configuration time.
A side effect of this patch is that sama5d4's HAVE_AT91_DBGU2
is now honored as
Both at91_get_ddram_size and at91sama5_get_ddram_size are the
same if is_sdram == false and is_nb == true.
is_sdram is always false, because according to the sama5d{2,3,4}
datasheets, the lowest possible value for AT91_DDRSDRC_MD is 3
(i.e. none of them supports SDR SDRAM).
Therefore replace
compiling clk-main.c and clk-generated.c results in:
warning: passing argument 1 of 'memcpy' discards 'const' qualifier from
pointer target type [-Wdiscarded-qualifiers]
memcpy(clkmain->clk.parent_names, parent_names, parents_array_size);
^
Avoid this by
They aren't used anywhere, thus drop them.
Suggested-by: Sam Ravnborg
Signed-off-by: Ahmad Fatoum
---
drivers/clk/at91/dt-compat.c | 110 ---
drivers/clk/at91/pmc.c | 2 -
2 files changed, 112 deletions(-)
diff --git a/drivers/clk/at91/dt-compat.c
sama5d2.c was added alongside the update to the remaining clk drivers
to support the new upstream device tree bindings, but wasn't wired in
anywhere.
To prepare for usage in future sama5d2 support, fix compilation errors
related to absence of locks and unavailability of audio/i2s clock/pll
Hello Sam,
On 2/4/19 19:10, Sam Ravnborg wrote:
> Hi Ahmad.
>
> Thanks for looking into this.
>
> On Mon, Apr 01, 2019 at 12:32:57PM +0200, Ahmad Fatoum wrote:
>> sama5d2 was added along with the update to the upstream
>> device tree bindings, but wasn't wired in anywhere.
>>
>> To prepare for
Now that we have the kstrto*() functions we can use them to detect
various errors in passing numbers on the command line. Start with
the 'mw' command and make it more robust against illegal numbers.
Signed-off-by: Sascha Hauer
---
commands/mw.c | 24
1 file changed, 20
On 23/5/19 12:03, Philipp Zabel wrote:
> On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
>> For better readability should this code be reviewed
>> in future, replace the hardcoded input numbers
>> with an enum.
>>
>> This is just a cosmetic change and was verified
>> to not affect
On 23/5/19 12:01, Philipp Zabel wrote:
> On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
>> barebox has inherited the clk_set_parent(ldb_diN_sel, pll5_video_div)
>> from upstream kernel commit 32f3b8da22 ("ARM i.MX6q: set the LDB serial
>> clock parent to the video PLL"), where it was
Blobgen requires the BASE64 libraries, select them to provide them if
BLOBGEN is selected.
Signed-off-by: Rouven Czerwinski
---
lib/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig b/lib/Kconfig
index 7cf6975bcc..af178217f8 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@
On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
> For better readability should this code be reviewed
> in future, replace the hardcoded input numbers
> with an enum.
>
> This is just a cosmetic change and was verified
> to not affect clk-imx6.o.
>
> Signed-off-by: Ahmad Fatoum
Is this
On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
> From: Fabio Estevam
>
> Due to incorrect placement of the clock gate cell in the ldb_di[x]_clk
> tree, the glitchy parent mux of ldb_di[x]_clk can cause a glitch to
> enter the ldb_di_ipu_div divider. If the divider gets locked up, no
>
On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
> From: Philipp Zabel
>
> Due to incorrect placement of the clock gate cell in the ldb_di[x]_clk
> tree, the glitchy parent mux of ldb_di[x]_clk can cause a glitch to
> enter the ldb_di_ipu_div divider. If the divider gets locked up, no
>
On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
> From: Philipp Zabel
>
> MMDC CH1 is not used on i.MX6Q, so the handshake needed to change the
> parent of periph2_sel or the divider of mmdc_ch1_axi_podf will never
> succeed.
> Disable the handshake mechanism to allow changing the
On Tue, 2019-05-21 at 17:56 +0200, Ahmad Fatoum wrote:
> barebox has inherited the clk_set_parent(ldb_diN_sel, pll5_video_div)
> from upstream kernel commit 32f3b8da22 ("ARM i.MX6q: set the LDB serial
> clock parent to the video PLL"), where it was enabled for all i.MX6Q
> revisions after 1.0. It
On Wed, May 22, 2019 at 10:05:17AM +0200, Rouven Czerwinski wrote:
> From: Sascha Hauer
>
> This adds initial support for OP-TEE, see https://www.op-tee.org/
>
> barebox starts in secure mode as usual. When booting a kernel
> the bootm code also loads the optee_os binary. Instead of jumping
>
On Thu, May 23, 2019 at 09:49:00AM +0200, Jan Remmet wrote:
> if written_length is read from a partial written bucket it may be to
> big and xmalloc will panic barebox.
>
> Check if the value is sane. Make read_len unsigned to avoid negative
> values.
>
> Signed-off-by: Jan Remmet
> ---
> v2:
On Wed, May 22, 2019 at 07:17:28PM +0200, Ulrich Ölmann wrote:
> Starting with commit 5a1a5ed2537d ("ARM: images: use piggydata") this file
> type
> is not known anymore, so clean up.
>
> Signed-off-by: Ulrich Ölmann
> ---
> images/.gitignore | 1 -
> images/Makefile | 2 +-
> 2 files
On Wed, May 22, 2019 at 03:58:16PM +0200, Ahmad Fatoum wrote:
> Table 3. Boot mode setting in the user's guide[1] lists
> 0010 as 'Boot from EMMC'. Adjust diagram accordingly.
>
> [1]: https://www.mouser.com/ds/2/302/IMX8MDQLQEVKHUG-1280333.pdf
>
> Signed-off-by: Ahmad Fatoum
> ---
>
On Wed, May 22, 2019 at 12:33:56AM -0700, Andrey Smirnov wrote:
> Everyone:
>
> This series is a number of improvements (or so I though) I made while
> woring with USB on i.MX6. All of the patches are optional, so if some
> of the changes don't seem like an improvmement they can be dropped.
>
>
if written_length is read from a partial written bucket it may be to
big and xmalloc will panic barebox.
Check if the value is sane. Make read_len unsigned to avoid negative
values.
Signed-off-by: Jan Remmet
---
v2: replace compare < 0 by making read_len unsigned
On Wed, May 22, 2019 at 12:33:47AM -0700, Andrey Smirnov wrote:
> Since cbw.Length can be less that sizeof(cbw.CDB), add code to zero
> the whole struct out to avoid sending random stack data as a part of
> payload. There's no known case where this causes a problem, but it's a
> reasonable thing
On Mon, May 20, 2019 at 08:43:45PM -0400, Vivien Didelot wrote:
> The current support for the ZII Dev Boards time out on eth1 when
> booting from net, which takes a while:
>
> Booting entry 'net'
> eth0: 100Mbps full duplex link detected
> T T T eth0: DHCP client bound to address
On Tue, May 21, 2019 at 04:44:13PM +0200, Jan Remmet wrote:
> if written_length is read from a partial written bucket it may be to
> big and xmalloc will panic barebox.
>
> Check if the value is sane.
>
> Signed-off-by: Jan Remmet
> ---
> common/state/backend_bucket_direct.c | 4
> 1 file
36 matches
Mail list logo
