Re: [PATCH 4/8] usb: gadget: Fix Kconfig dependencies

2022-06-28 Thread Ahmad Fatoum
Hello Sascha, On 29.06.22 08:52, Sascha Hauer wrote: > Without GLOBALVAR selected the USB gadget autostart stuff can be > compiled, but without any functionality, as all functionality is > behind globalvars, so adding this dependency mykes sense. > >> select SYSTEM_PARTITIONS if USB_GADGET_M

Re: [PATCH 4/8] usb: gadget: Fix Kconfig dependencies

2022-06-28 Thread Sascha Hauer
On Mon, Jun 27, 2022 at 01:24:56PM +0300, Alexander Shiyan wrote: > WARNING: unmet direct dependencies detected for SYSTEM_PARTITIONS > Depends on [n]: GLOBALVAR [=n] > Selected by [y]: > - USB_GADGET_AUTOSTART [=y] && USB_GADGET [=y] && USB_GADGET_MASS_STORAGE [=y] > > WARNING: unmet direct depen

Re: [PATCH v2 02/11] ARM: at91: Make sdramc.h useable in multi image builds

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > There is no need to ifdef out all the static inlines as the headers > no longer conflicts. Drop the ifdefs so we can now use the header > in multi image builds. > > Signed-off-by: Sam Ravnborg Reviewed-by: Ahmad Fatoum > --- > .../mach-at91/include/mac

Re: [PATCH v2 08/11] ARM: at91: Add lowlevel helpers for at91sam9263

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Add lowlevel helpers like we already have for sama5d2 etc. Reviewed-by: Ahmad Fatoum > > Signed-off-by: Sam Ravnborg > --- > arch/arm/mach-at91/Makefile| 1 + > arch/arm/mach-at91/include/mach/sam92_ll.h | 54 ++ > arch/arm/mach-

Re: [PATCH v2 04/11] ARM: at91: Provide at91_mux_pio_pin for use in lowlevel

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Lowlevel init code may wish the ability to configure pins, e.g. for low > level debug UART. The pinctrl-at91 driver already exports an > at91_mux_pin function, but that one is only usable after driver > probe. Instead, provide an at91_mux_pio_pin function, w

Re: [PATCH v2 05/11] mci: atmel_mci: Add PBL helper to configure highcapacity

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Older atmel SoC's like at91sam9263 do not support highcapacity SD cards. > Add helper that can be used to disable highcapacity support > in the PBL code - as probing for the SD card type is not an option. Reviewed-by: Ahmad Fatoum > > Suggested-by: Ahmad

Re: [PATCH v2 06/11] ARM: at91: Add at91sam9 xload_mmc for PBL use

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Add xload support to at91sam9263 similar to what is already > present for the sama5d3. > The xload supports reading barebox.bin from a SDCARD from the > PBL and load the full barebox.bin and starts it. Reviewed-by: Ahmad Fatoum > > Signed-off-by: Sam Rav

Re: [PATCH v2 03/11] ARM: at91: Add initialize function to sdramc

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Port the sdramc initialize function from at91bootstrap. > It is needed from lowlevel code and is a replacement for the > sdramc init code in at91sam926x_board_init.h > > Signed-off-by: Sam Ravnborg Reviewed-by: Ahmad Fatoum > +int at91sam9_sdramc_initia

Re: [PATCH v2 07/11] ARM: at91: Add extra register definitions

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 22:38, Sam Ravnborg wrote: > Copied from at91bootstrap. Required in subsequent patches. Reviewed-by: Ahmad Fatoum > > Signed-off-by: Sam Ravnborg > --- > arch/arm/mach-at91/include/mach/at91_pmc.h| 2 + > arch/arm/mach-at91/include/mach/at91sam9263.h | 14 +++ > .../include

[PATCH 6/6] drivers: led: pca955x: Remove redundant assignment

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/led/led-pca955x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/led/led-pca955x.c b/drivers/led/led-pca955x.c index 848feb9773..aa518fe738 100644 --- a/drivers/led/led-pca955x.c +++ b/drivers/led/led-pca955x.c @@ -387,

[PATCH 5/6] drivers: gpio: pcf857x: Remove redundant assignment

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/gpio/gpio-pcf857x.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-pcf857x.c b/drivers/gpio/gpio-pcf857x.c index fefd20de6f..612ef3a82e 100644 --- a/drivers/gpio/gpio-pcf857x.c +++ b/drivers/gpio/gpio-pcf857x.

[PATCH 3/6] drivers: regulator: fixed: Fix error path in probe

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/regulator/fixed.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index f068fded62..ddcc1bcb97 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -78,1

[PATCH 2/6] drivers: rtc: abracon: Remove redundant variable

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/rtc/rtc-abracon.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-abracon.c b/drivers/rtc/rtc-abracon.c index 6144fc0aa9..585b95c4a7 100644 --- a/drivers/rtc/rtc-abracon.c +++ b/drivers/rtc/rtc-abracon.c @@ -84,7

[PATCH 1/6] drivers: rtc: pcf8536: Remove redundant variable

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/rtc/rtc-pcf85363.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c index 7b785d6a77..b9f0fc6012 100644 --- a/drivers/rtc/rtc-pcf85363.c +++ b/drivers/rtc/rtc-pcf85363.c @@ -

[PATCH 4/6] drivers: pwm: imx: Remove redundant assignment

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- drivers/pwm/pwm-imx.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index 609765d895..c542b72796 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -206,7 +206,7 @@ stati

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Ahmad Fatoum
Hi Sam, On 28.06.22 23:18, Sam Ravnborg wrote: > Hi Ahmad, > > On Tue, Jun 28, 2022 at 11:12:39PM +0200, Ahmad Fatoum wrote: >> Hello Sam, >> >> On 28.06.22 21:23, Sam Ravnborg wrote: >>> Hi Ahmad, >>> On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: The following is the current

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi Ahmad, On Tue, Jun 28, 2022 at 11:12:39PM +0200, Ahmad Fatoum wrote: > Hello Sam, > > On 28.06.22 21:23, Sam Ravnborg wrote: > > Hi Ahmad, > > On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: > >> The following is the current set of patches so far to support > >> PBL for the skov-

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Ahmad Fatoum
Hello Sam, On 28.06.22 21:23, Sam Ravnborg wrote: > Hi Ahmad, > On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: >> The following is the current set of patches so far to support >> PBL for the skov-arm9cpu. > ... >> This is an RFC - because the code does not yet work :-( >> It fails t

Re: [PATCH v2 10/11] ARM: at91: Add xload support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi myself, On Tue, Jun 28, 2022 at 10:38:48PM +0200, Sam Ravnborg wrote: > This updates skov-arm9cpu with xload support, and we can now > use barebox as a replacment for at91bootstrap. > > Only boot via SD card is supported. > > Includes several suggestions from: Ahmad Fatoum > - Use ENTRY_FUNC

[WIP PATCH v2 09/11] atmel_lcdfb: add support for updated DT bindings

2022-06-28 Thread Sam Ravnborg
The updated bindings for the display node uses graph nodes to identify the panel. Update the driver to support the new binding: - Add support for the video pipeline (vpl) - Add guard-time to the chip info - Move deprecated display support to own function With this update there is support for spec

[PATCH v2 10/11] ARM: at91: Add xload support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
This updates skov-arm9cpu with xload support, and we can now use barebox as a replacment for at91bootstrap. Only boot via SD card is supported. Includes several suggestions from: Ahmad Fatoum - Use ENTRY_FUNCTION_WITHSTACK - Reshuffeled order in early init - SD card in not highcapacity - Drop ir

[PATCH v2 01/11] pwm: atmel: Fix build and update

2022-06-28 Thread Sam Ravnborg
The pwm-atmel driver was not updated to use the atomic api and did not build. Update the driver from linux kernel 5.16-rc7 and adapt to barebox to get the latest fixes including the conversion to atomic api. Signed-off-by: Sam Ravnborg --- drivers/pwm/pwm-atmel.c | 383 +

[PATCH v2 08/11] ARM: at91: Add lowlevel helpers for at91sam9263

2022-06-28 Thread Sam Ravnborg
Add lowlevel helpers like we already have for sama5d2 etc. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile| 1 + arch/arm/mach-at91/include/mach/sam92_ll.h | 54 ++ arch/arm/mach-at91/sam9263_ll.c| 215 + 3 files changed, 270 ins

[PATCH v2 02/11] ARM: at91: Make sdramc.h useable in multi image builds

2022-06-28 Thread Sam Ravnborg
There is no need to ifdef out all the static inlines as the headers no longer conflicts. Drop the ifdefs so we can now use the header in multi image builds. Signed-off-by: Sam Ravnborg --- .../mach-at91/include/mach/at91sam9_sdramc.h | 45 ++- 1 file changed, 4 insertions(+), 41

[PATCH v2 04/11] ARM: at91: Provide at91_mux_pio_pin for use in lowlevel

2022-06-28 Thread Sam Ravnborg
Lowlevel init code may wish the ability to configure pins, e.g. for low level debug UART. The pinctrl-at91 driver already exports an at91_mux_pin function, but that one is only usable after driver probe. Instead, provide an at91_mux_pio_pin function, which can be used at all times. This is similar

[PATCH v2 03/11] ARM: at91: Add initialize function to sdramc

2022-06-28 Thread Sam Ravnborg
Port the sdramc initialize function from at91bootstrap. It is needed from lowlevel code and is a replacement for the sdramc init code in at91sam926x_board_init.h Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 2 +- arch/arm/mach-at91/at91sam9_sdramc_ll.c |

[WIP PATCH v2 11/11] ARM: at91: Update DTS for skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Update the device tree with the following: - Add backlight node - Add panel node for the Logic L2 panel - Add graph node to connect display with the panel - Drop all obsolete properties for the display node The updates was done to have proper support for backlight and to be compatible with the upd

[PATCH 0/11] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
The following is the current set of patches so far to support PBL for the skov-arm9cpu. The pwm is not really part of this - but it is part of the story. The patch-set was triggered when someone reported a bug in the atmel pwm code. The code did not build - so I ported it over. Now I wanted to bo

[PATCH v2 07/11] ARM: at91: Add extra register definitions

2022-06-28 Thread Sam Ravnborg
Copied from at91bootstrap. Required in subsequent patches. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/at91_pmc.h| 2 + arch/arm/mach-at91/include/mach/at91sam9263.h | 14 +++ .../include/mach/at91sam9263_matrix.h | 23 +++- arch/arm/mach-at91/include/mach/at9

[PATCH v2 06/11] ARM: at91: Add at91sam9 xload_mmc for PBL use

2022-06-28 Thread Sam Ravnborg
Add xload support to at91sam9263 similar to what is already present for the sama5d3. The xload supports reading barebox.bin from a SDCARD from the PBL and load the full barebox.bin and starts it. Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/Makefile | 1 + arch/arm/mach-at91/

[PATCH v2 05/11] mci: atmel_mci: Add PBL helper to configure highcapacity

2022-06-28 Thread Sam Ravnborg
Older atmel SoC's like at91sam9263 do not support highcapacity SD cards. Add helper that can be used to disable highcapacity support in the PBL code - as probing for the SD card type is not an option. Suggested-by: Ahmad Fatoum Signed-off-by: Sam Ravnborg --- arch/arm/mach-at91/include/mach/xlo

Re: [RFC PATCH v1 0/8] ARM: at91: Add pbl support to skov-arm9cpu

2022-06-28 Thread Sam Ravnborg
Hi Ahmad, On Sun, May 15, 2022 at 09:37:59PM +0200, Sam Ravnborg wrote: > The following is the current set of patches so far to support > PBL for the skov-arm9cpu. ... > This is an RFC - because the code does not yet work :-( > It fails to mount the SD Card - for reasons I am yet to discover. > >

Re: [PATCH] drivers: firmware: arm-scmi: Use core_platform_driver() macro

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 08:19, Alexander Shiyan wrote: > Signed-off-by: Alexander Shiyan Reviewed-by: Ahmad Fatoum > --- > drivers/firmware/arm_scmi/driver.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c > b/drivers/firmware/arm_scmi/dr

Re: [PATCH] serial: ns16550: Reuse 48MHz default clock definition for non-DT OMAP boards

2022-06-28 Thread Ahmad Fatoum
On 28.06.22 10:04, Alexander Shiyan wrote: > Signed-off-by: Alexander Shiyan Reviewed-by: Ahmad Fatoum > - if (!IS_ENABLED(CONFIG_OFDEVICE)) > + if (!IS_ENABLED(CONFIG_OFDEVICE) || !np) Nitpick: struct device_node *np = dev_of_node(dev); if (!np) is equivalent, but a bit less ve

[PATCH] serial: ns16550: Reuse 48MHz default clock definition for non-DT OMAP boards

2022-06-28 Thread Alexander Shiyan
Signed-off-by: Alexander Shiyan --- arch/arm/mach-omap/omap_devices.c | 8 +--- drivers/serial/serial_ns16550.c | 8 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-omap/omap_devices.c b/arch/arm/mach-omap/omap_devices.c index beae59f74d..022616ba54 1