Re: bbdb-mode-map should inherit from special-mode-map

2011-04-14 Thread Ted Zlatanov
On Wed, 13 Apr 2011 14:47:11 -0500 Roland Winkler wink...@gnu.org wrote: RW On Wed Apr 13 2011 Ted Zlatanov wrote: It should be possible to support at least Emacs 23.x and XEmacs. Gnus does it so we can look there for potential problems and solutions. You could ask David Engster

Non-nil default value in hook variables

2011-04-14 Thread Leo
Hello, I have been bitten more than once by non-nil default values in hook variables such as: (defcustom bbdb-create-hook 'bbdb-creation-date :group 'bbdb :type 'hook) Then if one does (add-hook 'bbdb-create-hook 'bbdb-add-uuid) in one's .emacs, the default value may be ignored. I suggest

Re: bbdb-mode-map should inherit from special-mode-map

2011-04-14 Thread Roland Winkler
On Thu Apr 14 2011 Ted Zlatanov wrote: On Wed, 13 Apr 2011 14:47:11 -0500 Roland Winkler wink...@gnu.org wrote: RW On Wed Apr 13 2011 Ted Zlatanov wrote: It should be possible to support at least Emacs 23.x and XEmacs. Gnus does it so we can look there for potential problems and

Re: Non-nil default value in hook variables

2011-04-14 Thread Roland Winkler
On Fri Apr 15 2011 Leo wrote: I suggest change all these defcustom instances something like: (defcustom bbdb-create-hook nil :group 'bbdb :type 'hook) (add-hook 'bbdb-create-hook 'bbdb-creation-date) Agreed and thanks, that looks much cleaner! Roland

Re: [BBDB] Changelog 2010-04-10

2011-04-14 Thread Didier Verna
Roland Winkler wink...@gnu.org wrote: First of all, the most noteworthy change is that BBDB has been transfered from CVS to git. So for anonymous checkout, you should now use For those of us who had write access to the old repo, is that still the case ? What are the changes in the latest

Re: Non-nil default value in hook variables

2011-04-14 Thread Stefan Monnier
I suggest change all these defcustom instances something like: (defcustom bbdb-create-hook nil :group 'bbdb :type 'hook) (add-hook 'bbdb-create-hook 'bbdb-creation-date) Agreed and thanks, that looks much cleaner! But then don't define them as defcustom but just defvars since Custom gets

Re: Non-nil default value in hook variables

2011-04-14 Thread Roland Winkler
On Thu Apr 14 2011 Stefan Monnier wrote: I suggest change all these defcustom instances something like: (defcustom bbdb-create-hook nil :group 'bbdb :type 'hook) (add-hook 'bbdb-create-hook 'bbdb-creation-date) Agreed and thanks, that looks much cleaner! But then don't define

Re: Non-nil default value in hook variables

2011-04-14 Thread Roland Winkler
On Thu Apr 14 2011 Stefan Monnier wrote: I suggest change all these defcustom instances something like: (defcustom bbdb-create-hook nil :group 'bbdb :type 'hook) (add-hook 'bbdb-create-hook 'bbdb-creation-date) Agreed and thanks, that looks much cleaner! But then don't define

Is the feature to add/update record when sending emails useful?

2011-04-14 Thread Leo
Hi, I personally haven't used this much in Emacs. But since gmail does this and I have found it useful at times, I wonder if this feature should be part of the bbdb-mua feature set. Leo -- Benefiting from Server

Re: Non-nil default value in hook variables

2011-04-14 Thread Leo
On 2011-04-15 10:15 +0800, Roland Winkler wrote: One more thought on this: What should someone do who simply wants the hook to be nil? If add-hook is called explicitly in bbdb.el such people are stuck: their setting is lost when bbdb.el is loaded (whereas there was no such problem with the