Re: Congratulations

2009-08-26 Thread Larry Finger
Gábor Stefanik wrote: > 2009/8/27 Larry Finger : >> Gábor, >> >> Congratulations on your progress. With today's patches my BCM4312 >> 802.11b/g card with PCI ID 14e4:4315 works - I'm using it at the >> moment. I'm using WPA2 encryption and have connected to APs on >> channels 1 and 11. My logs are

Re: Congratulations

2009-08-26 Thread Gábor Stefanik
2009/8/27 Larry Finger : > Gábor, > > Congratulations on your progress. With today's patches my BCM4312 > 802.11b/g card with PCI ID 14e4:4315 works - I'm using it at the > moment. I'm using WPA2 encryption and have connected to APs on > channels 1 and 11. My logs are clean. That's good to hear!

Congratulations

2009-08-26 Thread Larry Finger
Gábor, Congratulations on your progress. With today's patches my BCM4312 802.11b/g card with PCI ID 14e4:4315 works - I'm using it at the moment. I'm using WPA2 encryption and have connected to APs on channels 1 and 11. My logs are clean. As you noted, performance is a little weak, but I get tran

[PATCH v3] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik --- v3: Use 16-bit writes. drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH v2] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik --- v2: No more "From: root". drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/driv

Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 23:38:48 Gábor Stefanik wrote: > From: root > > After some discussion on IRC about the PHY register write change, > I am not sure anymore if this is the right thing to do. > > Signed-off-by: Gábor Stefanik > --- > drivers/net/wireless/b43/phy_lp.c |3 ++- > 1 fi

Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
2009/8/26 Gábor Stefanik : > From: root The joys of an accidental "sudo git format-patch"... :-) > > After some discussion on IRC about the PHY register write change, > I am not sure anymore if this is the right thing to do. > > Signed-off-by: Gábor Stefanik > --- >  drivers/net/wireless/b43/ph

[PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
From: root After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik --- drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wirele

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 22:54:03 John W. Linville wrote: > On Wed, Aug 26, 2009 at 10:47:12PM +0200, Gábor Stefanik wrote: > > 2009/8/26 Michael Buesch : > > > And, everything in its own patch, please. I don't see a reason for > > > patching unrelated things in one big patch. > > > > Well, thi

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread John W. Linville
On Wed, Aug 26, 2009 at 10:47:12PM +0200, Gábor Stefanik wrote: > 2009/8/26 Michael Buesch : > > And, everything in its own patch, please. I don't see a reason for > > patching unrelated things in one big patch. > > Well, this patch is already in wireless-testing, so doing that would > now involve

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 22:47:12 Gábor Stefanik wrote: > 2009/8/26 Michael Buesch : > > On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: > >> -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) > >>  in the channel tune routines. > >> -Fix some typos & spec errors fou

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Gábor Stefanik
2009/8/26 Michael Buesch : > On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: >> -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) >>  in the channel tune routines. >> -Fix some typos & spec errors found by MMIO tracing. >> -Optimize b43_phy_write & b43_phy_mask/set/mas

Re: [PATCH] b43: Remove scary message from LP-PHY's Kconfig

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 21:48:52 Gábor Stefanik wrote: > From: root Gábor Stefanik > > The most common LP-PHY device, BCM4312, is now fully functional. > So, no need to say "probably won't work for you" anymore. > It's also not "for debuggers and developers only", as it is > perfectly usable

Re: [PATCH] ssb: Implement PMU LDO control and use it in b43

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 20:51:26 Gábor Stefanik wrote: > Implement the "PMU LDO set voltage" and "PMU LDO PA ref enable" > functions, and use them during LP-PHY baseband init in b43. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. __

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: > -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) > in the channel tune routines. > -Fix some typos & spec errors found by MMIO tracing. > -Optimize b43_phy_write & b43_phy_mask/set/maskset to use > only the minimal n

[PATCH] b43: Remove scary message from LP-PHY's Kconfig

2009-08-26 Thread Gábor Stefanik
From: root Gábor Stefanik The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say "probably won't work for you" anymore. It's also not "for debuggers and developers only", as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefani

[PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Gábor Stefanik
-Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) in the channel tune routines. -Fix some typos & spec errors found by MMIO tracing. -Optimize b43_phy_write & b43_phy_mask/set/maskset to use only the minimal number of MMIO accesses. (Write is possible using a single 32-bit MMI

[PATCH] ssb: Implement PMU LDO control and use it in b43

2009-08-26 Thread Gábor Stefanik
Implement the "PMU LDO set voltage" and "PMU LDO PA ref enable" functions, and use them during LP-PHY baseband init in b43. Signed-off-by: Gábor Stefanik --- drivers/net/wireless/b43/phy_lp.c | 10 +-- drivers/ssb/driver_chipcommon_pmu.c | 94 + incl

[PATCH v2] b43: LP-PHY: Fix and simplify Qdiv roundup

2009-08-26 Thread Gábor Stefanik
The Qdiv roundup routine is essentially a fixed-point division algorithm, using only integer math. However, the version in the specs had a major error that has been recently fixed (a missing quotient++). Replace Qdiv roundup with a rewritten, simplified version. Signed-off-by: Gábor Stefanik ---