Re: [PATCH] b43: Fix QoS defaults

2008-09-11 Thread Michael Buesch
On Thursday 11 September 2008 05:37:48 Larry Finger wrote: > Lorenzo Nava wrote: > >> I'm not a reverse engineer, so I have no chance to check the original > >> code to agree (or not) with you. > >> > > Ok, the mail has Johannes in Cc. I hope that he can tell me if me and > > Francesco are right

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Larry Finger
Lorenzo Nava wrote: >> I'm not a reverse engineer, so I have no chance to check the original >> code to agree (or not) with you. >> > Ok, the mail has Johannes in Cc. I hope that he can tell me if me and > Francesco are right or not. > Johannes please check it (I mean specs at > http://bcm-v4.si

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Lorenzo Nava
> > I'm not a reverse engineer, so I have no chance to check the original > code to agree (or not) with you. > Ok, the mail has Johannes in Cc. I hope that he can tell me if me and Francesco are right or not. Johannes please check it (I mean specs at http://bcm-v4.sipsolutions.net/802.11/QoS) ,

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Michael Buesch
On Wednesday 10 September 2008 22:11:53 Lorenzo Nava wrote: > >> > > The code is correct wrt specs. It says there are 0x16 words. > > First fix specs, then fix code, please. > > > Yes you're right, but just above the table of the parameters reported > at http://bcm-v4.sipsolutions.net/802.11/QoS

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Lorenzo Nava
>> > The code is correct wrt specs. It says there are 0x16 words. > First fix specs, then fix code, please. > Yes you're right, but just above the table of the parameters reported at http://bcm-v4.sipsolutions.net/802.11/QoS it says: The EDCF Q Info array in SHM contains four structs of 16 16-bi

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Michael Buesch
Stay on list. I'm not going to start another private thread for this. In general, I avoid private threads most of the time and barely answer them. There are so many people on the list that can answer your questions. On Wednesday 10 September 2008 17:50:33 Francesco Gringoli wrote: > > The code is

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Michael Buesch
On Wednesday 10 September 2008 15:18:07 Francesco Gringoli wrote: > Hi Michael, > > we are collecting every kind of material about Broadcom board, too. > Could you please point out the document with such specifications? http://bcm-v4.sipsolutions.net/802.11/QoS > I confirm what Lorenzo wrote:

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Francesco Gringoli
Hi Michael, we are collecting every kind of material about Broadcom board, too. Could you please point out the document with such specifications? I confirm what Lorenzo wrote: there are 32 bytes for queue. If you leave 22 then all the Qos mechanisms go wrong. Indeed, the bcm board takes (qu

Re: [PATCH] b43: Fix QoS defaults

2008-09-10 Thread Michael Buesch
On Wednesday 10 September 2008 00:15:14 Lorenzo Nava wrote: > Hi everybody, > > I worked with the QoS parameters trying to understand why, checking > them within the firmware, they don't seems to have the correct values > even if they were set correctly by the driver. > I think that there coul

Re: [PATCH] b43: Fix QoS defaults

2008-09-09 Thread Lorenzo Nava
Hi everybody, I worked with the QoS parameters trying to understand why, checking them within the firmware, they don't seems to have the correct values even if they were set correctly by the driver. I think that there could be an error in the b43.h file: /* SHM offsets to the QOS data structu

[PATCH] b43: Fix QoS defaults

2008-09-06 Thread Michael Buesch
This fixes the initialization of the default QoS parameters. This got broken by 0b57664cf2393bc1eff594ff7e5ff26533843fe6 Reported-by: Lorenzo Nava Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- John, please queue for the next merge window, as I'm not interested in finding explanations for