[bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-24 Thread stephane.litkowski
Hi, Here is my review of the document: General comments: - - The document requires sometimes to be more generic as it describes a flexible framework for DF election rather than focusing on default election or HRW. See detailed comments. - The new FSM

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-27 Thread Satya Mohanty (satyamoh)
Hi Stephane, Many thanks for your detailed review. We will take care of the comments and do the due diligence. Regarding one comment that you had [Stephane] Section 4.1 Any clue on why HRW has been picked compared to CHASH algorithms ? I am assuming you mean CHASH to be "Consistent Hashing”

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-30 Thread Eric C Rosen
Let me add a couple of minor comments: - The draft should state the action to be taken when receiving a route that has more than one DF Election Extended Community.  I think the two possible options are "treat the route as if it did not have any DF Election Extended Community", and "treat-as-w

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-30 Thread Ali Sajassi (sajassi)
Hi Eric, On 4/30/18, 7:46 AM, "Eric C Rosen" wrote: Let me add a couple of minor comments: - The draft should state the action to be taken when receiving a route that has more than one DF Election Extended Community. I think the two possible options are "treat the route

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-30 Thread Rabadan, Jorge (Nokia - US/Mountain View)
election-framework.auth...@ietf.org" Subject: Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework Resent-From: Resent-To: , , , , , Resent-Date: Monday, April 30, 2018 at 7:46 AM Let me add a couple of minor comments: - The draft should state the action to

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-04-30 Thread Eric C Rosen
On 4/30/2018 12:40 PM, Ali Sajassi (sajassi) wrote: The DF type is an 8-bit type, so there can be a single valid value. Sorry, for some reason I thought it was a set of flags.  My mistake ;-( ___ BESS mailing list BESS@ietf.org https://www.ietf.org/m

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-05-23 Thread Rabadan, Jorge (Nokia - US/Mountain View)
Stephane, We have addressed all your comments in rev 02 (just posted). Please see below with [S&J](Satya & Jorge). Thank you for your thorough review! Satya & Jorge From: "stephane.litkow...@orange.com" Date: Tuesday, April 24, 2018 at 11:04 AM To: "bess@ietf.org" , "draft-ietf-bess-evpn-df-e

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-05-24 Thread stephane.litkowski
One small comment: “this document elects a DF per . This means that unlike [RFC 7432],” s/RFC 7432/RFC7432/ This creates a Nits From: Rabadan, Jorge (Nokia - US/Mountain View) [mailto:jorge.raba...@nokia.com] Sent: Wednesday, May 23, 2018 21:36 To: LITK

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-05-24 Thread Rabadan, Jorge (Nokia - US/Mountain View)
Thank you Stephane. We’ll fix it for the next version. Jorge From: "stephane.litkow...@orange.com" Date: Thursday, May 24, 2018 at 2:03 PM To: "Rabadan, Jorge (Nokia - US/Mountain View)" , "bess@ietf.org" , "draft-ietf-bess-evpn-df-election-framework.auth...@ietf.org" Subject: RE: Shepherd's

Re: [bess] Shepherd's review of draft-ietf-bess-df-election-framework

2018-05-24 Thread stephane.litkowski
Ok thanks a lot for all the edits. The text is really good now. Let me know when the next revision is ready, I will then push the button to send it to IESG. Brgds, From: Rabadan, Jorge (Nokia - US/Mountain View) [mailto:jorge.raba...@nokia.com] Sent: Thursday, May 24, 2018 14:15 To: LITKOWSKI