Thank you Campbell, Bastien and CoDEmanX for reviewing my code.
I have implemented all of your suggestions.
All of the issues pointed in this review:
https://codereview.appspot.com/7651047/diff/1/node_efficiency_tools.py#newcode103
have been addressed.
The review has been done using not the
Note about Select Parent/Children:
This operator allows to select 'FRAME' that wraps selected nodes or select all
of the nodes that are children of selected 'FRAME'.
It's done using '[' and ']' keys.
Campbell said that it could be implemented on a higher level, but before it
happens, I'd leave
@Campbell
Thank you for cleaning up my code of node_efficiency_tools.py (revision 4435)
I assume that now it's ready to be moved to trunk, is it?
Do I have your permission to do it?
Thank you for your time.
With Respect
Bartek Skorupa
Revision: 4435
Final code clean up before moving to trunk:
revision 4436.
All suggested changes have been made.
I'd like to ask for final permission before I commit.
Thank you
With Respect
Bartek Skorupa
www.bartekskorupa.com
On 27 mar 2013, at 11:35, Bartek Skorupa (priv)
bartekskor...@bartekskorupa.com
On Wed, Mar 27, 2013 at 10:49 PM, Bartek Skorupa (priv)
bartekskor...@bartekskorupa.com wrote:
Final code clean up before moving to trunk:
revision 4436.
All suggested changes have been made.
I'd like to ask for final permission before I commit.
Thank you
With Respect
Bartek Skorupa
@ Bastien
Changed the code according to your guidelines.
Is the script now ok to go to trunk?
Thank you for your help.
Cheers,
Bartek Skorupa
www.bartekskorupa.com
On 25 mar 2013, at 17:33, Bartek Skorupa (priv)
bartekskor...@bartekskorupa.com wrote:
Hey,
@CoDEmanX:
I don't quite get what
Yes, imho it's good for addons/ dir. Would be cool if you could get
Campbell (ideasman_42) to review it too in the next days, else just move
it! :)
Bastien
On 26/03/2013 16:54, Bartek Skorupa (priv) wrote:
@ Bastien
Changed the code according to your guidelines.
Is the script now ok to go
I will ask Campbell for review.
If he reviews and say that it's ok - can I treat this as You have a permission
to move it to trunk?
Thank you.
Cheers
Bartek Skorupa
www.bartekskorupa.com
On 26 mar 2013, at 17:01, Bastien Montagne montagn...@wanadoo.fr wrote:
Yes, imho it's good for addons/
Yep. :)
On 26/03/2013 17:10, Bartek Skorupa (priv) wrote:
I will ask Campbell for review.
If he reviews and say that it's ok - can I treat this as You have a
permission to move it to trunk?
Thank you.
Cheers
Bartek Skorupa
www.bartekskorupa.com
On 26 mar 2013, at 17:01, Bastien
if the number of properties you pass to an operator differ, e.g. one
prop per Custom Property of the active object, then you shouldn't do
something like
prop1 = ...
prop2 = ...
...
prop20 = ...
to allow for up to 20 properties be passed to the operator. Why? Cause
you don't need 20 properties
Thank you very much.
Bartek Skorupa
www.bartekskorupa.com
On 26 mar 2013, at 17:53, CoDEmanX codem...@gmx.de wrote:
if the number of properties you pass to an operator differ, e.g. one
prop per Custom Property of the active object, then you shouldn't do
something like
prop1 = ...
Hey,
After recent commits of node_efficiency_tools.py I as an author call this
add-on ready.
All of the features that I had in mind have been included, documented on wiki
and in video tutorial.
Recent API changes have taken into account.
It certainly will develop further, but at this stage it's
Hi Bartek,
Just did a (very quick) skim review of your addon, and I agree that
there are valuable features in it, worth moving it to trunk. However, I
noted at least two points that imho should be addressed before the move:
First, you seems to mismatch labels and tips of operators! E.g.
Thank you for this quick review.
Yes you're right about my understanding of bl_label. I did mismatch this and I
can change it, np.
About my 'option' properties:
In many cases I can change it to enums, but sometimes StringProperty is used
because I need to pass more than one property in one go.
Hi,
On 25/03/2013 15:51, Bartek Skorupa (priv) wrote:
Thank you for this quick review.
Yes you're right about my understanding of bl_label. I did mismatch this and
I can change it, np.
About my 'option' properties:
In many cases I can change it to enums, but sometimes StringProperty is
Thank you for the explanation.
props = layout.operator(NodesLinkActiveToSelected.bl_idname, text=Replace
Links).prop1 = True
props.prop2 = True
props.prop3 = False
Oops… I didn't know you can do it :-) Really…
Every day I learn something.
I will change all those properties
Proper formatting:
props = layout.operator(NodesLinkActiveToSelected.bl_idname,
text=Replace Links)
props.prop1 = True
props.prop2 = True
props.prop3 = False
But please don't do this if the amount of props varies (prop1-propN)!
Use a CollectionProperty instead. I think i did this in the Game
On 25/03/2013 17:19, CoDEmanX wrote:
Proper formatting:
props = layout.operator(NodesLinkActiveToSelected.bl_idname,
text=Replace Links)
props.prop1 = True
props.prop2 = True
props.prop3 = False
Yes, right, sorry… :/
___
Bf-committers mailing
Hey,
@CoDEmanX:
I don't quite get what you mean by:
But please don't do this if the amount of props varies (prop1-propN)!
Could you elaborate, please?
Bartek Skorupa
www.bartekskorupa.com
On 25 mar 2013, at 17:19, CoDEmanX codem...@gmx.de wrote:
Proper formatting:
props =
19 matches
Mail list logo
