Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-12 Thread Brecht Van Lommel
On Sun, May 12, 2013 at 12:19 PM, Bastien Montagne wrote: > Done ( http://www.pasteall.org/42167/diff ), simply edited the relevant > items' labels (did not add "Mode" to paint modes, those names are > already long enough imho). Also removed the "cheap trick", think mode > selector is big enough b

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-12 Thread Bastien Montagne
On 12/05/2013 11:58, Brecht Van Lommel wrote: > On Sun, May 12, 2013 at 11:18 AM, Bastien Montagne > wrote: >> * Object mode menu is now longer when the "mode name" is too short >> (using a cheap trick)... But do we really want that? It takes some room >> in the header, on small screens it’s no

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-12 Thread Brecht Van Lommel
On Sun, May 12, 2013 at 11:18 AM, Bastien Montagne wrote: > * Object mode menu is now longer when the "mode name" is too short > (using a cheap trick)... But do we really want that? It takes some room > in the header, on small screens it’s not optimal imho. Ah, I just now noticed you left out the

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-12 Thread Bastien Montagne
Hi Cody, On 11/05/2013 21:31, CoDEmanX wrote: > Hey Mont, > > good work on the UI stuff, this is always great for python scripters :) > > > Two questions about the patch: > >> ** enum-operator-generated menus are now PULLDOWN in headers too. > Does that mean the visual order is inversed? Gah! I wa

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-12 Thread Bastien Montagne
Hi Brecht, thanks for the review! :) Updated patch ( http://www.pasteall.org/42162/diff ) addresses following points: * Object mode menu is now longer when the "mode name" is too short (using a cheap trick)... But do we really want that? It takes some room in the header, on small screens it’s n

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-11 Thread CoDEmanX
Hey Mont, good work on the UI stuff, this is always great for python scripters :) Two questions about the patch: > ** enum-operator-generated menus are now PULLDOWN in headers too. Does that mean the visual order is inversed? > ** All bit-flag enums expanded in ROW buttons now have a handling

Re: [Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-11 Thread Brecht Van Lommel
Some comments: * The object mode menu is too narrow now, the tranform space menu too wide. * EnumPropertyItem manipulators_items[] values should not have MANIPULATOR_ prefix for the item identifiers. * Regarding PROP_ENUM_NO_CONTEXT in rna_access.c. This is to ensure the callback always gets the sa

[Bf-committers] Some changes in 3D view header (and general RNA-generated UI)

2013-05-11 Thread Bastien Montagne
Hi devs, Here is a patch that was first intended to fix [#35224] "Transform orientation - order inconsistency" : http://www.pasteall.org/42132/diff It’s not a big deal in itself, but as it affects quite a few areas, I thought it would be better to post it here, so that all core devs have a cha