Re: [Bioc-devel] viewMedians

2014-06-02 Thread Hervé Pagès
There is a lot going on with respect to the view* stuff, and yes, it's not just about Rle's but they also need to work on atomic vectors. Right now min(), max(), sum(), and mean() all work on IntegerList, NumericList, RleList, XIntegerViews and XDoubleViews but implementations are disparate and s

Re: [Bioc-devel] viewMedians

2014-06-02 Thread Michael Lawrence
So rangeMeans,matrix implies rangeColMeans? Honestly, I would just have a rangeColMeans and rangeRowMeans, which is consistent with the existing row/colMeans. Don't see a good reason to prefer columns over rows. On Mon, Jun 2, 2014 at 5:34 PM, Peter Haverty wrote: > I have have rangeColMeans wh

Re: [Bioc-devel] viewMedians

2014-06-02 Thread Peter Haverty
I have have rangeColMeans which is essentially rangeMeans for vector/matrix. I renamed this to make it a method on rangeMeans. I think it would be great to have methods for all the commonly used types. We should put some thought into how these would all share as much code as is practical. Pete _

Re: [Bioc-devel] viewMedians

2014-06-02 Thread Michael Lawrence
While we rework things, what about adding support for atomic vectors, in addition to Rles? Also, what about functions that are optimized for partitionings? Those would be easy to write and would let us greatly accelerate e.g. sum,CompressedIntegerList. Right now we rely on rowsum() which is fast bu

Re: [Bioc-devel] viewMedians

2014-06-02 Thread Hervé Pagès
Hi Peter, Seems like you have a pretty good implementation of the view* functions in genoset. Nice work! And great to hear that there is so much room for improvements to the implementation currently in IRanges. I'll try to give this a shot soon but first I want to move Rle's to the S4Vectors pack

Re: [Bioc-devel] viewMedians

2014-06-02 Thread Michael Lawrence
Sounds cool. I agree about the need for range* functions, if just for simplicity and convenience. Are you able to attach the patch? Thanks, Michael On Sun, Jun 1, 2014 at 7:58 PM, Peter Haverty wrote: > I think viewMedians would be great. While you have the hood up, there are > some opportuni