Re: ECMP/multipath support

2011-01-09 Thread Joakim Tjernlund
Something else, in calc_next_hop: don't you need to return all next hops for ptmp links now that you support ECMP? The same as in ptp or bcast - multiple next hops are created by compositing returns of calc_next_hop(). Look at the caller of calc_next_hop(). Don't think it

Re: ECMP/multipath support

2011-01-06 Thread Ondrej Zajicek
On Mon, Jan 03, 2011 at 05:37:25PM +0100, Joakim Tjernlund wrote: Any plans to add support for Opaque LSAs/GMPLS in the near future? Nothing specific. Where (and how) is this feature used? We have an old zebra based GMPLS TE (using RSVP too) to allocate paths through our network. Don't

Re: ECMP/multipath support

2011-01-06 Thread Joakim Tjernlund
-Ondrej Zajicek santi...@crfreenet.org wrote: - On Mon, Jan 03, 2011 at 05:37:25PM +0100, Joakim Tjernlund wrote: Any plans to add support for Opaque LSAs/GMPLS in the near future? Nothing specific. Where (and how) is this feature used? We have an old zebra based GMPLS TE

Re: ECMP/multipath support

2011-01-03 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2011/01/01 10:51:03: On Thu, Dec 30, 2010 at 02:17:24AM +0100, Joakim Tjernlund wrote: Ah, good to hear. Any plans to add support for Opaque LSAs/GMPLS in the near future? Nothing specific. Where (and how) is this feature used? We have an

Re: ECMP/multipath support

2011-01-01 Thread Ondrej Zajicek
On Thu, Dec 30, 2010 at 02:17:24AM +0100, Joakim Tjernlund wrote: Ah, good to hear. Any plans to add support for Opaque LSAs/GMPLS in the near future? Nothing specific. Where (and how) is this feature used? BTW, I think the README could use an update: This software should be considered a

Re: ECMP/multipath support

2010-12-29 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/28 10:00:03: On Tue, Dec 28, 2010 at 02:12:53AM +0100, Joakim Tjernlund wrote: Right, some comments: - px_pos* is redundant. Just use rt_pos* for both V4 and V6. rt_pos* is a position in Router-LSA, px_pos* is a position in

Re: ECMP/multipath support

2010-12-29 Thread Ondrej Zajicek
On Wed, Dec 29, 2010 at 10:21:58PM +0100, Joakim Tjernlund wrote: Ah, now I see. You took the concept one step further. How does the lsa pos in add_network work for ac_stubnet_list? Stubnet lists does not have en interface connected, perhaps ac_stubnet_list isn't applicable for add_network?

Re: ECMP/multipath support

2010-12-29 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/30 01:55:34: On Wed, Dec 29, 2010 at 10:21:58PM +0100, Joakim Tjernlund wrote: Ah, now I see. You took the concept one step further. How does the lsa pos in add_network work for ac_stubnet_list? Stubnet lists does not have en

Re: ECMP/multipath support

2010-12-28 Thread Ondrej Zajicek
On Tue, Dec 28, 2010 at 02:12:53AM +0100, Joakim Tjernlund wrote: Right, some comments: - px_pos* is redundant. Just use rt_pos* for both V4 and V6. rt_pos* is a position in Router-LSA, px_pos* is a position in Rt Prefix-LSA. In IPv6, we use both and they might be different. - You can use

Re: ECMP/multipath support

2010-12-28 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/28 10:00:03: On Tue, Dec 28, 2010 at 02:12:53AM +0100, Joakim Tjernlund wrote: Right, some comments: - px_pos* is redundant. Just use rt_pos* for both V4 and V6. rt_pos* is a position in Router-LSA, px_pos* is a position in Rt

Re: ECMP/multipath support

2010-12-27 Thread Joakim Tjernlund
Other packets are sent to the neighbor IP address, which is a slight diversion from RFC 2328, but should not cause any problems. But a stricter router may reject OSPF msg over an ptp links if they aren't addressed to AllSPFRouters. I just noticed you impl. a PTMP I/F type, nice :) I

Re: ECMP/multipath support

2010-12-27 Thread Ondrej Zajicek
On Mon, Dec 27, 2010 at 08:06:17PM +0100, Joakim Tjernlund wrote: Other packets are sent to the neighbor IP address, which is a slight diversion from RFC 2328, but should not cause any problems. But a stricter router may reject OSPF msg over an ptp links if they aren't addressed

Re: ECMP/multipath support

2010-12-27 Thread Ondrej Zajicek
On Tue, Dec 28, 2010 at 01:15:28AM +0100, Joakim Tjernlund wrote: Other packets are sent to the neighbor IP address, which is a slight diversion from RFC 2328, but should not cause any problems. But a stricter router may reject OSPF msg over an ptp links if they aren't

Re: ECMP/multipath support

2010-12-27 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/28 01:55:42: On Tue, Dec 28, 2010 at 01:15:28AM +0100, Joakim Tjernlund wrote: Other packets are sent to the neighbor IP address, which is a slight diversion from RFC 2328, but should not cause any problems. But a

Re: ECMP/multipath support

2010-12-21 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 03:24:23: On Tue, Dec 21, 2010 at 01:22:48AM +0100, Joakim Tjernlund wrote: For PTP iface, the list contains at most one entry (so the scan is fast :-) ) and you have to examine it anyways to know neighbor's IP address. Yes, it

Re: ECMP/multipath support

2010-12-21 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 00:27:44: On Fri, Dec 17, 2010 at 02:02:07PM +0100, Joakim Tjernlund wrote: Something like this. It is not tested at all and and very simple. Here is version 2, even simpler :) That is nice, makes several things simpler. I

Re: ECMP/multipath support

2010-12-20 Thread Ondrej Zajicek
On Fri, Dec 17, 2010 at 09:03:01AM +0100, Joakim Tjernlund wrote: I don't remember all the details anymore but sharing IP address for numbered ptp I/Fs is not pathological. Having two independent networks with the same IP prefix seems pretty pathological to me. It should just work. Also any

Re: ECMP/multipath support

2010-12-20 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 00:22:26: On Fri, Dec 17, 2010 at 09:03:01AM +0100, Joakim Tjernlund wrote: I don't remember all the details anymore but sharing IP address for numbered ptp I/Fs is not pathological. Having two independent networks with the same IP

Re: ECMP/multipath support

2010-12-20 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 00:27:44: On Fri, Dec 17, 2010 at 02:02:07PM +0100, Joakim Tjernlund wrote: Something like this. It is not tested at all and and very simple. Here is version 2, even simpler :) That is nice, makes several things simpler. I

Re: ECMP/multipath support

2010-12-20 Thread Ondrej Zajicek
On Tue, Dec 21, 2010 at 12:25:49AM +0100, Joakim Tjernlund wrote: Perhaps you can add PTP IF type too? PTP is supported, do you mean PTMP? -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santi...@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3,

Re: ECMP/multipath support

2010-12-20 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 00:40:50: On Tue, Dec 21, 2010 at 12:25:49AM +0100, Joakim Tjernlund wrote: Perhaps you can add PTP IF type too? PTP is supported, do you mean PTMP? I meant a #define OSPF_IT_MPTP xx so one knows if it is a ptmp and ptp link. For ptp

Re: ECMP/multipath support

2010-12-20 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/21 00:59:18: On Fri, Dec 17, 2010 at 02:36:50PM +0100, Joakim Tjernlund wrote: Question: in calc_next_hop() does this* match 16.1.1 para 5. ...the parent vertex is a network that directly connects the calculating router to the

Re: ECMP/multipath support

2010-12-20 Thread Ondrej Zajicek
On Tue, Dec 21, 2010 at 01:22:48AM +0100, Joakim Tjernlund wrote: For PTP iface, the list contains at most one entry (so the scan is fast :-) ) and you have to examine it anyways to know neighbor's IP address. Yes, it is a small improvement I guess and you would find the remote IP address,

Re: ECMP/multipath support

2010-12-17 Thread Joakim Tjernlund
Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/17 00:50:41: On Thu, Dec 16, 2010 at 08:41:24PM +0100, Joakim Tjernlund wrote: This will find any ptp link that matches and several of them will match. Not really. For unnumbered ptp links (where sharing of IP addresses between several

Re: ECMP/multipath support

2010-12-17 Thread Joakim Tjernlund
/12/17 12:11 Subject: Re: ECMP/multipath support Sent by: owner-bird-us...@atrey.karlin.mff.cuni.cz Ondrej Zajicek santi...@crfreenet.org wrote on 2010/12/17 00:50:41: On Thu, Dec 16, 2010 at 08:41:24PM +0100, Joakim Tjernlund wrote: This will find any ptp link that matches

RE: ECMP/multipath support

2010-12-15 Thread Andrew Lemin
[mailto:owner-bird-us...@atrey.karlin.mff.cuni.cz] On Behalf Of Andrew Lemin Sent: 13 November 2010 20:22 To: Ondrej Zajicek Cc: Vincent Bernat; bird-us...@trubka.network.cz Subject: RE: ECMP/multipath support Hi Ondrej, That really is wonderful news. Thank you very much :) Please let me know

RE: ECMP/multipath support

2010-12-15 Thread Andrew Lemin
time and hard work. Regards, Andy. -Original Message- From: Ondrej Zajicek [mailto:santi...@crfreenet.org] Sent: 15 December 2010 11:38 To: Andrew Lemin Cc: Vincent Bernat; bird-us...@trubka.network.cz Subject: Re: ECMP/multipath support On Wed, Dec 15, 2010 at 10:03:08AM +, Andrew

Re: ECMP/multipath support

2010-12-15 Thread Joakim Tjernlund
On Wed, Dec 15, 2010 at 10:03:08AM +, Andrew Lemin wrote: Hello. How is development coming along for adding multi-path route support into BIRD? We already have BIRD multipath support for OSPF, static and Linux kernel protocols in our Git repository [*]. RIP will probably come

Re: ECMP/multipath support

2010-12-15 Thread Ondrej Zajicek
On Wed, Dec 15, 2010 at 02:27:31PM +0100, Joakim Tjernlund wrote: I remember we had an discussion about multiple unnumbered ptp links between two nodes. There was a potential problem in OSPF with asymmetric routing but the conclusion was that it would not happen as BIRD didn't support ECMP.

RE: ECMP/multipath support

2010-11-13 Thread Andrew Lemin
Sent: 13 November 2010 00:21 To: Andrew Lemin Cc: Vincent Bernat; bird-us...@trubka.network.cz Subject: Re: ECMP/multipath support On Thu, Nov 11, 2010 at 10:38:55AM +, Andrew Lemin wrote: Hi all, What does the BIRD dev team think? Is there anything more I can do to help with adding

Re: ECMP/multipath support

2010-11-12 Thread Ondrej Zajicek
On Thu, Nov 11, 2010 at 10:38:55AM +, Andrew Lemin wrote: Hi all, What does the BIRD dev team think? Is there anything more I can do to help with adding this functionality. Hello, currently i am finalizing link state detection for OSPF. After that i would probably look at ECMP. --

RE: ECMP/multipath support

2010-11-11 Thread Andrew Lemin
this functionality. We desperately need ECMP support in the RIP protocol. Thanks everyone :) Regards, Andy. -Original Message- From: Andrew Lemin Sent: 04 October 2010 16:55 To: 'Vincent Bernat'; Ondrej Zajicek Cc: bird-us...@trubka.network.cz Subject: RE: ECMP/multipath support Hi, I see two

RE: ECMP/multipath support

2010-10-04 Thread Andrew Lemin
To: Andrew Lemin Cc: Ondrej Zajicek; Vincent Bernat; bird-us...@trubka.network.cz Subject: Re: ECMP/multipath support Hello! For us ECMP is important as we load balance connections to remote customer sites across different ISPs for redundancy and performance. When doing that, please keep in mind

Re: ECMP/multipath support

2010-10-04 Thread Ondrej Zajicek
On Mon, Oct 04, 2010 at 04:55:12PM +0100, Andrew Lemin wrote: As long as multipath is implemented in the RIP protocol too, then go for the first method as it is the proper place for it. We NEED ECMP in RIP though. Please.. :) The point I was trying to make is by adding the functionality to the

RE: ECMP/multipath support

2010-10-01 Thread Andrew Lemin
-bird-us...@atrey.karlin.mff.cuni.cz] On Behalf Of Vincent Bernat Sent: 24 September 2010 10:41 To: bird-us...@trubka.network.cz Subject: ECMP/multipath support Hi! BIRD does not support EMCP yet. Looking at the source code, BIRD seems to be able to support ECMP routes internally by adding

RE: ECMP/multipath support

2010-10-01 Thread Andrew Lemin
...@crfreenet.org] Sent: 01 October 2010 13:19 To: Andrew Lemin Cc: Vincent Bernat; bird-us...@trubka.network.cz Subject: Re: ECMP/multipath support On Fri, Oct 01, 2010 at 10:40:58AM +0100, Andrew Lemin wrote: Hi Vincent, This is something that we have also been after for some time too, and I know

Re: ECMP/multipath support

2010-10-01 Thread Martin Mares
Hello! For us ECMP is important as we load balance connections to remote customer sites across different ISPs for redundancy and performance. When doing that, please keep in mind that whenever the characteristics (delay and throughput) of the lines are different, TCP congestion control