bird suddenly stops learning routes through bgp

2019-06-12 Thread Kurt Wauters
Hi, We're running BIRD 1.6.4 as a bgp routeserver but suddenly he stopped learning and advertising routes. All BGP sessions are established and prefixes are grouped in dedicated routing tables. Does anybody have an idea what the problem might be? We've got an interconnection with one of our

Re: [PATCH 2/3] Fix issue where cli socket buffer may get full

2019-06-12 Thread Ondrej Zajicek
On Wed, Jun 12, 2019 at 07:29:51AM +, Kenth Eriksson wrote: > > Also, better way to handle 1/3 is to add condition on line io.c line > > 2211, so that if we have full buffer, we do not try to check POLLIN, > > so that we do not even call sk_read() in such case instead of try it > > to handle

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-12 Thread Ondrej Zajicek
On Wed, Jun 12, 2019 at 11:08:36AM +, Kenth Eriksson wrote: > > Hi > > > > We could add this feature, but it should also report more cases > > (the submitted patch covers just first two): > > > > - progress > > - done > > - progress+queued > > - config timeout running > > > The first

Re: Kernel protocol and different namespaces

2019-06-12 Thread Jakub Nowacki
I'm in similar situation. Trying to run Bird on hardware that runs on top of kernel that doesn't support vrf. Not sure if I understand correctly. Not sure how using Linux sockets would allow you to achieve separation between different namespaces? You would still need at least different Bird

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-12 Thread Kenth Eriksson
On Tue, 2019-06-11 at 15:42 +0200, Ondrej Zajicek wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On Tue, Jun 11, 2019 at 02:58:33PM +0200, Kenth Eriksson

Re: Code style?

2019-06-12 Thread Kenth Eriksson
On Tue, 2019-06-11 at 16:15 +0200, Maria Jan Matejka wrote: > On 6/11/19 3:49 PM, Ondrej Zajicek wrote: > > On Tue, Jun 11, 2019 at 01:37:42PM +, Kenth Eriksson wrote: > >> Is there a code style guide to be used when submitting patches to > bird? > >> An emacs file, clang-format or similar

[PATCH] Don't include socket in pollset if read buffer is full

2019-06-12 Thread Kenth Eriksson
Don't set the POLLIN flag on a socket if the socket buffer is full. I.e. a socket with full read buffer is not included in the io loop for reading. Signed-off-by: Kenth Eriksson --- sysdep/unix/io.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sysdep/unix/io.c

Re: [PATCH 2/3] Fix issue where cli socket buffer may get full

2019-06-12 Thread Kenth Eriksson
On Tue, 2019-06-11 at 18:14 +0200, Ondrej Zajicek wrote: > On Tue, Jun 11, 2019 at 03:54:21PM +, Kenth Eriksson wrote: > > On Tue, 2019-06-11 at 17:03 +0200, Ondrej Zajicek wrote: > > > CAUTION: This email originated from outside of the organization. > > > Do > > > not click links or open