Re: [PATCH] Add CLI command to test reconfiguration status

2019-12-04 Thread Kenth Eriksson
On Mon, 2019-12-02 at 12:08 +0100, Ondrej Zajicek wrote: > > Thanks, please let me know when you have a proposed fix for this. > > Already fixed, sorry for not noticing you: > Thanks for the patch. Can confirm it resolves issue.

Re: [PATCH] Add CLI command to test reconfiguration status

2019-12-02 Thread Ondrej Zajicek
On Mon, Dec 02, 2019 at 07:30:27AM +, Kenth Eriksson wrote: > On Tue, 2019-11-26 at 15:59 +0100, Ondrej Zajicek wrote: > > > > > > I believe reply code issue is caused by the following lines since reply > > > code 3 is used twice... > > > > > > if (cd == c->last_reply) > > > size =

Re: [PATCH] Add CLI command to test reconfiguration status

2019-12-01 Thread Kenth Eriksson
On Tue, 2019-11-26 at 15:59 +0100, Ondrej Zajicek wrote: > > > > I believe reply code issue is caused by the following lines since reply > > code 3 is used twice... > > > > if (cd == c->last_reply) > > size = bsprintf(buf, " "); > > else > > size = bsprintf(buf, "%04d-", cd); > >

Re: [PATCH] Add CLI command to test reconfiguration status

2019-11-26 Thread Ondrej Zajicek
On Mon, Nov 25, 2019 at 04:26:45PM +, Kenth Eriksson wrote: > On Mon, 2019-11-25 at 16:02 +, Kenth Eriksson wrote: > > On Wed, 2019-06-12 at 17:26 +0200, Ondrej Zajicek wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or open

Re: [PATCH] Add CLI command to test reconfiguration status

2019-11-25 Thread Kenth Eriksson
On Mon, 2019-11-25 at 16:02 +, Kenth Eriksson wrote: > On Wed, 2019-06-12 at 17:26 +0200, Ondrej Zajicek wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you recognize the sender and know > > the content is safe. >

Re: [PATCH] Add CLI command to test reconfiguration status

2019-11-25 Thread Kenth Eriksson
On Wed, 2019-06-12 at 17:26 +0200, Ondrej Zajicek wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > Therefore, i just finished it [*]. Also, i did not use

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-14 Thread Ondrej Zajicek
On Thu, Jun 13, 2019 at 11:29:32AM +, Kenth Eriksson wrote: > The reply text for reply code 3 (CONF_DONE) is "Daemon is up and > running". Is that on purpose? I would have expected something like > "Re-configuration done" or similar. Yes, because the same message is reported after start,

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-13 Thread Kenth Eriksson
On Wed, 2019-06-12 at 17:26 +0200, Ondrej Zajicek wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On Wed, Jun 12, 2019 at 11:08:36AM +, Kenth Eriksson

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-12 Thread Ondrej Zajicek
On Wed, Jun 12, 2019 at 11:08:36AM +, Kenth Eriksson wrote: > > Hi > > > > We could add this feature, but it should also report more cases > > (the submitted patch covers just first two): > > > > - progress > > - done > > - progress+queued > > - config timeout running > > > The first

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-12 Thread Kenth Eriksson
On Tue, 2019-06-11 at 15:42 +0200, Ondrej Zajicek wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender > and know the content is safe. > > > On Tue, Jun 11, 2019 at 02:58:33PM +0200, Kenth Eriksson

Re: [PATCH] Add CLI command to test reconfiguration status

2019-06-11 Thread Ondrej Zajicek
On Tue, Jun 11, 2019 at 02:58:33PM +0200, Kenth Eriksson wrote: > This adds the CLI command 'configure status' so that it is possible to > check if reconfiguration is done. Hi We could add this feature, but it should also report more cases (the submitted patch covers just first two): -

[PATCH] Add CLI command to test reconfiguration status

2019-06-11 Thread Kenth Eriksson
This adds the CLI command 'configure status' so that it is possible to check if reconfiguration is done. Signed-off-by: Kenth Eriksson --- conf/conf.c | 6 ++ conf/conf.h | 1 + sysdep/unix/config.Y | 3 +++ sysdep/unix/main.c | 7 +++ sysdep/unix/unix.h | 1 + 5