Re: [blink-dev] Intent to Ship: Protected Audiences Negative Targeting

2024-01-03 Thread Mike Taylor
No concerns. LGTM2 On 1/3/24 1:41 PM, Chris Harrelson wrote: LGTM1 On Wed, Jan 3, 2024 at 5:05 AM Orr Bernstein wrote: Hi all, Thank you for your guidance here. I've updated the chromestatus entry to reflect the aforementioned delta, noting that the HTTP response header

Re: [blink-dev] Intent to Ship: Protected Audiences Negative Targeting

2024-01-03 Thread Chris Harrelson
LGTM1 On Wed, Jan 3, 2024 at 5:05 AM Orr Bernstein wrote: > Hi all, > > Thank you for your guidance here. I've updated the chromestatus entry to > reflect the aforementioned delta, noting that the HTTP response header > processing involved in this feature will work for both Fetch and iframe >

Re: [blink-dev] Intent to Ship: CSS custom state new :state() syntax

2024-01-03 Thread Mike Taylor
(but please remember to request reviews for the other review gates in chromestatus) On 1/3/24 1:10 PM, Mike Taylor wrote: LGTM2 On 1/3/24 12:54 PM, Chris Harrelson wrote: LGTM1 On Wed, Jan 3, 2024 at 9:44 AM Joey Arhar wrote: Contact emails jar...@chromium.org

Re: [blink-dev] Intent to Ship: CSS custom state new :state() syntax

2024-01-03 Thread Mike Taylor
LGTM2 On 1/3/24 12:54 PM, Chris Harrelson wrote: LGTM1 On Wed, Jan 3, 2024 at 9:44 AM Joey Arhar wrote: Contact emails jar...@chromium.org Explainer None Specification

Re: [blink-dev] Intent to Ship: CSS custom state new :state() syntax

2024-01-03 Thread Chris Harrelson
LGTM1 On Wed, Jan 3, 2024 at 9:44 AM Joey Arhar wrote: > Contact emailsjar...@chromium.org > > ExplainerNone > > Specification > https://html.spec.whatwg.org/multipage/custom-elements.html#custom-state-pseudo-class > > Summary > > This is the new syntax for the CSS custom state feature for

[blink-dev] Intent to Ship: CSS custom state new :state() syntax

2024-01-03 Thread Joey Arhar
Contact emailsjar...@chromium.org ExplainerNone Specification https://html.spec.whatwg.org/multipage/custom-elements.html#custom-state-pseudo-class Summary This is the new syntax for the CSS custom state feature for custom elements. The old syntax, :--foo, is being deprecated and removed. This

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread 'Nicolás Peña Moreno' via blink-dev
Hey Alex, You are right that they are only related in that they are extensions of the FedCM API. We bundled them up together in the same intent since we considered them small enough such that a single intent containing both is still manageable, and this reduces the burocratic overhead for

Re: [blink-dev] Intent to Ship: Set methods

2024-01-03 Thread Mike Taylor
It seems like Firefox hasn't actually shipped this yet (https://bugzilla.mozilla.org/show_bug.cgi?id=1868423), but LGTM3. On 1/3/24 11:52 AM, Alex Russell wrote: LGTM2 On Wednesday, January 3, 2024 at 8:49:57 AM UTC-8 Chris Harrelson wrote: LGTM1 On Tue, Jan 2, 2024 at 12:57 PM

Re: [blink-dev] Intent to Ship: Set methods

2024-01-03 Thread Alex Russell
LGTM2 On Wednesday, January 3, 2024 at 8:49:57 AM UTC-8 Chris Harrelson wrote: > LGTM1 > > On Tue, Jan 2, 2024 at 12:57 PM Rezvan Mahdavi Hezaveh < > rez...@chromium.org> wrote: > >> Hi Vladimir, >> >> Yes, that's right. Firefox and Safari shipping/shipped set methods. >> >> Bests, >> Rezvan >>

Re: [blink-dev] Intent to Ship: Set methods

2024-01-03 Thread Chris Harrelson
LGTM1 On Tue, Jan 2, 2024 at 12:57 PM Rezvan Mahdavi Hezaveh wrote: > Hi Vladimir, > > Yes, that's right. Firefox and Safari shipping/shipped set methods. > > Bests, > Rezvan > > On Tue, Jan 2, 2024 at 11:04 AM Vladimir Levin wrote: > >> >> >> On Tue, Jan 2, 2024 at 1:51 PM Rezvan Mahdavi

Re: [blink-dev] Intent to Prototype and Ship: MessagePort.onclose

2024-01-03 Thread Alex Russell
+1 to Yoav's excitement about this. Thank you for pushing it forward. On TAG review, we're living in hope that the newly-expanded TAG will have more bandwidth and focus for reviews, but as Mike says, we're increasingly timing out. Filing for review at I2P time is always the pro-move, and I

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Alex Russell
Hey Nicolas: Sorry for not fully understanding the impact of these features. A (very) quick read on my end suggests that they might not be related? Is there a code example or explainer that highlights why they belong in the same Intent? Thanks, Alex On Tuesday, January 2, 2024 at 8:42:38 AM

Re: [blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Chris Harrelson
LGTM2 On Wed, Jan 3, 2024 at 8:40 AM Mike Taylor wrote: > LGTM1 > On 1/2/24 11:42 AM, Nicolás Peña wrote: > > Brief update: both spec PRs are now merged. Hoping to ship in M122. > > On Friday, December 15, 2023 at 2:29:58 PM UTC-5 Nicolás Peña wrote: > >> Contact emails >> >> n...@chromium.org

Re: [blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Mike Taylor
LGTM1 On 1/2/24 11:42 AM, Nicolás Peña wrote: Brief update: both spec PRs are now merged. Hoping to ship in M122. On Friday, December 15, 2023 at 2:29:58 PM UTC-5 Nicolás Peña wrote: Contact emails n...@chromium.org Explainer Domain Hint (formerly hosted domain):

Re: [blink-dev] Intent to Ship: WebGL drawingBufferStorage

2024-01-03 Thread Alex Russell
LGTM3 On Wednesday, December 20, 2023 at 2:00:36 PM UTC-8 Chris Harrelson wrote: > LGTM2 > > On Wed, Dec 20, 2023 at 1:56 PM Mike Taylor > wrote: > >> Given that Kelsey gave you a private positive signal and the spec is >> merged, that works for me. >> >> LGTM1 to ship. >> On 12/20/23 4:44

Re: [blink-dev] Intent to Ship: Protected Audiences Negative Targeting

2024-01-03 Thread 'Orr Bernstein' via blink-dev
Hi all, Thank you for your guidance here. I've updated the chromestatus entry to reflect the aforementioned delta, noting that the HTTP response header processing involved in this feature will work for both Fetch and iframe navigations. Both the explainer