Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-06-13 Thread Debadree Chatterjee
reakage. >>> >>> On Tue, 13 Jun 2023 at 10:20 PhistucK wrote: >>> >>>> Does it work with an unmodified Chromium (from >>>> download-chromium.appspot.com for example)? >>>> If not, then it might just require non-free codecs, Widevine an

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-06-07 Thread Debadree Chatterjee
hello! I checked in safari technology preview pretty weird I dont observe the same breaking behaviour, I am trying to investigate why that is so! On Tuesday, June 6, 2023 at 8:49:22 PM UTC+5:30 Debadree Chatterjee wrote: > Thank you so much for finding out simon!! so then nuxt is probably

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-06-06 Thread Debadree Chatterjee
t; Both websites were made by the same agency (Akaru <https://akaru.fr/>), > so it could even be a homemade library or a single developer’s style ;) > > Hope it helps, > Simon > > Le lundi 5 juin 2023 à 17:07:47 UTC+2, Debadree Chatterjee a écrit : > >> Hey! >

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-06-05 Thread Debadree Chatterjee
hich video > should I expect to not load as a result of this change? I was expecting > something to be broken, and then I'd file a WebKit regression bug about it. > > As for whether to bake the changes into a single CL or to split it, I > don't have a strong opinion. > >

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-31 Thread Debadree Chatterjee
r, so we > can both revert and check the usage if we get reports of breakage. > > Best regards, > Philip > > On Tue, May 30, 2023 at 5:16 PM Debadree Chatterjee > wrote: > >> Hey Philip! >> >> Even I was surprised, turns out I was wrong about the delete fu

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-30 Thread Debadree Chatterjee
seems correct! Regards, Debadree On Wednesday, May 24, 2023 at 10:35:59 PM UTC+5:30 Debadree Chatterjee wrote: > Understood! > > I am going with the local testing approach for now, I think what I will do > is raise exceptions if a difference in behavior is noted as Philip > sugg

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-24 Thread Debadree Chatterjee
o get a sense for > the risk on this. If you're confident you've hit the code path on the sites > in question, and nothing at all changes for the user, then I think we > should try to ship this. > > On Mon, May 22, 2023 at 6:59 PM Debadree Chatterjee > wrote: > >

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-22 Thread Debadree Chatterjee
code path, if you > can't find anything at all breaking, then we should try to ship the change. > > On Fri, May 19, 2023 at 3:40 PM Debadree Chatterjee > wrote: > >> I tried navigating and clicking around the sites, but they didn't seem to >> be breaking at

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-19 Thread Debadree Chatterjee
I tried navigating and clicking around the sites, but they didn't seem to be breaking atleast even though this exception is being raised. Are there any more investigations I can do? On Friday, May 19, 2023 at 3:59:21 AM UTC+5:30 abot...@igalia.com wrote: > As for having a premonition that this

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-17 Thread Debadree Chatterjee
you change Chromium anyway, you can just add a log/CHECK or something > in the has/delete implementation itself, right? > > ☆*PhistucK* > > > On Wed, May 17, 2023 at 5:50 PM Debadree Chatterjee > wrote: > >> Is it possible to put these methods on Chrome startup? Like b

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-17 Thread Debadree Chatterjee
Is it possible to put these methods on Chrome startup? Like because loading the page would clear up devtools so in my local chromium if I could make these changes? any idea about which files would be relevant? On Wednesday, May 17, 2023 at 10:11:51 PM UTC+5:30 Debadree Chatterjee wrote: >

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-17 Thread Debadree Chatterjee
;>> straightforward way to do this would be a local change to Chromium, to make >>> the methods throw an exception if given and extra argument, and then >>> looking for the exception in devtools. >>> >>> Does that sound workable? If it's unreaso

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-17 Thread Debadree Chatterjee
x27;d expect for an argument that didn't do >>> anything before, so likely the value passed doesn't make sense and will >>> result in the parameter not being deleted for delete(), which could be a >>> problem. What can you say about usage in the wild here? >>

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-15 Thread Debadree Chatterjee
honestly higher usage than I'd expect for an argument that didn't do >> anything before, so likely the value passed doesn't make sense and will >> result in the parameter not being deleted for delete(), which could be a >> problem. What can you say about usage in the

Re: [blink-dev] Intent to Prototype: Add value argument to URLSearchParams's has() and delete()

2023-05-15 Thread Debadree Chatterjee
11, 2023 at 2:25 PM Debadree Chatterjee > wrote: > >> Contact emailsdebad...@gmail.com >> >> ExplainerNone >> >> Specificationhttps://url.spec.whatwg.org/#dom-urlsearchparams-has >> >> Summary >> This feature adds the ability to pass a `value

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-12 Thread Debadree Chatterjee
>> anything before, so likely the value passed doesn't make sense and will >> result in the parameter not being deleted for delete(), which could be a >> problem. What can you say about usage in the wild here? >> >> +Andreu Botella >> >> On Fri, May 12, 2

Re: [blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-12 Thread Debadree Chatterjee
#x27;s honestly higher usage than I'd expect for an argument that didn't do > anything before, so likely the value passed doesn't make sense and will > result in the parameter not being deleted for delete(), which could be a > problem. What can you say about usage in the w

[blink-dev] Re: Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-12 Thread Debadree Chatterjee
Given that the feature is pretty small it was recommended to me to directly take it to intent to ship stage Thank You! On Friday, May 12, 2023 at 1:00:08 PM UTC+5:30 Debadree Chatterjee wrote: > Contact emailsdebad...@gmail.com > > ExplainerNone > > Specificationhttps://url.

[blink-dev] Intent to Ship: Add value argument to URLSearchParams's has() and delete()

2023-05-12 Thread Debadree Chatterjee
Contact emails debadree...@gmail.com Explainer None Specification https://url.spec.whatwg.org/#dom-urlsearchparams-has Summary This feature adds the ability to pass a `value` argument to URLSearchParams's has() and delete() methods which allow for deleting tuples

[blink-dev] Intent to Prototype: Add value argument to URLSearchParams's has() and delete()

2023-05-11 Thread Debadree Chatterjee
Contact emails debadree...@gmail.com Explainer None Specification https://url.spec.whatwg.org/#dom-urlsearchparams-has Summary This feature adds the ability to pass a `value` argument to URLSearchParams's has() and delete() methods which allow for deleting tuples