Re: [blink-dev] Intent to Prototype: canvas placeElement()

2024-06-27 Thread Stephen Chenney
On Thu, Jun 27, 2024 at 12:26 PM Jeffrey Yasskin wrote: > On Wed, Jun 26, 2024 at 3:08 PM Aaron Krajeski > wrote: > >> Contact emails >> >> aaro...@chromium.org, fs...@chromium.org, khushalsa...@chromium.org >> >> Explainer >> >> placeElement technical paper [public] >>

[blink-dev] Intent to Ship: Stop modifying author-defined selection colors

2024-05-08 Thread Stephen Chenney
Contact emailsschen...@chromium.org ExplainerNone Specificationhttps://www.w3.org/TR/css-pseudo-4/#highlight-selectors SummaryChromium currently checks all selection highlight colors against the text color and inverts the highlight color if it matches the text. Hence, author-defined ::selection

[blink-dev] Web-Facing Change PSA: Stop modifying author-defined selection colors

2024-03-04 Thread Stephen Chenney
Contact emailsschen...@chromium.org Specificationhttps://www.w3.org/TR/css-pseudo-4/#selectordef-selection Summary Chromium currently checks all selection highlight colors against the text color and inverts the highlight color if it matches the text. Hence, author-defined ::selection CSS

Re: [blink-dev] Intent to Ship: Do not invert author selection background color when it matches text color

2024-02-22 Thread Stephen Chenney
It's been a while but it's time to revive this intent to respect author provided colors in ::selection rather than inverting the background when it matches the foreground. This makes chromium compatible with other engines. The CSS Working group resolved issue 6150

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-12-22 Thread Stephen Chenney
s. > > Do you think this will ever be shippable, even with a gutenberg update? I > would imagine old versions stick around for a very long time. > On 12/21/23 9:54 AM, Stephen Chenney wrote: > > Update: Due to breakage of the Wordpress editor, and a couple of other > sites, we plan t

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-12-21 Thread Stephen Chenney
g really clever). >> >> LGTM1 to ship. Good luck. :) >> On 11/3/23 12:19 PM, Stephen Chenney wrote: >> >> Note that I have moved the shipping milestone to M121, and have created a >> TAG review issue. >> >> On Thu, Nov 2, 2023 at 10:07 AM Stephen Chen

[blink-dev] Blink-rel try bots do not run unit tests

2023-12-01 Thread Stephen Chenney
I am surprised to discover that the various blink-rel try bots, say linux-blink-rel or win11-blink-rel, do not run blink_unittests or blink_platform_unittests or any other unit tests. Is this deliberate? I ask because I've been writing unit tests that depend on font metrics that differ across

Re: [blink-dev] Intent to Ship: CSS spelling and grammar features

2023-11-06 Thread Stephen Chenney
Thanks Mike. On Mon, Nov 6, 2023 at 10:22 AM Mike Taylor wrote: > Hi Stephen, > > Could you please request reviews for all the other review gates in your > chromestatus entry? > Yes, done. Sorry I overlooked that. > thanks, > Mike > > On 10/30/23 8:37 PM, Stephen

Re: [blink-dev] Intent to Ship: CSS spelling and grammar features

2023-11-03 Thread Stephen Chenney
On Wed, Nov 1, 2023 at 4:26 AM Yoav Weiss wrote: > > > On Tue, Oct 31, 2023 at 1:37 AM Stephen Chenney > wrote: > >> The CSS Spelling and Grammar feature has been active behind experimental >> web platform features since M89! There are no open bugs. I would li

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-03 Thread Stephen Chenney
Note that I have moved the shipping milestone to M121, and have created a TAG review issue. On Thu, Nov 2, 2023 at 10:07 AM Stephen Chenney wrote: > > > On Wed, Nov 1, 2023 at 11:11 AM Stephen Chenney > wrote: > >> Answers inline. Regarding Ander's comment on the

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-02 Thread Stephen Chenney
On Wed, Nov 1, 2023 at 11:11 AM Stephen Chenney wrote: > Answers inline. Regarding Ander's comment on the current base_feature > setting: I'll fix that. > > Cheers, > Stephen. > > On Wed, Nov 1, 2023 at 4:17 AM Yoav Weiss wrote: > >> >> >> On Tu

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Stephen Chenney
Answers inline. Regarding Ander's comment on the current base_feature setting: I'll fix that. Cheers, Stephen. On Wed, Nov 1, 2023 at 4:17 AM Yoav Weiss wrote: > > > On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney > wrote: > >> Contact emailsschen...@chromium.org >

[blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-10-31 Thread Stephen Chenney
Contact emailsschen...@chromium.org Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade Summary With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as ::selection and ::highlight, inherit their properties through the pseudo highlight chain, rather than the

[blink-dev] Intent to Ship: CSS spelling and grammar features

2023-10-30 Thread Stephen Chenney
The CSS Spelling and Grammar feature has been active behind experimental web platform features since M89! There are no open bugs. I would like to turn it on at last for M120. Contact emailsschen...@chromium.org, dazab...@igalia.com

Re: [blink-dev] Web-Facing Change PSA: CSS Highlight Inheritance

2023-10-30 Thread Stephen Chenney
it with a different title. On Mon, Oct 30, 2023 at 7:27 PM Chris Harrelson wrote: > Hi Stephen, > > Just checking: were you intending to send an intent-to-ship or a PSA? > > On Mon, Oct 30, 2023 at 2:17 PM Stephen Chenney > wrote: > >> Contact emailsschen...@chromium.o

[blink-dev] Web-Facing Change PSA: CSS Highlight Inheritance

2023-10-30 Thread Stephen Chenney
Contact emailsschen...@chromium.org Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade Summary With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as ::selection and ::highlight, inherit their properties through the pseudo highlight chain, rather than the

[blink-dev] Ready for Developer Testing: CSS Highlight Inheritance

2023-10-30 Thread Stephen Chenney
Contact emailsschen...@chromium.org Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade Summary With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as ::selection and ::highlight, inherit their properties through the pseudo highlight chain, rather than the

Re: [blink-dev] Intent to Remove: CSS property -webkit-highlight

2023-06-30 Thread Stephen Chenney
ample of those hits and found they were > all using this 3P library? > > LGTM1 > > > > On Thu, Jun 29, 2023 at 1:30 PM Stephen Chenney > wrote: > >> Contact emails schen...@chromium.org, spectran...@igalia.com >> >> Explainer None >> >> S

[blink-dev] Intent to Remove: CSS property -webkit-highlight

2023-06-29 Thread Stephen Chenney
Contact emailsschen...@chromium.org, spectran...@igalia.com ExplainerNone SpecificationNone Summary The CSS property -webkit-highlight is intended to highlight text, but was never standardized. It has no visible effect in chromium (it is parsed but never used in rendering content). The

Re: [blink-dev] Intent to remove: zoom CSS property

2023-04-20 Thread Stephen Chenney
Back to the testing question. There are hundreds of blink web tests that set zoom via CSS. Most of them are not testing the zoom CSS feature itself (though some are) so most of them would need to be updated to test browser zoom situations. It's tractable, particularly if we modify the existing

Re: [blink-dev] Intent to remove: zoom CSS property

2023-04-14 Thread Stephen Chenney
I seem to recall tests making use of CSS zoom. Is that not a concern? How do we write tests for issues that only manifest at particular browser zoom levels, because transform behaves differently than zoom (aka device scale factor)? Stephen. On Fri, Apr 14, 2023 at 8:14 PM Chris Harrelson wrote:

Re: [blink-dev] A quick survey on setting up fuzzy match rules to identify resolvable flaky web tests

2022-08-01 Thread Stephen Chenney
Thanks for investigating the potential for fuzzy matching. Rendering Core continues to oppose a single fuzzy match rule across all web_tests. We have some tests where single pixel differences matter (related to pixel snapping, for example) and a universal fuzzy match would fail to identify

Re: [blink-dev] Slow tests that timeouts

2021-08-19 Thread Stephen Chenney
ee some tests timed out at some abnormal value. For example > tests below timeouts at 22 second. Not sure how this could happen. > 19:13:50.493 20120 [3522/4178] > external/wpt/webrtc-identity/idlharness.https.window.html > failed unexpectedly (test timed out) 22.3300s > >

Re: [blink-dev] Slow tests that timeouts

2021-08-18 Thread Stephen Chenney
On Wed, Aug 18, 2021 at 12:01 PM 'Weizhong Xia' via blink-dev < blink-dev@chromium.org> wrote: > Dear blink-devs, > > As another effort trying to speed up blink_web_tests on CQ, We are looking > at slow tests that also timeouts. From the timing stats(example >