On Mon, Jun 3, 2024 at 2:29 AM Markus Handell wrote:
> You're welcome to file a bug in the mediarecorder - not sure I think the
> issue raised here is terribly important but I could support the
> implementation doing > instead of >= when it comes to duration.
>
I filed
WPT addition is covered under
https://github.com/web-platform-tests/wpt/issues/39642 and I haven't been
able to prioritize that yet.
I don't know what other vendors do. You're welcome to file a bug in the
mediarecorder - not sure I think the issue raised here is terribly
important but I could
0 is actually the one unambiguous case -- it clearly means you want a key
frame every frame.
Seems strange that someone whose steam has a key frame every 30 frames
should specify a count of 29. I dunno though, if that's also what other
vendors do then changing is far more trouble than benefit. Do
It was a while, but the discussions we had were not revolving around this
corner case.
I think it makes sense for the implementation to keep adhering to the
"exclusive of" to get rid of the ambiguity of what 0 means in Interval. I
also don't see another way to interpret the spec text.
For the
On Fri, May 31, 2024, 5:43 AM Markus Handell wrote:
> Hi Peter, from the spec text:
>
> "If videoKeyFrameIntervalCount is not null ... the video encoder produces
> a keyframe on the *first* frame arriving *after* *videoKeyFrameIntervalCount
> frames passed* *since* the last key frame"
>
> It
Hi Peter, from the spec text:
"If videoKeyFrameIntervalCount is not null ... the video encoder produces a
keyframe on the *first* frame arriving *after* *videoKeyFrameIntervalCount
frames passed* *since* the last key frame"
It sounds to me like the blink impl is correctly implementing the spec
On Thursday, May 30, 2024 at 9:32:50 AM UTC-7 Peter Kasting wrote:
The spec says that both the duration and frame count refer to the interval
"between key frames".
More spec text: "If videoKeyFrameIntervalCount is not null and
videoKeyFrameIntervalDuration is null, the video encoder produces
Sorry to necro this thread, but I came across the impl and had a quick
question about desired behavior, since it looks buggy to me.
The spec says that both the duration and frame count refer to the interval
"between key frames". The Blink implementation currently requests a key
frame if the
Thanks all!
On Sat, Apr 29, 2023 at 4:42 AM Yoav Weiss wrote:
> LGTM3
>
> On Fri, Apr 28, 2023 at 10:24 PM Chris Harrelson
> wrote:
>
>> LGTM2
>>
>> On Thu, Apr 27, 2023 at 7:02 AM Philip Jägenstedt
>> wrote:
>>
>>> Great, with https://github.com/w3c/mediacapture-record/issues/219 filed
>>>
LGTM3
On Fri, Apr 28, 2023 at 10:24 PM Chris Harrelson
wrote:
> LGTM2
>
> On Thu, Apr 27, 2023 at 7:02 AM Philip Jägenstedt
> wrote:
>
>> Great, with https://github.com/w3c/mediacapture-record/issues/219 filed
>> and the discussion you linked to, I don't think this needs to block.
>>
>> LGTM1
LGTM2
On Thu, Apr 27, 2023 at 7:02 AM Philip Jägenstedt
wrote:
> Great, with https://github.com/w3c/mediacapture-record/issues/219 filed
> and the discussion you linked to, I don't think this needs to block.
>
> LGTM1 to ship given a surface-level test in WPT as discussed.
>
> On Thu, Apr 27,
Great, with https://github.com/w3c/mediacapture-record/issues/219 filed and
the discussion you linked to, I don't think this needs to block.
LGTM1 to ship given a surface-level test in WPT as discussed.
On Thu, Apr 27, 2023 at 1:40 PM Markus Handell wrote:
> Yep this topic was discussed on
>
Yep this topic was discussed on
https://github.com/w3c/mediacapture-record/pull/216#discussion_r1159521616
and earlier. In the end I backed out of my proposed semantics due to
scepticism so the PR leaves it unspecified.
During the interim that hbos@ speaks to where the PR was merged, it was
On Thu, Apr 27, 2023 at 9:24 AM Markus Handell wrote:
>
>> Thanks for filing
>> https://github.com/web-platform-tests/wpt/issues/39642, I've asked
>> there for more details on what it would take to test this.
>>
>>
> I added some more detail there.
>
>
>> The spec change added two dictionary
>
>
> Thanks for filing
> https://github.com/web-platform-tests/wpt/issues/39642, I've asked
> there for more details on what it would take to test this.
>
>
I added some more detail there.
> The spec change added two dictionary members to
>
On Wed, Apr 26, 2023 at 5:36 PM Philip Jägenstedt
wrote:
> On Wed, Apr 26, 2023 at 12:42 PM Yoav Weiss
> wrote:
>
>>
>>
>> On Fri, Apr 21, 2023 at 6:48 PM 'Markus Handell' via blink-dev <
>> blink-dev@chromium.org> wrote:
>>
>>> Contact emails:
>>>
>>> hande...@google.com
>>>
>>> Explainer:
>>>
On Wed, Apr 26, 2023 at 12:42 PM Yoav Weiss wrote:
>
>
> On Fri, Apr 21, 2023 at 6:48 PM 'Markus Handell' via blink-dev <
> blink-dev@chromium.org> wrote:
>
>> Contact emails:
>>
>> hande...@google.com
>>
>> Explainer:
>>
>>-
>>
>>https://github.com/w3c/mediacapture-record/pull/216
>>
On Fri, Apr 21, 2023 at 6:48 PM 'Markus Handell' via blink-dev <
blink-dev@chromium.org> wrote:
> Contact emails:
>
> hande...@google.com
>
> Explainer:
>
>-
>
>https://github.com/w3c/mediacapture-record/pull/216
>-
>
>crbug.com/1371449
>
>
I think that a real explainer that
Contact emails:
hande...@google.com
Explainer:
-
https://github.com/w3c/mediacapture-record/pull/216
-
crbug.com/1371449
TAG review:
N/A, small incremental change
Summary:
The `MediaRecorder` spec was recently updated to allow users to configure
video keyframe generation
19 matches
Mail list logo
