Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

I see, is it because the exact behavior of text-wrap:balance and text-wrap:pretty are up to implementations? Since this is likely to remain the case indefinitely I think calling the test tentative isn't quite right, I'm not sure if the spec say "may" or "optional", but in spirit I think optional

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

LGTM3. It might be worth manually testing popular Japanese sites that use ruby to make sure this doesn't cause issues. But, I think it would be hard for sites to depend on specific line breaking behavior in a way that could cause breakage. On Tue, Jun 4, 2024 at 3:53 PM Daniel Bratell wrote: >

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

LGTM2 /Daniel On 2024-06-04 04:16, TAMURA, Kent wrote: The test "text-wrap.tentative.html" is tentative because of text-wrap:balance and text-wrap:pretty.  I'll do: - File a spec issue for them, and - Make a non-tetative test for text-wrap:nowrap. On Mon, Jun 3, 2024 at 5:57 PM Philip Jägens

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

Sure. I'll make a DumpAccessibilityTreeTest with a line-broken . On Mon, Jun 3, 2024 at 11:00 PM Aaron Leventhal wrote: > We do some interesting reorganization of ruby content in the a11y tree. > Can we create some DumpAccessibilityTreeTest tests for this and I'll take > a look at the a11y tree

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

The test "text-wrap.tentative.html" is tentative because of text-wrap:balance and text-wrap:pretty. I'll do: - File a spec issue for them, and - Make a non-tetative test for text-wrap:nowrap. On Mon, Jun 3, 2024 at 5:57 PM Philip Jägenstedt wrote: > LGTM1 > > This is a change of default behavi

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

We do some interesting reorganization of ruby content in the a11y tree. Can we create some DumpAccessibilityTreeTest tests for this and I'll take a look at the a11y tree and make sure it's sensible. On Fri, May 31, 2024 at 4:49 AM TAMURA, Kent wrote: > Contact emailstk...@chromium.org > > Explai

Re: [blink-dev] Intent to Implement and Ship: Line-breakable ruby

LGTM1 This is a change of default behavior, but the previous behavior is likely very rare and it can be achieved using `text-wrap: nowrap`. Since the text-wrap part is important for adoption of this, can you check if text-wrap.tentative.html still needs to be tentative? The test has a comment abo

[blink-dev] Intent to Implement and Ship: Line-breakable ruby

Contact emailstk...@chromium.org Explainer https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY2SHQHj3Np4sDo/edit?pli=1#heading=h.acpilydj9j1d Specificationhttps://drafts.csswg.org/css-ruby/#break-within Design docs https://docs.google.com/document/d/1hzvrwoE_0aw08X_CaU40zV5bXbMQjY