Re: [blink-dev] Intent to Ship: Array grouping

2023-07-11 Thread Daniel Bratell
LGTM3 /Daniel On 2023-07-12 06:52, Yoav Weiss wrote: LGTM2 On Wed, Jul 12, 2023, 03:27 Mike Taylor wrote: LGTM1 On 7/11/23 1:33 PM, Shu-yu Guo wrote: Contact emails s...@chromium.org Explainer https://github.com/tc39/proposal-array-grouping/blo

Re: [blink-dev] Intent to Ship: Array grouping

2023-07-11 Thread Yoav Weiss
LGTM2 On Wed, Jul 12, 2023, 03:27 Mike Taylor wrote: > LGTM1 > On 7/11/23 1:33 PM, Shu-yu Guo wrote: > > Contact emails > s...@chromium.org > > Explainer > https://github.com/tc39/proposal-array-grouping/blob/main/README.md > > Specification https://tc39.es/proposal-array-grouping/ > > Summary >

Re: [blink-dev] Intent to Ship: Array grouping

2023-07-11 Thread Mike Taylor
LGTM1 On 7/11/23 1:33 PM, Shu-yu Guo wrote: Contact emails s...@chromium.org Explainer https://github.com/tc39/proposal-array-grouping/blob/main/README.md Specification https://tc39.es/proposal-array-grouping/ Summary Adds news Object.groupBy(iterable,

[blink-dev] Intent to Ship: Array grouping

2023-07-11 Thread Shu-yu Guo
Contact emails s...@chromium.org Explainerhttps://github.com/tc39/proposal-array-grouping/blob/main/README.md Specificationhttps://tc39.es/proposal-array-grouping/ Summary Adds news Object.groupBy(iterable, groupCallback) and Map.groupBy(iterable, groupCallback) to perform a grouping or bucketi

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-21 Thread Philip Jägenstedt
On Wed, Sep 21, 2022 at 6:20 PM Shu-yu Guo wrote: > On Wed, Sep 21, 2022 at 8:53 AM Philip Jägenstedt > wrote: > >> I assume that like most JS features this isn't tested in WPT but rather >> in Test262. Are the tests for this in Test262 all passing? >> > > Correct, it is tested via test262. I've

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-21 Thread Shu-yu Guo
On Wed, Sep 21, 2022 at 8:53 AM Philip Jägenstedt wrote: > I assume that like most JS features this isn't tested in WPT but rather in > Test262. Are the tests for this in Test262 all passing? > Correct, it is tested via test262. I've been checking that box assuming that it's a stand-in for test2

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-21 Thread Philip Jägenstedt
I assume that like most JS features this isn't tested in WPT but rather in Test262. Are the tests for this in Test262 all passing? On Wed, Sep 21, 2022 at 12:47 PM Daniel Bratell wrote: > LGTM2 to ship group and groupToMap (a bit confusing that the summary uses > the old names). > > /Daniel > On

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-21 Thread Chris Harrelson
LGTM3 On Wed, Sep 21, 2022 at 3:47 AM Daniel Bratell wrote: > LGTM2 to ship group and groupToMap (a bit confusing that the summary uses > the old names). > > /Daniel > On 2022-09-21 06:55, Yoav Weiss wrote: > > LGTM1 > > On Wed, Sep 21, 2022 at 2:30 AM Shu-yu Guo wrote: > >> Contact emails s...

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-21 Thread Daniel Bratell
LGTM2 to ship group and groupToMap (a bit confusing that the summary uses the old names). /Daniel On 2022-09-21 06:55, Yoav Weiss wrote: LGTM1 On Wed, Sep 21, 2022 at 2:30 AM Shu-yu Guo wrote: Contact emails s...@chromium.org Explainer https://github.com

Re: [blink-dev] Intent to Ship: Array grouping

2022-09-20 Thread Yoav Weiss
LGTM1 On Wed, Sep 21, 2022 at 2:30 AM Shu-yu Guo wrote: > Contact emails...@chromium.org > > Explainer > https://github.com/tc39/proposal-array-grouping/blob/main/README.md > > Specificationhttps://tc39.es/proposal-array-grouping/ > > Summary > > Adds news Array.prototype methods groupBy() and g

[blink-dev] Intent to Ship: Array grouping

2022-09-20 Thread Shu-yu Guo
Contact emails...@chromium.org Explainerhttps://github.com/tc39/proposal-array-grouping/blob/main/README.md Specificationhttps://tc39.es/proposal-array-grouping/ Summary Adds news Array.prototype methods groupBy() and groupByToMap() to perform a grouping or bucketing operation. Blink componen