Re: [blink-dev] Intent to Ship: Array.fromAsync

LGTM3 On Thu, Oct 26, 2023 at 4:04 PM Johnny Stenback wrote: > +1 to what Chris said. And if you feel a gate doesn't apply, you can state > in a comment that you believe the result of the review should be n/a. And > we're in fact in the midst of landing a short-hand button that does that > for a

Re: [blink-dev] Intent to Ship: Array.fromAsync

+1 to what Chris said. And if you feel a gate doesn't apply, you can state in a comment that you believe the result of the review should be n/a. And we're in fact in the midst of landing a short-hand button that does that for all approval gate chips. Cheers, Johnny On Thu, Oct 26, 2023 at 8:21 AM

Re: [blink-dev] Intent to Ship: Array.fromAsync

On Wed, Oct 25, 2023 at 5:05 PM Shu-yu Guo wrote: > Those gates are not applicable for most TC39 stage 3 features, including > this one. Are you asking them to be marked as such or that we requested > reviews for it? > I think they are. TC39 stage 3 features can skip a TAG review and signals, bu

Re: [blink-dev] Intent to Ship: Array.fromAsync

LGTM2 % administrative shenanigans regarding the review gates On Thu, Oct 26, 2023 at 2:16 AM Mike Taylor wrote: > Sorry, we're still learning this new chromestatus process (and a similar > concern came up in our API OWNERs meeting earlier today). My understanding > is that we should have _somet

Re: [blink-dev] Intent to Ship: Array.fromAsync

Sorry, we're still learning this new chromestatus process (and a similar concern came up in our API OWNERs meeting earlier today). My understanding is that we should have _something_ in there, so perhaps the right thing to do is to request the reviews stating that these are normally N/A for TC3

Re: [blink-dev] Intent to Ship: Array.fromAsync

Those gates are not applicable for most TC39 stage 3 features, including this one. Are you asking them to be marked as such or that we requested reviews for it? On Wed, Oct 25, 2023 at 4:00 PM Mike Taylor wrote: > Oops... sent too early. Can you also please request reviews for the rest > of the

Re: [blink-dev] Intent to Ship: Array.fromAsync

Oops... sent too early. Can you also please request reviews for the rest of the review gates in the chromestatus entry? On 10/25/23 6:57 PM, Mike Taylor wrote: LGTM1. It's encouraging that Firefox Nightly ship

Re: [blink-dev] Intent to Ship: Array.fromAsync

LGTM1. It's encouraging that Firefox Nightly shipped this a few months back with no reported regressions thus far. On 10/25/23 6:39 PM, Rezvan Mahdavi Hezaveh wrote: Contact emails s...@chromium.org, rez...@chromium.org

[blink-dev] Intent to Ship: Array.fromAsync

Contact emails...@chromium.org, rez...@chromium.org Explainerhttps://github.com/tc39/proposal-array-from-async Specificationhttps://tc39.es/proposal-array-from-async Summary Array.fromAsync is the async version of Array.from. It takes async iterables, iterates them, and collects the results int