Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-10-15 Thread Joey Arhar
> Though I notice that there were some good comments about documentation in the TAG thread and that documentation should be added before this reaches stable (the sooner the better). As per the TAG thread, I have opened a PR to add a non-normative note about this to the HTML spec:

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-10-14 Thread Daniel Bratell
Though I notice that there were some good comments about documentation in the TAG thread and that documentation should be added before this reaches stable (the sooner the better). /Daniel On 2021-10-14 21:02, Daniel Bratell wrote: LGTM3 /Daniel On 2021-10-07 21:07, Mike West wrote:

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-10-14 Thread Daniel Bratell
LGTM3 /Daniel On 2021-10-07 21:07, Mike West wrote: LGTM2. Please do follow up on any feedback you obtain from the TAG, since I believe the review request there is still outstanding. It doesn't appear to me that there are substantial design questions that are still open, but if something

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-10-07 Thread Mike West
LGTM2. Please do follow up on any feedback you obtain from the TAG, since I believe the review request there is still outstanding. It doesn't appear to me that there are substantial design questions that are still open, but if something interesting is raised, we should respond to it expediently.

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-10-01 Thread Balazs Engedy
Thank you for the detailed differential threat analysis, SGTM from the permissions side. Glad to see the ongoing work on robust and comprehensive mitigations. On Friday, October 1, 2021 at 1:41:54 AM UTC+2 Joey Arhar wrote: > > in anticipation of a future world where the preexisting vectors of

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-30 Thread Joey Arhar
> in anticipation of a future world where the preexisting vectors of snooping have been mitigated I am planning on adding a delay to find-in-page in order to mitigate find-in-page snooping which would work with this feature, beforematch, and the existing scroll events:

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-30 Thread Balazs Engedy
For the `beforeMatch` event we requested that if the website does not reveal `hidden-matchable` content in response to this event, sending the event be stopped for the reminder of the lifetime of the page. This was to prevent adding new ways of snooping on what the user types in the

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-23 Thread Mike Taylor
On 9/23/21 8:19 AM, Yoav Weiss wrote: On Thu, Sep 23, 2021 at 9:25 AM Thomas Steiner > wrote: Not sure this was discussed before, but could a new boolean attribute that opts the element in to the new behavior be the answer? At the risk of jinxing

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-23 Thread Yoav Weiss
LGTM1 On Thu, Sep 23, 2021 at 12:03 AM PhistucK wrote: > Not sure I completely agree, so, not so "right". :) > Using / for "accordions" is kind of the prescribed way > to do this. I do not think encouraging other, maybe less accessible, > semantic or simple ways is so "right". > And this is

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-23 Thread Yoav Weiss
On Thu, Sep 23, 2021 at 9:25 AM Thomas Steiner wrote: > Not sure this was discussed before, but could a new boolean attribute that > opts the element in to the new behavior be the answer? > > > It seems like an opt-in would significantly diminish the user value of this feature, for all

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-23 Thread 'Thomas Steiner' via blink-dev
Not sure this was discussed before, but could a new boolean attribute that opts the element in to the new behavior be the answer? -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it,

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-22 Thread PhistucK
Not sure I completely agree, so, not so "right". :) Using / for "accordions" is kind of the prescribed way to do this. I do not think encouraging other, maybe less accessible, semantic or simple ways is so "right". And this is breaking/changing an existing behaviour. You would not say this ("they

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-22 Thread Joey Arhar
> I imagine it could break a little some pages that hide the answer to a question (in a quiz type of thing) via this element... If a site doesn't like this behavior, they could just not use the details element, right? There are plenty of other ways to implement an accordion like this. I think

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-18 Thread PhistucK
I imagine it could break a little some pages that hide the answer to a question (in a quiz type of thing) via this element... ☆*PhistucK* On Sat, Sep 18, 2021 at 6:55 PM Joey Arhar wrote: > > Will there be an opt out (without resorting to using other elements)? > > No, there is no plan to add

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-18 Thread Joey Arhar
> Will there be an opt out (without resorting to using other elements)? No, there is no plan to add an opt-out for this feature. On Sat, Sep 18, 2021 at 10:54 AM PhistucK wrote: > Will there be an opt out (without resorting to using other elements)? > > ☆*PhistucK* > > > On Fri, Sep 17, 2021

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-18 Thread PhistucK
Will there be an opt out (without resorting to using other elements)? ☆*PhistucK* On Fri, Sep 17, 2021 at 4:55 PM Joey Arhar wrote: > > I think it's fair to say "positive", given the like and retweet signals > on https://twitter.com/tomayac/status/1403119516922662913 and >

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-17 Thread Joey Arhar
> I think it's fair to say "positive", given the like and retweet signals on https://twitter.com/tomayac/status/1403119516922662913 and https://twitter.com/tomayac/status/1293696281370669057 where this behavior is described. Thanks Thomas! > Do I understand correctly and developers don't need to

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-17 Thread Yoav Weiss
On Fri, Sep 17, 2021 at 8:41 AM 'Thomas Steiner' via blink-dev < blink-dev@chromium.org> wrote: > > > On Fri, Sep 17, 2021 at 3:56 AM Joey Arhar wrote: > >> Contact emailsjar...@chromium.org >> >> Explainer >>

Re: [blink-dev] Intent to Ship: Auto-expand details elements

2021-09-17 Thread 'Thomas Steiner' via blink-dev
On Fri, Sep 17, 2021 at 3:56 AM Joey Arhar wrote: > Contact emailsjar...@chromium.org > > Explainer > https://github.com/WICG/display-locking/blob/main/explainers/auto-expanding-details-explainer.md > > Specificationhttps://github.com/whatwg/html/pull/6466 > > Design docs >

[blink-dev] Intent to Ship: Auto-expand details elements

2021-09-16 Thread Joey Arhar
Contact emailsjar...@chromium.org Explainer https://github.com/WICG/display-locking/blob/main/explainers/auto-expanding-details-explainer.md Specificationhttps://github.com/whatwg/html/pull/6466 Design docs