Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-12-22 Thread Stephen Chenney
I think we will be able to ship it eventually, and there is active work to get cross-browser compat too. For older browsers I believe there is a simple addition to the CSS for sites that will render the feature moot in most cases, though I am waiting on a site to try it and verify. Interestingly,

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-12-21 Thread Mike Taylor
Thanks for the update. I might have jinxed it when I said "breakage in this case would just be cosmetic (unless someone is doing something really clever)"... I hadn't considered editor use cases. Do you think this will ever be shippable, even with a gutenberg update? I would imagine old

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-12-21 Thread Stephen Chenney
Update: Due to breakage of the Wordpress editor, and a couple of other sites, we plan to delay the Stable ship milestone to 122. I'll update the status entry etc. Stephen. On Wed, Nov 8, 2023 at 10:34 AM Yoav Weiss wrote: > LGTM3 > > On Wednesday, November 8, 2023 at 4:18:59 PM UTC+1 Daniel

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-08 Thread Yoav Weiss
LGTM3 On Wednesday, November 8, 2023 at 4:18:59 PM UTC+1 Daniel Bratell wrote: > LGTM2 > > You may want to ping the Mozilla standards position issue and let them > know that we are close to shipping. It looks like they forgotten it. > > /Daniel > On 2023-11-06 16:43, Mike Taylor wrote: > >

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-08 Thread Daniel Bratell
LGTM2 You may want to ping the Mozilla standards position issue and let them know that we are close to shipping. It looks like they forgotten it. /Daniel On 2023-11-06 16:43, Mike Taylor wrote: Thanks for the detailed explanation of compat and for filing a TAG review. The risk of breakage

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-06 Thread Mike Taylor
Thanks for the detailed explanation of compat and for filing a TAG review. The risk of breakage seems low (and I suppose we'll learn how true that is as the change rides the trains), and breakage in this case would just be cosmetic (unless someone is doing something really clever). LGTM1 to

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-03 Thread Stephen Chenney
Note that I have moved the shipping milestone to M121, and have created a TAG review issue. On Thu, Nov 2, 2023 at 10:07 AM Stephen Chenney wrote: > > > On Wed, Nov 1, 2023 at 11:11 AM Stephen Chenney > wrote: > >> Answers inline. Regarding Ander's comment on the current base_feature >>

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-02 Thread Stephen Chenney
On Wed, Nov 1, 2023 at 11:11 AM Stephen Chenney wrote: > Answers inline. Regarding Ander's comment on the current base_feature > setting: I'll fix that. > > Cheers, > Stephen. > > On Wed, Nov 1, 2023 at 4:17 AM Yoav Weiss wrote: > >> >> >> On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney >>

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Stephen Chenney
Answers inline. Regarding Ander's comment on the current base_feature setting: I'll fix that. Cheers, Stephen. On Wed, Nov 1, 2023 at 4:17 AM Yoav Weiss wrote: > > > On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney > wrote: > >> Contact emailsschen...@chromium.org >> >>

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Anders Hartvoll Ruud
On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney wrote: > Contact emailsschen...@chromium.org > > Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade > > Summary > > With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as > ::selection and ::highlight, inherit

Re: [blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-11-01 Thread Yoav Weiss
On Tue, Oct 31, 2023 at 1:45 PM Stephen Chenney wrote: > Contact emailsschen...@chromium.org > > Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade > > Summary > > With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as > ::selection and ::highlight, inherit

[blink-dev] Intent to Ship: CSS Highlight Inheritance

2023-10-31 Thread Stephen Chenney
Contact emailsschen...@chromium.org Specificationhttps://drafts.csswg.org/css-pseudo-4/#highlight-cascade Summary With CSS Highlight Inheritance, the CSS Highlight pseudo classes, such as ::selection and ::highlight, inherit their properties through the pseudo highlight chain, rather than the