Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-11 Thread Philip Jägenstedt
Thanks for confirming, Munira! Sounds like this is pretty well tested, and Chrome will pass almost all of the tests. Regarding small-caps, the tables on MDN can definitely be wrong, I've sent https://github.com/mdn/browser-compat-data/pull/12782 to fix the Safari support here. Finally, if

Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-07 Thread Chris Harrelson
LGTM3 On Thu, Oct 7, 2021 at 3:34 AM 'Munira Tursunova' via blink-dev < blink-dev@chromium.org> wrote: > > Looking at the font-synthesis-* tests in > https://wpt.fyi/results/css/css-fonts?label=experimental=master, > many pass in Firefox and Safari, but not all of them. Do all of these tests >

Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-07 Thread 'Munira Tursunova' via blink-dev
> Looking at the font-synthesis-* tests in https://wpt.fyi/results/css/css-fonts?label=experimental=master, many pass in Firefox and Safari, but not all of them. Do all of these tests pass with the implementation now in Blink? Yes, they do. Actually these tests had been added with the Chrome

Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-07 Thread Philip Jägenstedt
It's great to see this feature getting ready to ship, it's one of a relatively small number of features already supported by Firefox and Safari but not by Chromium browsers, so it's been on my radar :) I just have a few questions. Looking at the font-synthesis-* tests in

Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-07 Thread Daniel Bratell
LGTM2 /Daniel On 2021-10-07 09:08, Yoav Weiss wrote: *LGTM1* Thanks for working on this!! This seems like an important thing to catch up on! On Tue, Oct 5, 2021 at 6:56 PM 'Munira Tursunova' via blink-dev wrote: Contact emails moon...@google.com, dr...@chromium.org

Re: [blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-07 Thread Yoav Weiss
*LGTM1* Thanks for working on this!! This seems like an important thing to catch up on! On Tue, Oct 5, 2021 at 6:56 PM 'Munira Tursunova' via blink-dev < blink-dev@chromium.org> wrote: > Contact emails > > moon...@google.com, dr...@chromium.org > > Explainer > >

[blink-dev] Intent to Ship: CSS font-synthesis property

2021-10-05 Thread 'Munira Tursunova' via blink-dev
Contact emails moon...@google.com, dr...@chromium.org Explainer https://drafts.csswg.org/css-fonts-4/#font-synthesis-intro https://developer.mozilla.org/en-US/docs/Web/CSS/font-synthesis Specification https://drafts.csswg.org/css-fonts/#font-synthesis Summary The font-synthesis CSS