Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-16 Thread Mike Taylor
LGTM3 On 2/16/24 6:21 AM, Manuel Rego Casasnovas wrote: Thanks for adding the test. LGTM2. Cheers,   Rego On 14/02/2024 13:15, 'François Beaufort' via blink-dev wrote: On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas mailto:r...@igalia.com>> wrote:     On 14/02/2024 10:46,

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-16 Thread Manuel Rego Casasnovas
Thanks for adding the test. LGTM2. Cheers, Rego On 14/02/2024 13:15, 'François Beaufort' via blink-dev wrote: On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas > wrote: On 14/02/2024 10:46, François Beaufort wrote: > > > On Wed, Feb 14,

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 10:48 AM Manuel Rego Casasnovas wrote: > > > On 14/02/2024 10:46, François Beaufort wrote: > > > > > > On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas > > wrote: > > > > Hi, > > > > On 13/02/2024 11:13, 'François Beaufort' via

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
On 14/02/2024 10:46, François Beaufort wrote: On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas > wrote: Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > >         Is this feature fully tested by web-platform-tests >

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 10:43 AM Manuel Rego Casasnovas wrote: > Hi, > > On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: > > > > Is this feature fully tested by web-platform-tests > > < >

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Manuel Rego Casasnovas
Hi, On 13/02/2024 11:13, 'François Beaufort' via blink-dev wrote: Is this feature fully tested by web-platform-tests ? Yes https://wpt.fyi/results/css/mediaqueries/display-mode.html

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread 'François Beaufort' via blink-dev
On Wed, Feb 14, 2024 at 9:36 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > This seems like a small and useful extension to Document > picture-in-picture. > > On Tue, Feb 13, 2024 at 11:13 AM 'François Beaufort' via blink-dev < > blink-dev@chromium.org> wrote: > >> Contact

Re: [blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM1 This seems like a small and useful extension to Document picture-in-picture. On Tue, Feb 13, 2024 at 11:13 AM 'François Beaufort' via blink-dev < blink-dev@chromium.org> wrote: > Contact emailsfbeauf...@google.com > > ExplainerNone > > Specification >

[blink-dev] Intent to Ship: CSS picture-in-picture display mode

2024-02-13 Thread 'François Beaufort' via blink-dev
Contact emailsfbeauf...@google.com ExplainerNone Specification https://drafts.csswg.org/mediaqueries-5/#display-mode-picture-in-picture https://github.com/w3c/csswg-drafts/issues/9260 Summary Adds support to the CSS display-mode media feature for picture-in-picture. This allows web developers