Re: [blink-dev] Intent to Ship: MSE in Workers

Relaunch landed and is in Chrome >= 108.0.5334.0. Huh! Might be worthwhile to file an issue on the TAG's design principles to >> warn against making getters throw exceptions or have any other side effects >> for that matter. >> > > Indeed, I am tracking this as a potential follow-up and will updat

Re: [blink-dev] Intent to Ship: MSE in Workers

Thank you for the relaunch approvals. Once the relaunch CL is fully reviewed, I'll land it. > Huh! Might be worthwhile to file an issue on the TAG's design principles > to warn against making getters throw exceptions or have any other side > effects for that matter. > Indeed, I am tracking this

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM3 On Thu, Sep 29, 2022 at 3:07 PM Mike Taylor wrote: > LGTM2 > > On 9/29/22 12:14 AM, Yoav Weiss wrote: > > LGTM1 to relaunch > > This looks perfectly reasonable. Thanks for doing everything necessary to > minimize the damage through what I'm guessing wasn't what one may call a > "fun experi

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM2 On 9/29/22 12:14 AM, Yoav Weiss wrote: LGTM1 to relaunch This looks perfectly reasonable. Thanks for doing everything necessary to minimize the damage through what I'm guessing wasn't what one may call a "fun experience". On Wed, Sep 28, 2022 at 9:51 PM Matthew Wolenetz wrote:

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM1 to relaunch This looks perfectly reasonable. Thanks for doing everything necessary to minimize the damage through what I'm guessing wasn't what one may call a "fun experience". On Wed, Sep 28, 2022 at 9:51 PM Matthew Wolenetz wrote: > Regarding the scope of the fix involved in this relaun

Re: [blink-dev] Intent to Ship: MSE in Workers

Regarding the scope of the fix involved in this relaunch, it removes visibility of the new handle attribute from the main/Window context (and updates test expectations, accordingly.) While that change alone would fix the regression, it risks potential for unexpected exception in future if that attr

Re: [blink-dev] Intent to Ship: MSE in Workers

Per previous LGTMs on this, the feature launched in M105: https://chromium-review.googlesource.com/c/chromium/src/+/3795560 Unfortunately, both the MSE spec and Chromium implementation for this feature included logic which regressed some media playback sites, and the regression was found late after

Re: [blink-dev] Intent to Ship: MSE in Workers

Gang, NOTE: Requested desktop and Android ship milestone: 105 (The 'edit > estimated milestones' link from chromestatus didn't result in such ability > to edit, so I'm adding this request explicitly here.) I'm looking into this and will report back. Has anyone else noticed this problem? Joe Joe

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM3 On 8/1/22 8:05 AM, Yoav Weiss wrote: LGTM2 On Fri, Jul 29, 2022 at 12:40 AM slightlyoff via Chromestatus > wrote: LGTM1 -- You received this message because you are subscribed to the Google Groups "blink-dev" group

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM2 On Fri, Jul 29, 2022 at 12:40 AM slightlyoff via Chromestatus < admin+slightly...@cr-status.appspotmail.com> wrote: > LGTM1 > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from

Re: [blink-dev] Intent to Ship: MSE in Workers

LGTM1 -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chro

[blink-dev] Intent to Ship: MSE in Workers

Contact emailswolen...@chromium.org Explainer https://github.com/wicg/media-source/blob/mse-in-workers-using-handle/mse-in-workers-using-handle-explainer.md Specificationhttps://www.w3.org/TR/media-source-2 Design docs https://github.com/wicg/media-source/blob/mse-in-workers-using-handle/mse-in-