Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-23 Thread TAMURA, Kent
We decided not to ship `ruby-base` at this time due to an interoperability concern. We'll reconsider it while looking at the status of WebKit. On Thu, Nov 2, 2023 at 9:11 AM TAMURA, Kent wrote: > > > On Thu, Nov 2, 2023 at 12:53 AM Rick Byers wrote: > >> Hey Kent, >> To Fantasai's point, can y

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread TAMURA, Kent
On Thu, Nov 2, 2023 at 12:53 AM Rick Byers wrote: > Hey Kent, > To Fantasai's point, can you point to the specific WPT test cases for this > intent? Are Chrome or Firefox failing any, and if so can you explain why? > > Tentative LGTM2 assuming WPT coverage shows we're matching Firefox > behavior.

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread Daniel Bratell
LGTM3 but attend to Rick's comment below before shipping. (Fantasia/Kent: It should be possible to test the implementation using the flags the WPT bots use to test so I assume Fantasia can test it with an appropriate flag and new enough build? chrome://flags/#enable-experimental-web-platform-f

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-11-01 Thread Rick Byers
Hey Kent, To Fantasai's point, can you point to the specific WPT test cases for this intent? Are Chrome or Firefox failing any, and if so can you explain why? Tentative LGTM2 assuming WPT coverage shows we're matching Firefox behavior. Also happy to discuss the nuance here first if it's not comple

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-30 Thread fantasai
On 10/19/23 22:39, TAMURA, Kent wrote: fantasai wrote: > It seems you're listing a subset of values, which makes me wonder what > differences you would be introducing between Blink's behavior and the > behavior described in the specs (if any)? I think the new behavior will be a subset of CSS ru

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-24 Thread TAMURA, Kent
On Fri, Oct 20, 2023 at 11:39 AM TAMURA, Kent wrote: > > > On Fri, Oct 20, 2023 at 4:42 AM fantasai > wrote: > >> On 10/19/23 03:41, TAMURA, Kent wrote: >> > >> > Specification >> > >> > https://drafts.csswg.org/css-ruby-1/#ruby-display >> > >> > Summary >> > >> > New CSS display

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-22 Thread TAMURA, Kent
I found the HTML specification already had the following: https://html.spec.whatwg.org/C/#phrasing-content-3 ruby { display: ruby; } rt { display: ruby-text; } I think what we should do is to remove algorithms at https://html.spec.whatwg.org/C/#the-ruby-element:the-ruby-element-19 . On Fri, Oc

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread TAMURA, Kent
On Fri, Oct 20, 2023 at 4:42 AM fantasai wrote: > On 10/19/23 03:41, TAMURA, Kent wrote: > > > > Specification > > > > https://drafts.csswg.org/css-ruby-1/#ruby-display > > > > Summary > > > > New CSS displayproperty values, "ruby", "ruby-base", and "ruby-text", > are > > added. T

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread TAMURA, Kent
Oh, I made a mistake! This intent should drop the part of and 'ruby-base'. I don't intend to introduce the "ruby + rb + rt" model. I'd like to change the current "ruby + rt" model to "display:ruby + display:ruby-text". Sorry for the confusion! Anyway I should make a PR for the HTML specificati

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread Domenic Denicola
On Thu, Oct 19, 2023 at 11:33 PM Jeffrey Yasskin wrote: > My reading of #1771 is that the only thing keeping out of HTML is the > lack of a Blink or WebKit implementation. It looks like > https://github.com/whatwg/html/pull/6478 is already written to improve > the text, so the only thing for Ken

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread fantasai
On 10/19/23 03:41, TAMURA, Kent wrote: Specification https://drafts.csswg.org/css-ruby-1/#ruby-display Summary New CSS displayproperty values, "ruby", "ruby-base", and "ruby-text", are added. The default display values of , and are changed to them, and ruby layout respec

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread 'Jeffrey Yasskin' via blink-dev
My reading of #1771 is that the only thing keeping out of HTML is the lack of a Blink or WebKit implementation. It looks like https://github.com/whatwg/html/pull/6478 is already written to improve the text, so the only thing for Kent to do is to make sure that this change implements that PR and th

Re: [blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread Domenic Denicola
On Thu, Oct 19, 2023 at 4:41 PM TAMURA, Kent wrote: > Contact emailstk...@chromium.org > > ExplainerNone > > Specificationhttps://drafts.csswg.org/css-ruby-1/#ruby-display > > Summary > > New CSS display property values, "ruby", "ruby-base", and "ruby-text", > are added. The default display value

[blink-dev] Intent to Ship: Ruby-specific display values

2023-10-19 Thread TAMURA, Kent
Contact emailstk...@chromium.org ExplainerNone Specificationhttps://drafts.csswg.org/css-ruby-1/#ruby-display Summary New CSS display property values, "ruby", "ruby-base", and "ruby-text", are added. The default display values of , and are changed to them, and ruby layout respects these displ