Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-05-01 Thread 'Noam Rosenthal' via blink-dev
On Mon, May 1, 2023 at 5:19 PM Mike Taylor wrote: > On 5/1/23 10:16 AM, Noam Rosenthal wrote: > > > On Mon, May 1, 2023 at 5:15 PM Mike Taylor wrote: > >> Hi Noam, >> >> Given the results, I would say you have the LGTMs you need to ship. Are >> you currently launched at 100% via Finch? LGTM to

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-05-01 Thread Mike Taylor
On 5/1/23 10:16 AM, Noam Rosenthal wrote: On Mon, May 1, 2023 at 5:15 PM Mike Taylor wrote: Hi Noam, Given the results, I would say you have the LGTMs you need to ship. Are you currently launched at 100% via Finch? LGTM to enable in tip of tree if so. No, should I slowly

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-05-01 Thread 'Noam Rosenthal' via blink-dev
On Mon, May 1, 2023 at 5:15 PM Mike Taylor wrote: > Hi Noam, > > Given the results, I would say you have the LGTMs you need to ship. Are > you currently launched at 100% via Finch? LGTM to enable in tip of tree if > so. > No, should I slowly enable finch until it's 100% before enabling? -- You

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-05-01 Thread Mike Taylor
Hi Noam, Given the results, I would say you have the LGTMs you need to ship. Are you currently launched at 100% via Finch? LGTM to enable in tip of tree if so. later, Mike On 5/1/23 2:06 AM, Noam Rosenthal wrote: Additional LGTMs? On Monday, April 24, 2023 at 6:58:20 PM UTC+3 Noam

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-05-01 Thread Noam Rosenthal
Additional LGTMs? On Monday, April 24, 2023 at 6:58:20 PM UTC+3 Noam Rosenthal wrote: Following up on this. I conducted a finch trial, which (expectedly) has shown no statistically significant performance impact. Note that the flag which the finch is based on only tests pages that attempted to

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-04-24 Thread 'Noam Rosenthal' via blink-dev
Following up on this. I conducted a finch trial, which (expectedly) has shown no statistically significant performance impact. Note that the flag which the finch is based on only tests pages that attempted to reuse a prefetch. I would like to proceed with removing the 5 minute rule. Would be

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-04-24 Thread Yoav Weiss
My LGTM still stands. Glad we're not seeing any related regressions! On Sun, Apr 23, 2023 at 7:43 AM Noam Rosenthal wrote: > Following up on this. > I conducted a finch trial, which (expectedly) has shown no statistically > significant performance impact. > Note that the flag which the finch is

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-01-18 Thread Daniel Bratell
LGTM3 /Daniel On 2023-01-14 05:11, Noam Rosenthal wrote: On Fri, Jan 13, 2023 at 7:19 PM Yoav Weiss wrote: LGTM2 to launch this as a Finch experiment. On Fri, Jan 13, 2023 at 5:55 PM Rick Byers wrote: LGTM1 from an API owners perspective. It's arguable whether

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-01-13 Thread Noam Rosenthal
On Fri, Jan 13, 2023 at 7:19 PM Yoav Weiss wrote: > LGTM2 to launch this as a Finch experiment. > > On Fri, Jan 13, 2023 at 5:55 PM Rick Byers wrote: > >> LGTM1 from an API owners perspective. It's arguable whether this is >> "web-exposed" at all, or just a browser performance heuristic you're

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-01-13 Thread Yoav Weiss
LGTM2 to launch this as a Finch experiment. On Fri, Jan 13, 2023 at 5:55 PM Rick Byers wrote: > LGTM1 from an API owners perspective. It's arguable whether this is > "web-exposed" at all, or just a browser performance heuristic you're > tweaking. > > From a performance perspective, your

Re: [blink-dev] Intent to Ship: removing the five-minute rule for

2023-01-13 Thread Rick Byers
LGTM1 from an API owners perspective. It's arguable whether this is "web-exposed" at all, or just a browser performance heuristic you're tweaking. >From a performance perspective, your argument and UMA analysis is compelling to me. But I've learned the hard way not to trust predictions of

[blink-dev] Intent to Ship: removing the five-minute rule for

2023-01-12 Thread Noam Rosenthal
Contact emails nrosent...@chromium.org Explainer No specific explainer, but all the details are here: https://chromestatus.com/feature/5087526916718592?context=myfeatures https://bugs.chromium.org/p/chromium/issues/detail?id=1345207=5%20minute=3 Spec This feature was never specified! A new