[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-02 Thread Nicolás Peña
Brief update: both spec PRs are now merged. Hoping to ship in M122. On Friday, December 15, 2023 at 2:29:58 PM UTC-5 Nicolás Peña wrote: > Contact emails > > n...@chromium.org > > Explainer > > Domain Hint (formerly hosted domain): > https://github.com/fedidcg/FedCM/issues/427 > > Disconnect (fo

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Alex Russell
Hey Nicolas: Sorry for not fully understanding the impact of these features. A (very) quick read on my end suggests that they might not be related? Is there a code example or explainer that highlights why they belong in the same Intent? Thanks, Alex On Tuesday, January 2, 2024 at 8:42:38 AM

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread 'Nicolás Peña Moreno' via blink-dev
Hey Alex, You are right that they are only related in that they are extensions of the FedCM API. We bundled them up together in the same intent since we considered them small enough such that a single intent containing both is still manageable, and this reduces the burocratic overhead for shipp

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-07 Thread Alex Russell
hey Nicholas, Apologies for the slow follow up here. As a general matter I don't have a strong opinion about bundling of intents, assuming they're all non-controversial and don't need additional review. That suggests as case-by-case review, which also seems fine here. I'm happy for the domain

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-08 Thread Nicolás Peña
Hey Alex, Thanks for the clarification. We will keep bundling intents that we consider small or non-controversial in the future. Regarding the naming of `disconnect`, we did have the TAG mention no concerns on the API, albeit under the original name of `revoke`. We changed the name to `disco

[blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-10 Thread Yoav Weiss
LGTM3 On Monday, January 8, 2024 at 9:48:00 PM UTC+1 Nicolás Peña wrote: Hey Alex, Thanks for the clarification. We will keep bundling intents that we consider small or non-controversial in the future. Regarding the naming of `disconnect`, we did have the TAG mention no concerns on the API,

Re: [blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Mike Taylor
LGTM1 On 1/2/24 11:42 AM, Nicolás Peña wrote: Brief update: both spec PRs are now merged. Hoping to ship in M122. On Friday, December 15, 2023 at 2:29:58 PM UTC-5 Nicolás Peña wrote: Contact emails n...@chromium.org Explainer Domain Hint (formerly hosted domain): https:

Re: [blink-dev] Re: Intent to Ship: FedCM: domain hint and disconnect

2024-01-03 Thread Chris Harrelson
LGTM2 On Wed, Jan 3, 2024 at 8:40 AM Mike Taylor wrote: > LGTM1 > On 1/2/24 11:42 AM, Nicolás Peña wrote: > > Brief update: both spec PRs are now merged. Hoping to ship in M122. > > On Friday, December 15, 2023 at 2:29:58 PM UTC-5 Nicolás Peña wrote: > >> Contact emails >> >> n...@chromium.org >