Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-05 Thread Alex Russell
Please file an issue with the TAG as an FYI and let us know when they respond. Their job is to help us drive coherence across the platform and spot architectural patterns. There might be other occurances of similar oversights that they can help us spot and fix. Best, Alex On Tuesday, March 28

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-05 Thread 'Ari Chivukula' via blink-dev
https://github.com/w3ctag/design-reviews/issues/833 On Wednesday, April 5, 2023 at 11:27:22 AM UTC-4 Alex Russell wrote: > Please file an issue with the TAG as an FYI and let us know when they > respond. Their job is to help us drive coherence across the platform and > spot architectural patter

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-19 Thread Rick Byers
This makes a lot of sense to me. Normally we prefer to approve shipping only after spec PRs have landed, it looks like the PR is blocked on some work from you including landing the WPTs, right? I'd suggest you get this all landed under a status=experimental RuntimeEnabledFeature and see if we can g

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-19 Thread Ari Chivukula
That differs from my past experience (in which a proposed spec change is sufficient to move forward with a launch), but if you want me to build and test it all behind a flag before I get the go ahead here that's fine. ~ Ari Chivukula (Their/There/They're) On Wed, Apr 19, 2023 at 11:32 AM Rick By

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-19 Thread Rick Byers
Hi Ari, The documented process is to land features and specs before requesting approval to ship, as that gives the best possible chance for wide review and eventual interop. But we unfortunately often find ourselves in

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-19 Thread Ari Chivukula
Works for me, didn't realize that was the standard order. ~ Ari Chivukula (Their/There/They're) On Wed, Apr 19, 2023 at 11:58 AM Rick Byers wrote: > Hi Ari, > The documented process > > is > to land features and

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-04-19 Thread Rick Byers
Great, thanks Ari! No worries at all, checking to make sure the i's have been dotted and t's have been crossed is what the API owners are here for :-) On Wed, Apr 19, 2023 at 11:59 AM Ari Chivukula wrote: > Works for me, didn't realize that was the standard order. > > ~ Ari Chivukula (Their/Ther

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-06-07 Thread Ari Chivukula
I'm back! The code has been merged behind a flag w/ wpts: https://chromium-review.googlesource.com/c/chromium/src/+/4538244 The spec changes have been merged too: https://github.com/w3c/navigation-timing/pull/188 https://github.com/WICG/client-hints-infrastructure/pull/153 ~ Ari Chivukula (Their/

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-06-07 Thread Chris Harrelson
Thanks! LGTM1 On Wed, Jun 7, 2023 at 6:55 AM Ari Chivukula wrote: > I'm back! The code has been merged behind a flag w/ wpts: > https://chromium-review.googlesource.com/c/chromium/src/+/4538244 > > The spec changes have been merged too: > https://github.com/w3c/navigation-timing/pull/188 > https

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-06-07 Thread Philip Jägenstedt
LGTM2 On Wed, Jun 7, 2023 at 5:36 PM Chris Harrelson wrote: > Thanks! LGTM1 > > On Wed, Jun 7, 2023 at 6:55 AM Ari Chivukula wrote: > >> I'm back! The code has been merged behind a flag w/ wpts: >> https://chromium-review.googlesource.com/c/chromium/src/+/4538244 >> >> The spec changes have bee

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-06-07 Thread slightlyoff via Chromestatus
LGTM2 -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chro

Re: [blink-dev] Intent to Prototype & Ship: Report Critical-CH caused restart in NavigationTiming

2023-06-07 Thread Daniel Bratell
LGTM3 /Daniel On 2023-06-07 17:37, Philip Jägenstedt wrote: LGTM2 On Wed, Jun 7, 2023 at 5:36 PM Chris Harrelson wrote: Thanks! LGTM1 On Wed, Jun 7, 2023 at 6:55 AM Ari Chivukula wrote: I'm back! The code has been merged behind a flag w/ wpts: https://chromiu