[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484940#comment-13484940
]
Hudson commented on BOOKKEEPER-346:
---
Integrated in bookkeeper-trunk #775 (See
[http
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484686#comment-13484686
]
Vinay commented on BOOKKEEPER-346:
--
Thanks Ivan, I will correct the logic, also corre
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484151#comment-13484151
]
Ivan Kelly commented on BOOKKEEPER-346:
---
Theres a logic error in the patch (and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484024#comment-13484024
]
Ivan Kelly commented on BOOKKEEPER-346:
---
".idx" and ".rloc" should be defined as
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484023#comment-13484023
]
Ivan Kelly commented on BOOKKEEPER-346:
---
Yes, you can put it in getActiveLedger(
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484018#comment-13484018
]
Vinay commented on BOOKKEEPER-346:
--
Thanks Ivan,
You mean to say, After scanning all
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483980#comment-13483980
]
Ivan Kelly commented on BOOKKEEPER-346:
---
New patch misses the case of a crash be
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483899#comment-13483899
]
Vinay commented on BOOKKEEPER-346:
--
Oh!!
Then I will post a patch with just movement
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483726#comment-13483726
]
Sijie Guo commented on BOOKKEEPER-346:
--
[~ikelly] Ah, ur right. we had LedgerCach
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483373#comment-13483373
]
Ivan Kelly commented on BOOKKEEPER-346:
---
I dont like the coupling of the journal
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479985#comment-13479985
]
Vinay commented on BOOKKEEPER-346:
--
{quote}there would be no *.idx for that ledger, t
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479982#comment-13479982
]
Vinay commented on BOOKKEEPER-346:
--
{quote}for journal entry, I would suggest to move
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479640#comment-13479640
]
Vinay commented on BOOKKEEPER-346:
--
Thanks [~hustlmsp] for the detailed suggestion on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479046#comment-13479046
]
Sijie Guo commented on BOOKKEEPER-346:
--
One possible better solution for 2) is co
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479034#comment-13479034
]
Sijie Guo commented on BOOKKEEPER-346:
--
sorry for late response. the overall of t
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476840#comment-13476840
]
Sijie Guo commented on BOOKKEEPER-346:
--
sure. I tried to take a look at last week
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476794#comment-13476794
]
Vinay commented on BOOKKEEPER-346:
--
[~hustlmsp] Can you please take a look at this pa
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452902#comment-13452902
]
Vinay commented on BOOKKEEPER-346:
--
Thanks Sijie. I agree with your point.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452889#comment-13452889
]
Sijie Guo commented on BOOKKEEPER-346:
--
{code}
+/**
+ * Copies current fi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443084#comment-13443084
]
Vinay commented on BOOKKEEPER-346:
--
Oh..I forgot to mention this again.. This patch d
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443080#comment-13443080
]
Ivan Kelly commented on BOOKKEEPER-346:
---
LedgerDirsManager is still missing from
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417079#comment-13417079
]
Vinay commented on BOOKKEEPER-346:
--
Here, on flush failure of index file, copying the
22 matches
Mail list logo