Re: [Bridge] [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev

2018-03-12 Thread Igor Mitsyanko
On 03/10/2018 08:38 AM, Andrew Lunn wrote: + return 0; + + err = br_switchdev_set_port_flag(p, flags, mask); + if (err) + return err; You might want to consider the br_warn() in br_switchdev_set_port_flag(). Do we want to spam the kernel log? Or should

Re: [Bridge] [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev

2018-03-10 Thread Andrew Lunn
On Fri, Mar 09, 2018 at 07:03:05PM -0800, Igor Mitsyanko wrote: > sysfs interface to configure bridge flags only updates SW copy but does > not notify hardware through switchdev interface. Make sure it is. > > Signed-off-by: Igor Mitsyanko > --- >

[Bridge] [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev

2018-03-09 Thread Igor Mitsyanko
sysfs interface to configure bridge flags only updates SW copy but does not notify hardware through switchdev interface. Make sure it is. Signed-off-by: Igor Mitsyanko --- net/bridge/br_sysfs_if.c | 15 +++ 1 file changed, 11 insertions(+), 4