[Bro-Dev] [Auto] Merge Status

2013-10-11 Thread Merge Tracker
Open Merge Requests === IDComponentReporter Assignee Updated For VersionPrioritySummary --- --- -- - --

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/dnthayer/doc-changes-for-2.2: Add README files for most Bro frameworks (60b2c5f)

2013-10-11 Thread Robin Sommer
On Thu, Oct 10, 2013 at 22:29 -0700, Daniel Thayer wrote: Add README files for most Bro frameworks I'm forgetting if it works to put these as comments into the __load__.bro files? If so, that would be an alternative as it avoids having a new file in each directory (the README's are easier

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/dnthayer/doc-changes-for-2.2: Add README files for most Bro frameworks (60b2c5f)

2013-10-11 Thread Daniel Thayer
On 10/11/2013 09:55 AM, Robin Sommer wrote: On Thu, Oct 10, 2013 at 22:29 -0700, Daniel Thayer wrote: Add README files for most Bro frameworks I'm forgetting if it works to put these as comments into the __load__.bro files? If so, that would be an alternative as it avoids having a

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/dnthayer/doc-changes-for-2.2: Add README files for most Bro frameworks (60b2c5f)

2013-10-11 Thread Seth Hall
On Oct 11, 2013, at 10:55 AM, Robin Sommer ro...@icir.org wrote: I'm forgetting if it works to put these as comments into the __load__.bro files? I'm inclined to say having README files would be better since ultimately all of this is just leading toward creating a more formalized module

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/dnthayer/doc-changes-for-2.2: Add README files for most Bro frameworks (60b2c5f)

2013-10-11 Thread Robin Sommer
On Fri, Oct 11, 2013 at 11:53 -0400, you wrote: ultimately all of this is just leading toward creating a more formalized module style and having READMEs in the directory would probably be good form in general. Ah, good point. Robin -- Robin Sommer * Phone +1 (510) 722-6541 *

[Bro-Dev] [JIRA] (BIT-1089) Please install sample/example broctl .cfg files

2013-10-11 Thread Jon Siwek (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209#comment-14209 ] Jon Siwek commented on BIT-1089: Is it ok to always install a sample plus the real version (if

[Bro-Dev] [JIRA] (BIT-1089) Please install sample/example broctl .cfg files

2013-10-11 Thread leres (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14210#comment-14210 ] leres commented on BIT-1089: The current behavior where it only installs a .cfg if none exist is

[Bro-Dev] [JIRA] (BIT-1045) Review usage of InternalError when parsing network traffic

2013-10-11 Thread Robin Sommer (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14211#comment-14211 ] Robin Sommer commented on BIT-1045: --- Going through, I see number of places where I'd argue

Re: [Bro-Dev] [JIRA] (BIT-1089) Please install sample/example broctl .cfg files

2013-10-11 Thread Robin Sommer
On Fri, Oct 11, 2013 at 13:37 -0500, you wrote: The current behavior where it only installs a .cfg if none exist is totally fine. What I'm asking for is that either by default or by turning on a cmake argument it would install sample configs. I'm still not sure I'm really getting the issue

[Bro-Dev] [JIRA] (BIT-1089) Please install sample/example broctl .cfg files

2013-10-11 Thread Robin Sommer (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212#comment-14212 ] Robin Sommer commented on BIT-1089: --- I'm still not sure I'm really getting the issue but