On 2025-09-11 04:49, Steffen Nurpmeso wrote:
if (lchownat (dst_dirfd, relname, p->st.st_uid, p->st.st_gid)
!= 0)
...
error (0, errno, _("failed to preserve ownership for %s"),
quoteaf (dst_name));
Here there is
Collin Funk writes:
> That is my hypothesis at least, will need to write a patch to test it.
Looks like my hypothesis was correct. I ran the CI with the attached
patch, and everything passes.
I'll hold off pushing until Pádraig checks it. Since he may want to
revisit his previous commit and han
Pádraig Brady writes:
> There may be more cleanups I might do in this area,
> but we should commit this fix anyway.
Done, thanks.
Collin
Pádraig Brady wrote:
> p.s. an ASAN build would be good for CI
The CI already includes an ASAN + UBSAN build: see
https://github.com/coreutils/ci-check/blob/master/.github/workflows/many-platforms.yml#L850
named "make check with sanitizers" in
https://github.com/coreutils/ci-check/actions/runs/177
On 14/09/2025 07:07, Collin Funk wrote:
Collin Funk writes:
That is my hypothesis at least, will need to write a patch to test it.
Looks like my hypothesis was correct. I ran the CI with the attached
patch, and everything passes.
I'll hold off pushing until Pádraig checks it. Since he may w
Isn't it better to surprise users who know what they're doing with a
warning, than to surprise users who *don't* know what they're doing with
the lack of one?
On Sat, Sep 13, 2025 at 11:54 PM Collin Funk wrote:
> Paul Eggert writes:
>
> > On 2025-09-13 03:16, Chris wrote:
> >> It seems to me it
