Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-16 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: ... > This point I can agree with. --group-directories-first is relatively new, > and since it is currently silent about behavior on links, I have no > problem with changing that behavior; however, I would insist that if we > make a change, we add test cases a

Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-15 Thread Matthew Woehlke
Linda Walsh wrote: It would be inconsistent with the proprietary OS's behavior after which the option was modeled. Is that logical? Believe me, I understand wanting to see symlinks to dirs grouped with dirs, but this isn't how it's done in explorer and doesn't seem consistent. I wouldn

Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-12 Thread Linda Walsh
Eric Blake wrote: Additionally, IIRC, one of the reasons that --group-directories-first was added was to mimic default behavior of a certain 'dir' program popular on proprietary systems, but those systems did not have symlinks, so there really is no prior art on how ls should behave on symlinks-t

Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-12 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bert Wesarg on 2/12/2008 9:50 AM: |> Thanks for the patch, but a change in behavior like that |> requires some serious justification. | I read the thread in the mail archive. Eric Blake questioned the symlink | behavior in the first reply

Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-12 Thread Bert Wesarg
Jim Meyering wrote: Bert Wesarg <[EMAIL PROTECTED]> wrote: With the --group-directories-first option, ls shows directories on top of all non directory entries, but IMHO symlinks to directories should be handle as directories as well. Thanks for the patch, but a change in behavior like that req

Re: [PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-12 Thread Jim Meyering
Bert Wesarg <[EMAIL PROTECTED]> wrote: > With the --group-directories-first option, ls shows directories on top of all > non directory entries, but IMHO symlinks to directories should be handle as > directories as well. Thanks for the patch, but a change in behavior like that requires some serious

[PATCH] ls --group-directories-first: symlinks to dirs are dirs too

2008-02-12 Thread Bert Wesarg
With the --group-directories-first option, ls shows directories on top of all non directory entries, but IMHO symlinks to directories should be handle as directories as well. Regards. Bert 2008-02-12 Bert Wesarg <[EMAIL PROTECTED]> ls --group-directories-first: symlinks to dirs are di