bug#47412: env: fragile argument parsing

2021-03-29 Thread Paul Eggert
On 3/26/21 3:21 PM, Paul Eggert wrote: The -S code could use some more fixes in this area too - it can probably still dump core on platforms like the Hurd that don't limit exec arg size - but one thing at a time. I fixed the (unlikely) bugs I found in this area by installing the attached. >F

bug#47412: env: fragile argument parsing

2021-03-29 Thread Pádraig Brady
On 26/03/2021 20:52, Paul Eggert wrote: Thanks for the bug report. I installed the attached to fix it and am closing the report. The fix looks good, thanks. I added in a test case also at: https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=9f1bda18f cheers, Pádraig

bug#47412: env: fragile argument parsing

2021-03-26 Thread Paul Eggert
I also installed the attached two followup patches to document this and issue a better warning in rare cases. The -S code could use some more fixes in this area too - it can probably still dump core on platforms like the Hurd that don't limit exec arg size - but one thing at a time. >From 6c4e

bug#47412: env: fragile argument parsing

2021-03-26 Thread Paul Eggert
Thanks for the bug report. I installed the attached to fix it and am closing the report. >From 6dd466eda6fa3f1f7d2a9474ec926ccd2ede98e9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 26 Mar 2021 13:49:49 -0700 Subject: [PATCH] env: fix address violation with '\v' in -S Problem reported by

bug#47412: env: fragile argument parsing

2021-03-26 Thread Paul Eggert
On 3/26/21 1:12 PM, Pádraig Brady wrote: I'll fix it up. I've got a fix. My goodness, that part of the code is messy.

bug#47412: env: fragile argument parsing

2021-03-26 Thread Pádraig Brady
On 26/03/2021 15:00, Frank Busse wrote: Hi, env crashes for some nonsensical command line arguments (reported by KLEE), e.g.: --- python3 -c "import os; os.execl('./src/env', 'env', b'--s=\"\"\t\x0b')" = ==140651==ERROR: Addres

bug#47412: env: fragile argument parsing

2021-03-26 Thread Frank Busse
Hi, env crashes for some nonsensical command line arguments (reported by KLEE), e.g.: --- > python3 -c "import os; os.execl('./src/env', 'env', b'--s=\"\"\t\x0b')" = ==140651==ERROR: AddressSanitizer: heap-buffer-overflow on addres