Re: Use size_t instead of int for internal variables in glob (bug 14621)

2012-09-25 Thread Roland McGrath
Those changes are fine.

Re: maint.mk: improve the release procedure

2012-09-25 Thread Akim Demaille
Le 25 sept. 2012 à 17:25, Stefano Lattarini a écrit : Hi Stefano, > Alas, this is busted for empty strings: > >$ cat Makefile >equal = ... >empty1 = >empty2 = >all: > $(if $(call equal,$(emtpy1),$(empty2)),:,false) >$ make >false >make: *** [all] Error 1 >

Re: maint.mk: improve the release procedure

2012-09-25 Thread Akim Demaille
Le 25 sept. 2012 à 17:03, Jim Meyering a écrit : > ACK. > Only reservation is that the new name, "equal" > may be too generic, i.e., may interfere with a > Makefile that uses maint.mk. Maybe "_equal" instead? I used that name. This is what I installed: From cb38ce7db84edb421fbaeea5abe16ebeb8a

Use size_t instead of int for internal variables in glob (bug 14621)

2012-09-25 Thread Joseph S. Myers
Bug 14621 is the use of int for certain internal variables in glob, when those variables are assigned quantities derived from size_t values. As noted in that issue, this seems likely to be exploitable on 64-bit systems with tens of GB of memory (I can't completely rule out exploits with less memor

Re: maint.mk: improve the release procedure

2012-09-25 Thread Stefano Lattarini
Hi Akim, Jim. On 09/25/2012 12:32 PM, Akim Demaille wrote: > > Le 25 sept. 2012 à 12:11, Akim Demaille a écrit : > >>> Pushed. >> >> Well, there are several issues with the patch. I'm on it right now. >> Do not upgrade gnulib right now. > > Here are the proposed fixes. I had only tested these

Re: maint.mk: improve the release procedure

2012-09-25 Thread Jim Meyering
Akim Demaille wrote: > Le 25 sept. 2012 à 12:11, Akim Demaille a écrit : > >>> Pushed. >> >> Well, there are several issues with the patch. I'm on it right now. >> Do not upgrade gnulib right now. > > Here are the proposed fixes. I had only tested these patches > with the various targets of the r

Re: extern-inline: be -Wundef safe in config.h

2012-09-25 Thread Eric Blake
On 09/25/2012 06:27 AM, Akim Demaille wrote: > Recent changes introduce -Wundef warnings in config.h. The > appended proposal eliminates them. > > -#if __GNUC__ ? __GNUC_STDC_INLINE__ : 199901L <= __STDC_VERSION__ > +#if (__GNUC__ \ Even though gcc's -Wundef will never warn about __GNUC__ being

hash-pjw license

2012-09-25 Thread Nikos Mavrogiannopoulos
Hello, Would it be possible to relicense hash-pjw under LGPLv2+ or v3+? It is quite a useful function and I'd like to use it in gnutls and libtasn1 (I could re-implement it but I'd like to avoid that if possible). Also would it be possible to have a version that works with non-null terminated stri

extern-inline: be -Wundef safe in config.h

2012-09-25 Thread Akim Demaille
Recent changes introduce -Wundef warnings in config.h. The appended proposal eliminates them. From c25db77aa193431c0669df846153a9e67db585d0 Mon Sep 17 00:00:00 2001 From: Akim Demaille Date: Tue, 25 Sep 2012 13:58:12 +0200 Subject: [PATCH] extern-inline: provide a -Wundef safe config.h * m4/ext

Re: maint.mk: improve the release procedure

2012-09-25 Thread Akim Demaille
Le 25 sept. 2012 à 12:11, Akim Demaille a écrit : >> Pushed. > > Well, there are several issues with the patch. I'm on it right now. > Do not upgrade gnulib right now. Here are the proposed fixes. I had only tested these patches with the various targets of the release procedure, I had not ant

Re: maint.mk: improve the release procedure

2012-09-25 Thread Akim Demaille
> Pushed. Well, there are several issues with the patch. I'm on it right now. Do not upgrade gnulib right now.

Re: maint.mk: improve the release procedure

2012-09-25 Thread Akim Demaille
Le 25 sept. 2012 à 11:28, Jim Meyering a écrit : > Nice. Thanks for all of that. Sure :) > ACK to all three with a barely-worth-mentioning nit below. Fixed. I also noticed I forgot the ChangeLog for the last one. Fixed too. Pushed.

Re: maint.mk: improve the release procedure

2012-09-25 Thread Jim Meyering
Akim Demaille wrote: > Le 24 sept. 2012 à 09:47, Jim Meyering a écrit : > >> You're welcome to leave it as is. > > Attached the two updated patches, and another to propagate > the style where the body of ifeq and co. is indented. > >> IMHO, more important would be to remove the need to specify >> R