Re: patch to quote files in source archive setup

2024-01-27 Thread Paul Eggert
On 2024-01-27 13:06, Bruno Haible wrote: ${source_extra-"$source_extra"} does word-splitting and globbing expansion of "$source_extra" Sorry, that was a thinko. I installed the attached to fix that. On 2024-01-27 15:36, Patrice Dumas wrote: In my testings, I get an error. This should be f

Re: patch to quote files in source archive setup

2024-01-27 Thread Patrice Dumas
On Sat, Jan 27, 2024 at 12:46:33PM -0800, Paul Eggert wrote: > On 2024-01-27 08:39, Bruno Haible wrote: > > > Here is a reworked patch and ChangeLog based on your advices/ideas. > > > In my tests quotes, *, ? and spaces are now accepted in file names, but > > > not backslashes. > > > > Thanks! App

Re: patch to quote files in source archive setup

2024-01-27 Thread Bruno Haible
Paul Eggert wrote: > In reviewing that I found an opportunity to allow even odder situations, > by passing the need to use 'ls', and installed the attached followup. Avoiding 'ls' is a nice improvement, because it removes the restrictions on file names. However, ${source_extra-"$source_extra"}

Re: patch to quote files in source archive setup

2024-01-27 Thread Paul Eggert
On 2024-01-27 08:39, Bruno Haible wrote: Here is a reworked patch and ChangeLog based on your advices/ideas. In my tests quotes, *, ? and spaces are now accepted in file names, but not backslashes. Thanks! Applied. In reviewing that I found an opportunity to allow even odder situations, by p

Re: patch to quote files in source archive setup

2024-01-27 Thread Bruno Haible
> Here is a reworked patch and ChangeLog based on your advices/ideas. > In my tests quotes, *, ? and spaces are now accepted in file names, but > not backslashes. Thanks! Applied.

Re: patch to quote files in source archive setup

2024-01-27 Thread Bruno Haible
Patrice Dumas wrote: > I can propose a patch with --files-from instead, it should be simpler > and avoid the intermediate read, I believe. Yes please. > > src_list=`ls -d *.texinfo *.texi *.txi *.eps "$source_extra" 2>/dev/null` > > || true Also, GNU ls, by default, obeys an environment varia

Re: patch to quote files in source archive setup

2024-01-27 Thread Patrice Dumas
Hello, Here is a reworked patch and ChangeLog based on your advices/ideas. In my tests quotes, *, ? and spaces are now accepted in file names, but not backslashes. I used the short option -T for consistency with the other calls to tar. I have noticed that there are already tar calls with -- whic

Re: patch to quote files in source archive setup

2024-01-27 Thread Patrice Dumas
On Sat, Jan 27, 2024 at 04:18:20PM +0100, Bruno Haible wrote: > Hi Patrice, > > > Here is a patch to have the files used in the Texinfo source archive > > quoted in the call to tar. > > The first line of your ChangeLog entry should not only be a summary of > the technical change. But rather, it s

Re: patch to quote files in source archive setup

2024-01-27 Thread Bruno Haible
Hi Patrice, > Here is a patch to have the files used in the Texinfo source archive > quoted in the call to tar. The first line of your ChangeLog entry should not only be a summary of the technical change. But rather, it should state which file names would be supported with your patch that were no

patch to quote files in source archive setup

2024-01-27 Thread Patrice Dumas
Hello, Here is a patch to have the files used in the Texinfo source archive quoted in the call to tar. I tried to mimic what is done for the other $cmd that are eval'ed to have proper quoting. I also kept the ls -d to detect the files and add a read in the middle to quote. -- Pat diff --git a/

Re: patch for gendoc.sh --no-html fix

2024-01-27 Thread Bruno Haible
Patrice Dumas wrote: > A small patch for a small typo in gendoc.sh for --no-html. Thanks. Applied.

patch for gendoc.sh --no-html fix

2024-01-27 Thread Patrice Dumas
Hello, A small patch for a small typo in gendoc.sh for --no-html. -- Pat diff --git a/ChangeLog b/ChangeLog index 65982d7177..da748f4f3d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2024-01-27 Patrice Dumas + + gendocs: fix --no-html + * build-aux/gendocs.sh: fix typo in variable n