Re: Question about 'gen-header' module and friends.

2024-03-07 Thread Collin Funk
On 3/7/24 6:10 PM, Collin Funk wrote: > I have not implemented it yet in gnulib-tool.py so the snippet is just > copy and pasted from the module. The part I wanted to ask about was > the second line of the comment which is removed by gnulib-tool. Should > the sed invocations [1] be changed to only

Question about 'gen-header' module and friends.

2024-03-07 Thread Collin Funk
Hello, I was about to start working on gnulib-tool.py a bit more today and remembered seeing something I wanted to ask about. When creating a testdir that uses system headers, you see the following lines when diff'ing 'gltests/Makefile.am' from each implementation: # Use $(gl_V_at) instead of $(

Re: gnulib-tool.py: Fix errors when executing --create-megatestdir.

2024-03-07 Thread Collin Funk
On 3/7/24 3:51 AM, Bruno Haible wrote: > Indeed, when there are such typos in the code, you know that it has not > been tested. No worries. 99% of the work was done for me there. I assumed someone committed with the intent of coming back to it but forgot. Collin

Re: gnulib-tool.py: Fix errors when executing --create-megatestdir.

2024-03-07 Thread Bruno Haible
Collin Funk wrote: > This is because megasubdirs is a list. The correct call should be > ' '.join(megasubdirs). Indeed, when there are such typos in the code, you know that it has not been tested. > I've attached a patch that fixes all of these so --create-megatestdir > should work properly now.

Re: gnulib-tool.py: Follow gnulib-tool changes, part 45, 46.

2024-03-07 Thread Bruno Haible
Hi Collin, > Hi, here is two patches. The first implements the > '--tests-makefile-name' options. Are there any packages that use this > option? I couldn't seem to find anything from Debian and GitHub code > search outside of Gnulib itself or mirrors. Yes, so far, gnulib/examples/hello-c-gnulib-a

gnulib-tool.py: Fix errors when executing --create-megatestdir.

2024-03-07 Thread Collin Funk
When running gnulib-tool.py --create-megatestdirs: Traceback (most recent call last): File "/home/collin/.local/src/gnulib/pygnulib/main.py", line 1209, in main() File "/home/collin/.local/src/gnulib/pygnulib/main.py", line 959, in main testdir.execute() File "/home/collin/.local/sr