Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 56.

2024-03-12 Thread Bruno Haible
Hi Collin, > This patch adds the reminders to use AC_PROG_CC macro instead of > the obsolete AC_PROG_CC_STDC or AC_PROG_CC_C99. > > This change is pretty small so it seemed like a good place to remove > the exit() from GLImport.execute(). Nice! Thanks, patch applied. > The only spooky line is:

[PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 56.

2024-03-12 Thread Collin Funk
This patch adds the reminders to use AC_PROG_CC macro instead of the obsolete AC_PROG_CC_STDC or AC_PROG_CC_C99. This change is pretty small so it seemed like a good place to remove the exit() from GLImport.execute(). The output differs slightly from the shell script but shouldn't be too much work

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 55.

2024-03-12 Thread Bruno Haible
Collin Funk wrote: > I've attached a fix. Thanks! Applied. Bruno

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 55.

2024-03-12 Thread Collin Funk
Hey Bruno, On 3/12/24 10:07 AM, Collin Funk wrote: > Yeah, I can see that becoming an issue. Some areas the backslashes get > confusing as well. I had to run the test case a few times to convince > myself I got it correct... Well, that is a bit embarrassing. It looks like I spoke too soon. /home

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 55.

2024-03-12 Thread Collin Funk
Hi Bruno, On 3/12/24 9:52 AM, Bruno Haible wrote: > It works well in this case. But it becomes hairy when, in the mixed > autoconf/shell code that is emitted, there is a shell variable reference > ${foo} > because Python will interpret this as a reference to the Python variable > foo. Fortunatel

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 55.

2024-03-12 Thread Bruno Haible
Collin Funk wrote: > I've attached a pretty simple patch that fixes an item in > gnulib-tool.py.TODO. It fixes a lot of the remaining lines in the diff > between gnulib-tool and gnulib-tool.py which is nice. Thanks! Applied. > I decided to change GLEmiter.initmacro_end to use f-strings. It seems