[PATCH] gnulib-tool.py: Handle removed files in the vc ignore files.

2024-03-24 Thread Collin Funk
Hi Bruno, On 3/24/24 5:18 PM, Bruno Haible wrote: > Thanks, applied, with a tweak: I don't like the variable name 'group' > here. I know that 'tuple' is not possible either. But a couple of lines > below we call it a 'row', and that fits better (imagining the ignorelist > as a matrix). Yes, that

[PATCH] gnulib-tool.py: Fix "Creating directory" output.

2024-03-24 Thread Collin Funk
This patch fixes this test failure: ./test-hello-c-gnulib-nonrecursive-1.out tmp1016386-out differ: byte 2612, line 147 --- ./test-hello-c-gnulib-nonrecursive-1.out2024-03-24 03:30:48.391074752 -0700 +++ tmp1016386-out 2024-03-24 18:33:30.855703830 -0700 @@ -144,9 +144,9 @@ m4/wchar_

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Bruno Haible
Hi Collin, > Can you apply this patch for me? Thanks, applied, with a tweak: I don't like the variable name 'group' here. I know that 'tuple' is not possible either. But a couple of lines below we call it a 'row', and that fits better (imagining the ignorelist as a matrix). > Then I am not convi

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Collin Funk
On 3/24/24 4:05 PM, Bruno Haible wrote: > Oh, indeed. If filetable['added'] and filetable['removed'] are the same, > no wonder that you are seeing nonsense in the .gitignore files... Yes, I didn't notice it because I thought the issue was in my interpretation of the 'sed' and 'join' commands in GL

gnulib-tool.py: Use Python raw strings for regular expressions

2024-03-24 Thread Bruno Haible
This patch changes the way we write the regular expression strings and replacement strings. So that we can avoid double backslashes. I've checked this patch with the parts of the test suite that already work (especially test-create-testdir-4.sh and test-wget2-1.sh), therefore I think it does not h

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Bruno Haible
Collin Funk wrote: > See this decade old typo: > > diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py > index d417137df6..2434e5f506 100644 > --- a/pygnulib/GLImport.py > +++ b/pygnulib/GLImport.py > @@ -1393,7 +1393,7 @@ AC_DEFUN([%s_FILE_LIST], [\n''' % macro_prefix > # Treat

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 69.

2024-03-24 Thread Collin Funk
On 3/23/24 7:15 PM, Bruno Haible wrote: > :-D Well, that's the principle of a von-Neumann computer: that a program > (consisting of instructions) can assemble other instructions, to form a new > program. For CPU instructions, it's a well-known technique. For 'sed' > programs, apparently not... LOL

Re: gnulib-tool.py: Bring the output into the right order

2024-03-24 Thread Collin Funk
On 3/24/24 2:51 PM, Bruno Haible wrote: > In the test-create-testdir-4.sh output, entire chunks of output are not > in the natural order. The reason is that a subprocess produces output > while the parent process still has some output sitting it its buffers. Good catch. It looks like you've made a

gnulib-tool.py: Bring the output into the right order

2024-03-24 Thread Bruno Haible
In the test-create-testdir-4.sh output, entire chunks of output are not in the natural order. The reason is that a subprocess produces output while the parent process still has some output sitting it its buffers. This patch fixes it, by adding a 'flush()' invocation when there was output and the p

Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-24 Thread Bruno Haible
Simon Josefsson wrote: > I think that miss some common > use-cases for when ./bootstrap is used, including: 1) non-regular > developers who we want to be able to build things as quickly as possible > with no additional documentation and git clone + ./bootstrap + > ./configure should work so they ca

nstrtime, c-nstrftime: Fix %c directive's result on glibc ≤ 2.30

2024-03-24 Thread Bruno Haible
On 2024-02-08 I did: nstrtime, c-nstrftime: Fix %c directive's result on NetBSD, Solaris. * lib/strftime.c (__strftime_internal): On NetBSD and Solaris, remove the last word of the %c directive's result if it looks like a time zone. * doc/posix-functions/strftime.te

Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.

2024-03-24 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Hi Simon and Collin, > >> > Could putting the following into bootstrap.conf be a method that >> > we could recommend? Then developers can override it with >> > GNULIB_TOOL_IMPL=sh ./bootstrap if they want. >> > >> > GNULIB_TOOL_IMPL=${GNULIB_TOOL_IMPL:-py} >> >> I'd like

gnulib-tool.py: Fix output of notices

2024-03-24 Thread Bruno Haible
Running test-create-testdir-4.sh, I get these output differences: --- test-create-testdir-4.out 2024-03-19 17:48:35.022049580 +0100 +++ tmp2316177-out 2024-03-24 02:43:45.085991474 +0100 @@ -3166,97 +3166,177 @@ yn-tests Notice from module atexit: This module is obsolete. + +

Re: Question about gnulib-tool coreutils test case

2024-03-24 Thread Bruno Haible
Hi Collin, > I think that the test-coreutils-1.sh test is missing --local-dir=gl. > Was this intentional? From test-coreutils-1.err: > > $ cat test-coreutils-1.err > gnulib-tool: warning: module buffer-lcm doesn't exist > gnulib-tool: warning: module cl-strtod doesn't exist > gnulib-tool: warnin

Question about gnulib-tool coreutils test case

2024-03-24 Thread Collin Funk
Hi Bruno, I think that the test-coreutils-1.sh test is missing --local-dir=gl. Was this intentional? From test-coreutils-1.err: $ cat test-coreutils-1.err gnulib-tool: warning: module buffer-lcm doesn't exist gnulib-tool: warning: module cl-strtod doesn't exist gnulib-tool: warning: module cl-st