* Solaris defines hasmntop with a char * instead of const char *
second argument. Passing the constant string "ignore" generates a
compiler warning. Define MNT_IGNORE correctly in both cases to avoid
the warning.
Signed-off-by: Ben Walton
---
lib/mountlist.c | 8 +++-
1 fi
The value is set in se
On Mon, Jun 2, 2014 at 8:31 PM, Pádraig Brady wrote:
> On 06/02/2014 08:13 PM, Ben Walton wrote:
>> * In the non-Win32 variant of rpl_rename, it is possible that
>> dst_exists may be set but not used. Mark it with the unused
>> attrib
On Mon, Jun 2, 2014 at 3:02 PM, Paul Eggert wrote:
> Ben Walton wrote:
>>
>> With a new _GL_UNUSED_LABEL, which is cleaner than my patch, I'm less
>> inclined.
>
>
> Then please go with that. It's not a big deal either way.
* In the non-Win32 variant of rpl_rename, it is possible that
dst_exists may be set but not used. Mark it with the unused
attribute to avoid compiler warnings.
Signed-off-by: Ben Walton
---
lib/rename.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rename.c b
* Avoid possible compiler warnings/errors by marking the out label
as potentially unused.
Signed-off-by: Ben Walton
---
lib/rename.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/rename.c b/lib/rename.c
index 2116028..55130d8 100644
--- a/lib/rename.c
+++ b
Hi All,
I've hit a "bug" in the coreutils test suite when exercising acl code
from gnulib. I'm cross-posting to both lists, I hope that's ok.
(Please apply the cluebat gently if not...)
When running tests involving cp -a (in /tmp for this example), I see
errors like:
+ cp -a --parents d/a/b/c e
Hi All,
When building coreutils on solaris 10 x86 with warnings as errors, the
mountlist.c code using hasmntopt complains about passing a const char
to a function expecting char. Solaris defines hasmntopt as:
char *hasmntopt(struct mnttab *, char *);
While it's easy to patch around locally,
On Sun, Jun 1, 2014 at 11:47 PM, Paul Eggert wrote:
> Ben Walton wrote:
>>
>> WIth your suggested followup
>> (prerequisite), I think that it's a better solution.
>
>
> Better yet, how about putting the goto-containing code into a subsdiary
> static fun
On Sun, Jun 1, 2014 at 9:59 PM, Pádraig Brady wrote:
> On 06/01/2014 09:34 AM, Ben Walton wrote:
>> * Avoid possible compiler warnings/errors by defining the out label
>> only when it may be accessed.
>>
>> Signed-off-by: Ben Walton
>> ---
>>
>&g
* lib/acl-internal.h (acl_nontrivial, acl_ace_nontrivial): Mark
Signed-off-by: Ben Walton
---
lib/acl-internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/acl-internal.h b/lib/acl-internal.h
index fdffe64..b238006 100644
--- a/lib/acl-internal.h
+++ b/lib
On 1 Jun 2014 21:16, "Pádraig Brady" wrote:
>
> On 06/01/2014 09:42 AM, Ben Walton wrote:
> > * lib/acl-internal.h (acl_ace_nontrivial): Apply pure attribute
> > * lib/file-has-acl.c: Disable pure attribute error.
> > - The AIX version of acl
* lib/acl-internal.h (acl_ace_nontrivial): Apply pure attribute
* lib/file-has-acl.c: Disable pure attribute error.
- The AIX version of acl_nontrivial isn't pure while other
versions are. We cannot apply the attribute globally.
Signed-off-by: Ben Walton
---
When bui
* Avoid possible compiler warnings/errors by defining the out label
only when it may be accessed.
Signed-off-by: Ben Walton
---
Hi All,
When building coreutils 8.22 on Solaris with -Werror=unused-label, the build
fails with:
lib/rename.c: In function 'rpl_rename':
lib/rena
; arguments, like here:
Yes, it seems I was mistaken about this. Thanks for the correction
and the reference. Thanks for the windows port of this function too!
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
ing a bunch of corrections. Will this
not break the use of the macro for platforms lacking geteuid though?
If so, the following patch should fix this.
>From 7b0c5cb00ba3a294ce1919fded4dab2816919c03 Mon Sep 17 00:00:00 2001
From: Ben Walton
Date: Sun, 4 Dec 2011 10:54:31 -0500
Subject: [PA
ks for the tweaks...sorry for requiring them of you still.
I've also noted the reasons for the tweaks and will attempt to provide
better patches in the future.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
Provide a module that tests the functionality of sethostname().
Signed-off-by: Ben Walton
---
ChangeLog |6 ++
modules/sethostname-tests | 13 +
tests/test-sethostname.c | 117 +
3 files changed, 136 insertions(+), 0
Define sethostname on platforms that do not provide the declaration.
Provide a function for platforms that lack it. The general handling
of the provided function is to simply return -1 and set errno to
ENOSYS. A specific handler is provided for Minix.
Signed-off-by: Ben Walton
---
ChangeLog
Ensure that sethostname is accounted for within the unistd module.
Signed-off-by: Ben Walton
---
ChangeLog |9 +
lib/unistd.in.h | 25 +
m4/unistd_h.m4 |7 +--
modules/unistd |3 +++
4 files changed, 42 insertions(+), 2 deletions
The sethostname module will rely on this code too, so make it a
separate function.
Signed-off-by: Ben Walton
---
ChangeLog |5 +
m4/gethostname.m4 |9 +++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 272dded..eee02b6
Hi Bruno,
The following series incorporates the feedback you provided and also
adds a test module for sethostname. As this function requires
privilege to test, I chose to bail out if it didn't seem that the
privilege was held.
How does the series look now?
Thanks
-Ben
ith this, please fill in the form in the file
> gnulib/doc/Copyright/request-assign.future (if you foresee making
> more contributions to Gnulib) or
> gnulib/doc/Copyright/request-assign.changes (if this will be your
> only contribution) and send it to the FSF.
I've sent the
Ensure that sethostname is accounted for within the unistd module.
Signed-off-by: Ben Walton
---
lib/unistd.in.h | 24
m4/unistd_h.m4 |7 +--
modules/unistd |3 +++
3 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/lib/unistd.in.h b/lib
Define sethostname on platforms that do not provide the declaration.
Provide a function for platforms that lack it. The general handling
of the provided function is to simply return -1 and set errno to
ENOSYS. A handler is provided for Minix.
Signed-off-by: Ben Walton
---
doc/glibc-functions
Hi Bruno,
> Cool. Yes, please, show it!
Ok, it's following this reply. I'm sure that it's not ready for
inclusion just yet, but I'll polish it until it is using the feedback
I receive. As always, comments and criticisms welcomed.
> It can also be done later by someone else who is more familia
The sethostname module will rely on this code too, so make it a
separate function.
Signed-off-by: Ben Walton
---
m4/gethostname.m4 |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/m4/gethostname.m4 b/m4/gethostname.m4
index 8ea6329..784e40a 100644
--- a/m4
this? Is this a case where
REPLACE_SETHOSTNAME would be warranted?
If it would help and people wouldn't mind, I'll post the current patch
series for review so that if I'm off track I can correct before
implementing the remaining bits (including the tests).
Thanks
-Ben
--
Ben Wal
name.file, followed by a newline.
>
> - On other systems, just use errno = ENOSYS; as fallback.
>
> Can you implement this?
I'm going to give it a shot. As long as you're not expecting it
'tomorrow', I'll work on it over the next few days.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
modification of the inetutils gnulib code until
the proper version is implemented?
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
't mind resubmitting.
Comments and criticisms are welcomed.
Thanks
-Ben
>From 0dd943363bbd4d2884b8851ccbd703fee5eb6353 Mon Sep 17 00:00:00 2001
From: Ben Walton
Date: Sat, 19 Nov 2011 23:13:08 +0100
Subject: [PATCH] unistd: declare sethostname when required
* m4/unistd_h.m4 (gl_UNISTD_H): Check
ection a bit to make it
> a bit less discouraging.
Done. I think this is less discouraging now and it also provides
information about how to determine the licenses of the modules.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
bit less discouraging.
Ok, that sounds good to me.
> I looked for other similar pages, that the gnulib documentation
> could point to. The OpenCSW page seemed by far the best.
Glad to hear it! :)
I'll bump this thread again after making the suggested changes.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
hod, you don't need e.g. a HP-UX
> machine to find which modules are needed for HP-UX).
Ok. I'll see about a patch for the docs in this area too.
Your feedback is appreciated.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
ssignment paperwork.
Perfect. Thanks for that.
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
anks
-Ben
[1] http://wiki.opencsw.org/adding-gnulib
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
/modules/openat
@@ -5,6 +5,7 @@ Files:
lib/at-func.c
lib/openat.c
lib/openat-priv.h
+m4/lstat.m4
m4/openat.m4
m4/mode_t.m4
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
Sorry for the noise.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
successful.
I hope this helps.
All other tests passed for me.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
Excerpts from Jim Meyering's message of Wed Mar 23 05:05:14 -0400 2011:
I also know that gnulib is used in cvsps and tmpwatch as I helped
integrate it in both cases.
Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
0001-Add-cvsp
roblem? I'll wait for confirmation before pushing.
I just built 8.7 (I skipped from 8.4 -> 8.8) with my build script and
tested it. It works correctly, so I'd say that yes, the problem was
introduced in 8.8. This was on sparc, I didn't make the verification
on i386, but I will i
Excerpts from Bruno Haible's message of Sat Mar 12 07:11:51 -0500 2011:
Hi Bruno,
> I'm applying this patch:
Thanks for saving me the legwork on this. The patch does correct the
problem. I appreciate the quick turnaround on this.
Thanks
-Ben
--
Ben Walton
Systems Progr
Excerpts from Jim Meyering's message of Sat Feb 27 03:15:59 -0500 2010:
> > Would it be easier to first auto* the project and then add gnulib?
>
> Yes.
Ok, that's what I thought. Thanks for the confirmation.
-Ben
signature.asc
Description: PGP signature
Hi All,
I'm wondering whether its feasible to use gnulib in a project that
doesn't use autoconf/automake? Would it be easier to first auto* the
project and then add gnulib?
Thanks
-Ben
Hi All,
I updated my gnulib git repo tonight before patching it into some
source and discovered that gnulib-tool was broken by commit 5b1da95 (I
bisected). I've verified this breakage on Solaris 8 - 10.
--snip--
bwalton @ build8x : ~/gnulib
$ uname -a
SunOS build8x 5.8 Generic_117351-61 i86pc i
wasn't
covered.
This patch resolved those test failures for me. Please let me know if
there is more information required or if my submission isn't up to
snuff for any reason.
Thanks
-Ben
>From a06d449a84a393d2d764a0d7871840cb99f665d7 Mon Sep 17 00:00:00 2001
From: Ben Walton
Dat
45 matches
Mail list logo
