Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

2012-09-04 Thread Jim Meyering
(2 < len && v[len - 1] == '/') >>> + while (2 < len && v[len - 2] == '/') >>> +--len; > > I think that this would do the right thing, though (notice that it > strips all but 1 slash for anything longe

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

2012-09-04 Thread Jim Meyering
Eric Blake wrote: > On 09/04/2012 04:57 AM, Eric Blake wrote: >>> * lib/fts.c (fts_open): Upon initialization, if a name ends in two >>> or more slashes, trim all but the final one. But if a name consists >>> solely of two or more slashes, reduce it to "//", not to "/". >>> >> >> For two slashes,

Re: [PATCH] fts: when there is no risk of overlap, use memcpy, not memmove

2012-09-04 Thread Jim Meyering
Stefano Lattarini wrote: > On 09/04/2012 12:21 PM, Jim Meyering wrote: >> While investigating the rm-vs-slash-decorated-symlink-to-dir problem, >> I noticed this: >> >> From 9322cc5db3a6efe4c19f274512a28767872384e4 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

2012-09-04 Thread Jim Meyering
Jim Meyering wrote: ... > Subject: [PATCH] fts: reduce two or more trailing spaces to just one, usually Glad I noticed the typo in that summary before pushing: s/spaces/slashes/

[PATCH] fts: reduce two or more trailing spaces to just one, usually

2012-09-04 Thread Jim Meyering
lic links With the change below and a trivial don't-trim-trailing-slashes adjustment to remove.c, it does this: $ env rm -r s/ rm: cannot remove 's/': Not a directory >From 99376a06eed07ded17919384cf1d633e43ad1bd0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tu

[PATCH] fts: when there is no risk of overlap, use memcpy, not memmove

2012-09-04 Thread Jim Meyering
While investigating the rm-vs-slash-decorated-symlink-to-dir problem, I noticed this: >From 9322cc5db3a6efe4c19f274512a28767872384e4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 4 Sep 2012 11:31:09 +0200 Subject: [PATCH] fts: when there is no risk of overlap, use memcpy, not memm

Re: stat-time.h vs. -Waggregate-return

2012-09-02 Thread Jim Meyering
Jim Meyering wrote: > Simon Josefsson wrote: >> Eric Blake writes: >>> On 08/02/2012 04:49 PM, Paul Eggert wrote: >>>> On 08/02/2012 03:40 PM, Eric Blake wrote: >>>>> /* Store *ST's access time into *TS. */ >>>>> static inline void

encapsulating --enable-gcc-warnings [Re: [PATCH] build: work with new glibc when not optimizing

2012-09-02 Thread Jim Meyering
[cc'ing bug-gnulib] This started with a useful coreutils patch by Eric, http://thread.gmane.org/gmane.comp.gnu.coreutils.general/3164 The thing is, it belongs in nearly every project that also provides the configure-time --enable-gcc-warnings option: Mike Frysinger wrote: > On Sat, Sep 1, 20

Re: bison 2.6.2 contains stale info files

2012-09-01 Thread Jim Meyering
Akim Demaille wrote: ... > So, Karl, Jim, and others, would you accept that gendocs.sh > stopped generating a compressed tarball of split info files, > but would rather ship a compressed --no-split file? Sounds fine to me, but gendocs.sh is Karl's baby ;-)

Re: diffutils test failure on nixos/hydra's solaris build

2012-08-30 Thread Jim Meyering
Paul Eggert wrote: > On 08/28/2012 05:13 AM, Jim Meyering wrote: >> Since that same test passes just fine on a Solaris 10 system >> to which I have access, I'm going to ignore it for now. > > The same test also passes on a Solaris 11 system > that I have access

diffutils test failure on nixos/hydra's solaris build

2012-08-28 Thread Jim Meyering
Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 28 Aug 2012 13:49:37 +0200 Subject: [PATCH] tests: test-vc-list-files-git.sh: skip if git is not available The real failure was here: FAIL: test-localeconv (exit: 262) = test

'_Noreturn' not at beginning of declaration

2012-08-23 Thread Jim Meyering
7;t use the stdnoreturn module, not even indirectly. >From 6564bc029a14c66233cc182f715bd11effac3187 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 23 Aug 2012 22:02:39 +0200 Subject: [PATCH] xstrtol.h: avoid "_Noreturn is not at beginning of declaration" warning * lib/

Re: [PATCH] maint.mk: avoid redundant file name in message

2012-08-20 Thread Jim Meyering
Eric Blake wrote: > $(_sc_search_regexp) already prefixes its errors with $(ME), so > failure on one of these rules looked like: > > maint.mk: maint.mk: replace strcmp calls above with STREQ/STRNEQ > > * top/maint.mk (sc_prohibit_strcmp, sc_unmarked_diagnostics) > (sc_prohibit_defined_have_decl_tes

Re: bug#11150: getlogin test failure

2012-08-13 Thread Jim Meyering
Andrew Warshall wrote: >I'm seeing the same issue with 8.18. Apparently xterm doesn't write >to /var/run/utmp by default, so getlogin () fails with errno == >ENOENT. However, isatty (0) still succeeds. The attached patch >(based on, though not interchangeable with, the sed command a

Re: [PATCH] count-leading-zeros: new module

2012-08-11 Thread Jim Meyering
Eric Blake wrote: > I needed gcc's clz to determine the most significant bit of a > number (useful for things like truncating to a power of 2), > and was surprised it is not a standardized function (the > opposite direction of finding the least significant bit is ... > +/* Expand the code which com

Re: maintainer-makefile: quoting

2012-08-06 Thread Jim Meyering
Simon Josefsson wrote: > Jim Meyering writes: > >> Adding quotes is the solution, but you must then remove >> one layer of backslash quoting: > > Of course, thank you. What I was mostly surprised about was that nobody > else had run into this. I suppose bash doesn

Re: maintainer-makefile: quoting

2012-08-06 Thread Jim Meyering
Simon Josefsson wrote: > I got this error from syntax-check: > > jas@latte:~/src/libidn$ make sc_vulnerable_makefile_CVE-2012-3386 > vulnerable_makefile_CVE-2012-3386 > /bin/sh: 2: Syntax error: "(" unexpected > make: *** [sc_vulnerable_makefile_CVE-2012-3386] Fel 2 > jas@latte:~/src/libidn$ > > Th

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Jim Meyering wrote: > >> Jim Meyering wrote: >> >>> Paul Eggert wrote: >>>> On 08/05/2012 06:27 AM, Jim Meyering wrote: >>>> >>>>> * configure.ac: Disable -Wmissing-declarations to avoid warnings >>>

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Jim Meyering wrote: > >> Paul Eggert wrote: >>> On 08/05/2012 06:27 AM, Jim Meyering wrote: >>> >>>> * configure.ac: Disable -Wmissing-declarations to avoid warnings >>>> from gnulib's newly extern-inline func

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Jim Meyering wrote: > Paul Eggert wrote: >> On 08/05/2012 06:27 AM, Jim Meyering wrote: >> >>> * configure.ac: Disable -Wmissing-declarations to avoid warnings >>> from gnulib's newly extern-inline functions. >> >> This shouldn't be

Re: new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
Paul Eggert wrote: > On 08/05/2012 06:27 AM, Jim Meyering wrote: > >> * configure.ac: Disable -Wmissing-declarations to avoid warnings >> from gnulib's newly extern-inline functions. > > This shouldn't be needed if your compiler is sufficiently > new, because

new extern inline provokes -Wmissing-declarations warnings

2012-08-05 Thread Jim Meyering
t;real soon": >From 74f52eafbc39a6f9a5bcbd7266d60e3f1052d7e8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 5 Aug 2012 10:42:53 +0200 Subject: [PATCH] build: temporarily disable -Wmissing-declarations * configure.ac: Disable -Wmissing-declarations to avoid warnings from gnulib&#x

Re: [PATCH] maint.mk: forbid exit(-1)

2012-08-05 Thread Jim Meyering
ugh to find strings matching /error ([^,]*)/ that we should not have to exempt them in every gnulib-using package, so I've exempted them like this: >From 231deed98fe9cf23fbe3c9a39f0f1d288a46acd4 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 5 Aug 2012 11:19:19 +0200 Subject: [PATCH] maint.mk: sc_

Re: [PATCH] gnumakefile: better interaction with Automake-NG

2012-08-04 Thread Jim Meyering
Stefano Lattarini wrote: > On 08/03/2012 10:14 AM, Stefano Lattarini wrote: >> On 08/02/2012 07:49 PM, Eric Blake wrote: >>> On 08/02/2012 11:00 AM, Eric Blake wrote: On 08/02/2012 10:53 AM, Stefano Lattarini wrote: > * modules/gnumakefile [Makefile.am]: The makefiles generated by > Au

Re: stat-time.h vs. -Waggregate-return

2012-08-03 Thread Jim Meyering
documentation/understand and experiment with each of those options. Having multiple tags will allow packages to customize filtering, e.g., to enable all c++-related warnings, but to exclude warnings that are deemed obsolescent or too strict. Suggestions welcome. >From 51d2b564fe80e603f4fb801b72

Re: maint.mk: improve the release procedure

2012-08-03 Thread Jim Meyering
Akim Demaille wrote: > There is still the uploading step which is not bound to a make target. I > would remove the emit_upload_command completely, and instead mention the > upload target in README-release, including the announcement step, WDYT? Hi Akim, I like the added automation. Thanks. AC

Re: maint.mk: a "release-commit" wrapper to do-release-commit-and-tag

2012-08-01 Thread Jim Meyering
Akim Demaille wrote: > Le 1 août 2012 à 10:59, Bruno Haible a écrit : > >> Akim Demaille wrote: >>> I used […] for default values, by habit (e.g., ./configure), >>> but I can restore to (default: …) if you prefer. >> >> This notation […] is not widespread enough, IMO, that people would >> immediate

Re: ls-mntd-fs.m4 fails to detect how to read list of mounted filesystems on Minix

2012-07-30 Thread Jim Meyering
Richard Yao wrote: > On 07/28/2012 02:13 AM, Richard Yao wrote: >> I used the following ISO to install Minix in KVM: >> >> http://www.minix3.org/iso/minix3_2_1_ide_20120622_f8c6b27.iso.bz2 >> >> coreutils 8.16 and findutils 4.2.33 both fail to build on Minix with the >> following configure error:

Re: [PATCH 2/4] README-release: shorten the circuit to post a news

2012-07-30 Thread Jim Meyering
uted changes to this release: Aharon Robbins (2) Jim Meyering (12) Paolo Bonzini (3) Paul Eggert (7) If say one or two like the idea and no one objects, you're welcome to add it one way or another. As far as I'm concerned, it can be the default, but it may

Re: [PATCH 2/4] README-release: shorten the circuit to post a news

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > * top/README-release: Point directly to the news submission form. ... Looks fine. One suggestion, to save a line: > diff --git a/top/README-release b/top/README-release > index 15110d4..1c0f760 100644 > --- a/top/README-release > +++ b/top/README-release > @@ -72,17 +72,17

Re: [PATCH 4/4] maint.mk: use silent-rules support from Automake

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > * top/maint.mk (news-check, vc-diff-check, announcement) > (no-submodule-changes, alpha beta stable, release-prep) > (web-manual, update-copyright): Use $(AM_V_GEN) and $(AM_V_at). ACK modulo a consistency nit: > diff --git a/top/maint.mk b/top/maint.mk > index fe14a80..37

Re: [PATCH 3/4] maint.mk: provide a web-manual-update target

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > * top/maint.mk: here. > * top/README-release: Use it to simplify the web manual update step. Good idea. ACK.

Re: [PATCH 0/4] maint.top: simplify release procedure

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > The following changes aim at simplifying a bit the release procedure. > And to make more rules silent. > > Jim, I thought you had installed your simplification patch, but I > can't see it. Do you want me to install it? I went to lunch :-) Pushed now.

Re: [PATCH 1/4] gnu-web-doc-update: fix --help

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > * build-aux/gnu-web-doc-update: The information "top level" was written > twice. ACK

Re: maint.mk: absolute VPATH build fix

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > Le 30 juil. 2012 à 09:08, Jim Meyering a écrit : > >> Saving the commit message in a variable should do what we want: >> >> msg=$$(emit-commit-log) || exit 1; \ >> (cd $(srcdir) && $(VC) commit -m

Re: maint.mk: absolute VPATH build fix

2012-07-30 Thread Jim Meyering
Akim Demaille wrote: > Le 29 juil. 2012 à 20:11, Jim Meyering a écrit : > >>> - $(emit-commit-log) > .ci-msg >>> - $(VC) commit -F .ci-msg -a >>> - rm .ci-msg >>> + $(emit-commit-log) \ >>> + | (cd $(srcdir) && $(VC) commit

Re: maint.mk: absolute VPATH build fix

2012-07-29 Thread Jim Meyering
Akim Demaille wrote: > There's another one. > > This rule is vastly verbose (no @). Is it on purpose? > Also, can't we use AM_V_GEN instead of @? That's helpful, > on occasions, when debugging (ahem…). I would welcome patches to use AM_V_GEN more consistently. > commit d32964aad95a7d46fb0a8fa4a

Re: maint.mk: absolute VPATH build fix

2012-07-29 Thread Jim Meyering
Akim Demaille wrote: > Le 29 juil. 2012 à 13:24, Akim Demaille a écrit : > >>> I prefer to write it this way, putting the less-likely code in the >>> indented clause: (or testing $? != 0) >>> >>> $? >>> and die "$ME: $qcmd had unexpected exit code or signal ($?)\n" >> >> Hi Jim! >> >

Re: maint.mk: absolute VPATH build fix

2012-07-29 Thread Jim Meyering
uilddir). > > diff --git a/ChangeLog b/ChangeLog > index 378c405..51f4a76 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,9 @@ > +2012-07-29 Akim Demaille > + > + maint.mk: absolute VPATH build fix > + * top/maint.mk (gpg_key_ID): Help git find .git

Re: maint.mk: absolute VPATH build fix

2012-07-28 Thread Jim Meyering
Akim Demaille wrote: > It looks like I'm having problems to write from @lrde. Sorry > about duplicates if they finally arrive. > > commit d7d165a2386db7ba2bf44087aef9dd097bc2f8fd > Author: Akim Demaille > Date: Sat Jul 28 12:40:53 2012 +0200 > > maint.mk: absolute VPATH build fix > > *

[PATCH] maint.mk: new rule: refresh-gnulib-patches

2012-07-27 Thread Jim Meyering
FYI, First, here's a patch to maint.mk. To give you an idea of what this does, I've included the induced patch for coreutils below. >From 8394dc6b446e745b430f880dd08fb664379cdbe0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 27 Jul 2012 12:12:42 +0200 Subject: [PATCH]

Re: [Bug-tar] Documentation bug

2012-07-27 Thread Jim Meyering
Sergey Poznyakoff wrote: > Jim Meyering ha escrit: >> (BTW, the second sentence seems incorrect: >> I saw no makefile rule for "ChangeLog" in tar.) > > It is in Make.rules, which is imported from Paxutils. Thanks for the info. This particular working director

Re: [Bug-tar] Documentation bug

2012-07-27 Thread Jim Meyering
Paul Eggert wrote: > On 07/26/2012 01:49 PM, Eric Blake wrote: >> can we always count on the vc-dwim boilerplate to >> be the same to automatically prune it from gitlog-to-changelog? > > Probably not, but we can keep a catalog of all of them, > surely, assuming this problem persists indefinitely, >

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... >> You can make it easier for us to process your coreutils patches by > separating >> them into conceptually-related sets, with commit log entries following >> HACKING's guidelines. > > OK, will try in futur... > > Would you accept git pull requests? Sure, but please als

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> However, note that you're using an old version of coreutils. In the > latest, su.c >> has been removed so you can drop the patches to that file. > > Huh? 8.17 is old? It's the latest I could get and still has src/su.c. > Anyway, that patch isn't needed for NonStop anyway,

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> From: Jim Meyering [mailto:j...@meyering.net] >> Sent: Friday, July 20, 2012 3:48 PM >> To: Joachim Schmitz >> Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric > Blake'; >> 'Schmitz, Joachim

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I just saw that my patch removed 2 functions more than your's, mine also > removes cache_stat_ok() and is_nondir_lstat(). > Intention? Used where? Here's the patch: >From c1263bb95e8ff84e819753c9050b96d16441aa81 Mon Sep 17 00:00:00 2001 From: Joachim Schmitz Date: Fr

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I just saw that my patch removed 2 functions more than your's, mine also > removes cache_stat_ok() and is_nondir_lstat(). > Intention? Used where? Hah! I should have temporarily defined-away "inline" to be sure I'd removed all of them -- then gcc warns about each defi

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> From: Jim Meyering [mailto:j...@meyering.net] >> Sent: Friday, July 20, 2012 2:35 PM >> To: Joachim Schmitz >> Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric > Blake'; >> 'Schmitz, Joachim

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I've disable a bit of apparently dead code in src/remove.c ... > /usr/local/bin/diff -EBbu ./src/remove.c.orig ./src/remove.c > --- ./src/remove.c.orig 2012-05-01 15:55:08 -0500 > +++ ./src/remove.c2012-06-18 10:06:04 -0500 > @@ -88,6 +88,7 @@ >return st;

Re: [PATCH 1/2] gnu-web-doc-update: check the requirements.

2012-07-19 Thread Jim Meyering
Akim Demaille wrote: > * build-aux/gnu-web-doc-update (find_tool): Import from bootstrap. > ($CVS, $CVSU, $GIT, $RSYNC, $XARGS): New. > --- > ChangeLog| 6 > build-aux/gnu-web-doc-update | 68 > +++- > 2 files changed, 61 insertion

Re: [PATCH 2/2] gnu-web-doc-update: fix error messages

2012-07-19 Thread Jim Meyering
Akim Demaille wrote: > * build-aux/gnu-web-doc-update: Don't pass $ME to die. > --- > ChangeLog| 3 +++ > build-aux/gnu-web-doc-update | 6 +++--- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 0913c0d..40ada21 100644 > --- a/C

Re: test-getlogin_r is annoyingly random

2012-07-19 Thread Jim Meyering
Richard W.M. Jones wrote: > When building in Koji (the Fedora build system), the test is usually > skipped: > > Skipping test: stdin is not a tty. > SKIP: test-getlogin_r > > except when it doesn't skip and instead it fails: > > test-getlogin_r.c:62: assertion failed > /bin/sh: line 5: 110

Re: [PATCH] maint.mk: minor simplication.

2012-07-17 Thread Jim Meyering
Akim Demaille wrote: > Nothing big here, just some very minor factoring. > > * top/maint.mk (_sc_excl): Use $(or...) instead of $(if...) > for default values. ... > - $(if $(exclude_file_name_regexp--$@),$(exclude_file_name_regexp--$@),^$$) > + $(or $(exclude_file_name_regexp--$@),^$$) Nice. Th

Re: [PATCH] gitlog-to-changelog: VPATH build issues.

2012-07-15 Thread Jim Meyering
Akim Demaille wrote: > Le 15 juil. 2012 à 16:48, Akim Demaille a écrit : > >> This patch should help people who, like me, sometimes build >> from /tmp for instance, while the sources are in /home. > >> + --git-dir=DIR set the path to the Git repository. > > Actually, I hesitated between --git-di

Re: README-release patch

2012-07-15 Thread Jim Meyering
Reuben Thomas wrote: > Ping? My other (rejected) patch has been responded to, but not this > one. Sorry to be a pain, but I'm working on a (per-project) patch to > README-release, and I'd like to get this patch accepted or rejected so > I know what I'm basing my per-project patch on! > > On 13 July

Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks

2012-07-15 Thread Jim Meyering
Bruno Haible wrote: > Eric Blake wrote: >> Should we get rid of the >> sanity checks that use #error when a macro is undefined, in order >> to reduce the number of exemptions? > > I agree, this would be useful for those source files that are always > taken as an entire module from gnulib. I wouldn

[PATCH 1/2] maint.mk: add leading "@" to quiet new "make syntax-check" rule

2012-07-15 Thread Jim Meyering
54aaa6a4b8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 15 Jul 2012 14:40:29 +0200 Subject: [PATCH 1/2] maint.mk: add leading "@" to quiet new "make syntax-check" rule * top/maint.mk (sc_prohibit_defined_have_decl_tests): Add "@". --- ChangeLog|

Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks

2012-07-13 Thread Jim Meyering
Eric Blake wrote: > Based on Karel's report, we might as well enforce a syntax check > to help avoid future problems. > https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html > > * top/maint.mk (sc_prohibit_undefined_have_decl_tests): New rule. > * cfg.mk > (exclude_file_name_regexp--sc

Re: Reorder a couple of steps in README-release

2012-07-13 Thread Jim Meyering
Reuben Thomas wrote: > The attached patch simply moves a paragraph so that the step of > pushing the final (NEWS-updating) commits to git happens before > uploading any release files. Hi Reuben, Thanks for the suggestion, but I deliberately chose to upload the tarball(s) before pushing the tag an

Re: [PATCH] maint: enable the sc_avoid_if_before_free syntax-check

2012-07-12 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> > Nowadays little code remains that is written for K&R C, and few minds >> > program >> > for K&R C. Therefore the "if before free" cases that are remaining are >> > more likely to be intentional than before. >> >> If only that were true. I've just removed seve

Re: [PATCH] maint: enable the sc_avoid_if_before_free syntax-check

2012-07-12 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> Bruno, is it ok to remove the one in lib/clean-temp.c, below? > > No, it's better if the 'if (old_array != NULL)' stays there. It reminds > the maintainer of the code of the two possible cases. I'm surprised you think it's worth keeping that test solely as a rem

Re: add --match argument to git-version-gen

2012-07-11 Thread Jim Meyering
Andy Wingo wrote: > On Sat 07 Jul 2012 22:42, Jim Meyering writes: > >>> - --prefix prefix of git tags (default 'v') >>> + --prefix prefix of git tags to strip from version (default 'v') >>> + --match pattern for git

[PATCH] maint: enable the sc_avoid_if_before_free syntax-check

2012-07-11 Thread Jim Meyering
ep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 11 Jul 2012 17:25:27 +0200 Subject: [PATCH] maint: enable the sc_avoid_if_before_free syntax-check rule * cfg.mk (local-checks-to-skip): Enable sc_avoid_if_before_free. (if_before_free_offenders_): Define. (if_before_free_basename_re_): Define

Re: bug#11905: Unnecessary '#define unix' in src/s/aix4-2.h

2012-07-11 Thread Jim Meyering
Paul Eggert wrote: > On 07/10/2012 04:25 PM, Glenn Morris wrote: >> I suspect that Gnulib already has the AIX >> case covered (via "__unix"?), so that src/s/aix4-2.h no longer needs to >> define "unix". > > Yes, that sounds right. I have started to fix this by > installing the following patch into

Re: request to relax license of 'stat-time'

2012-07-10 Thread Jim Meyering
Eric Blake wrote: > Libvirt would like to use lib/stat-time.h to portably get at nanosecond > timestamps from an LGPLv2+ license; but this file is currently licensed > LGPLv3+. Any objections to relaxing the license, particularly since > POSIX 2008 guarantees that stat() should be returning this i

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-10 Thread Jim Meyering
Akim Demaille wrote: > Le 10 juil. 2012 à 12:05, Jim Meyering a écrit : > >> Akim Demaille wrote: >> >>> Le 10 juil. 2012 à 10:14, Jim Meyering a écrit : >>> >>>>> + case $* in >>>>> +*$nl*) me_=$(printf "$me"|tr

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-10 Thread Jim Meyering
Akim Demaille wrote: > Le 10 juil. 2012 à 10:14, Jim Meyering a écrit : > >>> + case $* in >>> +*$nl*) me_=$(printf "$me"|tr "$nl|" '??') >> >> Is it worth testing for both $nl and '|' ? > > I tried to kee

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-10 Thread Jim Meyering
Akim Demaille wrote: > Here is an updated proposal, that was taking into account > several comments made last week. Looks fine, modulo a question and test artifacts: Thanks! ... > -warn() > +# warnf_ FORMAT-STRING ARG1... > +warnf_ () > { > - for i > - do > -echo "$i" > - done | sed -e "s

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-09 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 14:44, Jim Meyering a écrit : >> No, but if you think it's better, somehow... >> I meant that warnf would be a very thin wrapper around printf: >> >>$ printf '%s\n' a b c >>a >>b >

[PATCH] maint.mk: add sc_vulnerable_makefile_CVE-2012-3386

2012-07-09 Thread Jim Meyering
To accompany automake's just-fixed "make distcheck" vulnerability, http://thread.gmane.org/gmane.comp.sysutils.automake.patches/8572 here's a syntax-check rule like the one for CVE-2009-4029: >From 48fe477c9008efadab8cf8c0c3240d824c12a8b9 Mon Sep 17 00:00:00 2001 F

[PATCH] maint.mk: _sc_search_regexp, sc_vulnerable_makefile_CVE-2009-4029: fix

2012-07-09 Thread Jim Meyering
I noticed that the CVE-2009-4029-detecting rule wasn't working. Surprised to find that *two* bugs were behind the failure. >From b38d59184505f6119a5ffbf3b4a068fd7a9b8fe8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 9 Jul 2012 16:11:34 +0200 Subject: [PATCH] maint.mk: _sc_searc

Re: add --match argument to git-version-gen

2012-07-07 Thread Jim Meyering
Andy Wingo wrote: > On Fri 06 Jul 2012 17:45, Jim Meyering writes: > >> How about writing a function -- with description similar to the comments >> you've added below -- and doing something like the following? >> Then we should be able to avoid that duplication. >

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Thien-Thi Nguyen wrote: > () Akim Demaille > () Fri, 6 Jul 2012 16:40:37 +0200 > >But we have to worry about ',' in $me, which is $0, not >its basename. Do you want me (Akim, not the variable) >to change me (the variable, not Akim; not that I am >immutable) to basename and use /

Re: add --match argument to git-version-gen

2012-07-06 Thread Jim Meyering
Andy Wingo wrote: > On Fri 06 Jul 2012 16:32, Jim Meyering writes: > >> It'd be nice to say "why" this change is useful. >> At worst, just refer to the URL for this mailing list thread. > > OK. > >> Protecting against envvars by those names is a g

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 16:09, Jim Meyering a écrit : > >> You're welcome to leave the pipe-to-sed. >> Worrying about an extra process when processing a diagnostic >> is probably a pre-optimization anyhow. Besides, then >> we don't have t

Re: add --match argument to git-version-gen

2012-07-06 Thread Jim Meyering
Andy Wingo wrote: > On Fri 06 Jul 2012 15:56, Stefano Lattarini > writes: > >> On 07/06/2012 03:53 PM, Andy Wingo wrote: >>> >>> @@ -121,6 +126,9 @@ if test -z "$tarball_version_file"; then >>> exit 1 >>> fi >>> >>> +echo $match >>> >> Huh? Forgotten debugging code perhaps? >> >>> +match=

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 15:21, Stefano Lattarini a écrit : > >> Why not shave off the extra forks here? >> >>printf "$me: $warnf_format_" "$@" >&2 >> >> This shouldn't cause problems, unless '$me' contains '%' or '\' characters. > > Or end of line. Elsewhere, where I use simil

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 14:44, Jim Meyering a écrit : > >> No, but if you think it's better, somehow... >> I meant that warnf would be a very thin wrapper around printf: >> >>$ printf '%s\n' a b c >>a >>b &

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 14:24, Jim Meyering a écrit : > >> Akim Demaille wrote: >>> Le 6 juil. 2012 à 13:56, Jim Meyering a écrit : >>> >>>> Um... this is a good reason to post an adjusted patch. >>>> What I meant was that i

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 13:56, Jim Meyering a écrit : > >> Um... this is a good reason to post an adjusted patch. >> What I meant was that it is fine to continue to print that diagnostic >> on one line, but not using echo; using the new "warn".

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 12:01, Jim Meyering a écrit : > >> Akim Demaille wrote: >> >>> It is also very useful to have a single command that issues >>> several lines. This is the case here for instance: >> >> I would debate the &q

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Hi Jim! > > Le 6 juil. 2012 à 11:43, Jim Meyering a écrit : > >> Thanks for the patch. >> >> Those all look like improvements, but I'd prefer that >> you change the name s/stderr/warn/: "stderr" is not normally >> us

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-06 Thread Jim Meyering
Akim Demaille wrote: > Independently of the other thread we're having about set -e, > I had refactored bootstrap a bit. > -8<--- > > * build-aux/bootstrap (stderr, die): New. > Use them. > --- > build-aux/bootstrap | 94 > ++--- > 1 file changed, 47

Re: FYI: do-release-commit-and-tag: fix typo

2012-07-05 Thread Jim Meyering
Akim Demaille wrote: > Le 5 juil. 2012 à 15:24, Akim Demaille a écrit : > >> Hi friends, >> >> I just installed this. >> >> # simple check: no question marks on line 3 of NEWS >> -test "$(sed -n 3p NEWS)" = "$noteworthy_stub" \ >> +test "$(sed -n 3p NEWS)" != "$noteworthy_stub" \ >> || die 'line

Re: FYI: do-release-commit-and-tag: fix typo

2012-07-05 Thread Jim Meyering
Akim Demaille wrote: > Hi friends, Hi Akim, > I just installed this. > > Subject: [PATCH] do-release-commit-and-tag: fix typo In the future, please post a heads-up patch before you push, in case someone sees a problem. ... > --- a/build-aux/do-release-commit-and-tag > +++ b/build-aux/do-release

Re: bug#11843: acknowledged by developer (date -s with locale-dependent input: notabug)

2012-07-04 Thread Jim Meyering
Jim Meyering wrote: > Bruno Haible wrote: >> Jim Meyering wrote: >>> +static inline unsigned char to_uchar (char ch) { return ch; } >> >> For the use of 'inline', one needs this too: >> +++ m4/parse-datetime.m4 Wed Jul 4 10:04:36 2012 >

Re: bug#11843: acknowledged by developer (date -s with locale-dependent input: notabug)

2012-07-04 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> +static inline unsigned char to_uchar (char ch) { return ch; } > > For the use of 'inline', one needs this too: > +++ m4/parse-datetime.m4 Wed Jul 4 10:04:36 2012 > + AC_REQUIRE([AC_C_INLINE]) Thanks, Bruno. H

Re: bug#11843: acknowledged by developer (date -s with locale-dependent input: notabug)

2012-07-04 Thread Jim Meyering
peter evans wrote: > Thank you for closing this as "not a bug". > > So it is not a bug that date is unable to parse its own output in > arbitrary locales. > Indeed, it would "not be a bug" if it stopped and complained about > it. That would be > perfectly acceptable. > > "date" however, goes one be

[PATCH] bootstrap: do not require now-removed build-aux/missing

2012-07-03 Thread Jim Meyering
In preparing for a grep release and using the latest from gnulib, I was surprised to see that bootstrap would fail without printing a diagnostic. >From d0ea2a12f6fb377f930886d404f3dfc2a732537d Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 3 Jul 2012 22:22:49 +0200 Subject: [PA

Re: fsusage.c fails to build on GNU

2012-07-02 Thread Jim Meyering
when STAT_STATFS2_FRSIZE > is defined. Hi Ludo, Thanks for the report and suggested fix. Can you easily see if this does the job? >From 3e26070ccd633da280ade87c8441da52fb957473 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 2 Jul 2012 22:26:44 +0200 Subject: [PATCH] fsusage: avoid

Re: minimum autoconf version

2012-07-02 Thread Jim Meyering
Paul Eggert wrote: > On 07/01/2012 04:40 PM, Bruno Haible wrote: >> I would therefore propose (b), that is, to bump the required Autoconf >> version in the DEPENDENCIES file and gnulib-tool to 2.64. > > Given your description of the hassles involved in supporting > older Autoconf versions, this see

Re: new module: relpath

2012-06-22 Thread Jim Meyering
Akim Demaille wrote: > Before addressing other issues in my proposal, I would like to know > if everybody agrees that being lgpl, being xalloc/error free, etc. > is irrelevant for relpath? Hi Akim, You've hit the nail on the head. Making this new module and all of its dependents xalloc/error-free

Re: parse-duration-tests: make it build

2012-06-21 Thread Jim Meyering
Bruce Korb wrote: > On 06/21/12 09:22, Bruce Korb wrote: >> On 06/21/12 08:16, Jim Meyering wrote: >>> >>> Maybe just try again? > > make[1]: Leaving directory `/old-home/gnu/proj/gnulib/t' > make: *** No rule to make target `sc_maint'. Stop. That r

Re: parse-duration-tests: make it build

2012-06-21 Thread Jim Meyering
Bruce Korb wrote: > On 06/21/12 09:33, Jim Meyering wrote: >> Bruce Korb wrote: >>> On 06/21/12 08:16, Jim Meyering wrote: >>>> >>>> Maybe just try again? >>> >>> My push-ability is still disabled. Can this be fixed, please? >&g

[PATCH] maint: disable the strncpy prohibition

2012-06-21 Thread Jim Meyering
Make our "make sc_maint" rule pass once again: >From 6434eb4fc8d1f152ab87e1dd21c60f4bc0d785dd Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 21 Jun 2012 18:33:00 +0200 Subject: [PATCH] maint: disable the strncpy prohibition * cfg.mk: Do not prohibit strncpy here. ---

Re: parse-duration-tests: make it build

2012-06-21 Thread Jim Meyering
Bruce Korb wrote: > On 06/21/12 08:16, Jim Meyering wrote: >> >> Maybe just try again? > > My push-ability is still disabled. Can this be fixed, please? AFAICT, it's not disabled: https://savannah.gnu.org/project/memberlist.php?group=gnulib Maybe you're ha

Re: parse-duration-tests: make it build

2012-06-21 Thread Jim Meyering
Bruce Korb wrote: > What happened to my GIT access? > > $ git push > fatal: The remote end hung up unexpectedly > > This should be "obvious". Hi Bruce, That appears to have been introduced by me when I changed from TAB-based indentation to space-based. I didn't take into consideration the possibi

Re: gnumakefile: usable on its own without maintainer-makefile?

2012-06-21 Thread Jim Meyering
Simon Josefsson wrote: > Jim Meyering writes: >> Simon Josefsson wrote: >>> Building the 'gnumakefile' module fails: >>> >>> http://autobuild.josefsson.org/gnulib-mega/log-201206201113065857000.txt >>> >>> Looking at that module,

Re: gnumakefile: usable on its own without maintainer-makefile?

2012-06-20 Thread Jim Meyering
Simon Josefsson wrote: > Building the 'gnumakefile' module fails: > > http://autobuild.josefsson.org/gnulib-mega/log-201206201113065857000.txt > > Looking at that module, I wonder if that module is useful at all without > maintainer-makefile? It seems GNUmakefile is tightly coupled together > with

<    1   2   3   4   5   6   7   8   9   10   >