Re: [PATCH] Proposal to fix NSCell issue

2004-04-01 Thread Quentin Mathé
Le 2 avr. 04, à 01:17, Fred Kiefer a écrit : Quentin Mathé wrote: Don't be confused :-). The problem is the following, Apple has added -performClick: to NSCell but this is impossible to implement without large modifications on NSMatrix for example (see my first set of patches) and moreover

Re: [PATCH] Proposal to fix NSCell issue

2004-04-01 Thread Fred Kiefer
Quentin Mathé wrote: Le 1 avr. 04, à 01:40, Fred Kiefer a écrit : Sorry, as I wrote, I was not sure. After your mail I checked and it is there on NSButton and NSButtonCell at least in my OpenStep specification (October 19, 1994, not sure if there are different versions). As this issue is becomi

Re: [PATCH] Proposal to fix NSCell issue

2004-04-01 Thread Markus Hitter
Am 01.04.2004 um 15:38 schrieb Quentin Mathé: Le 1 avr. 04, à 09:18, Markus Hitter a écrit : That's strange since all these classes support clicking by the user already. This is not in relation with the problem. See below At worst you whould have to sythesize an MouseDown event. Sorry, I don't

Re: [PATCH] Proposal to fix NSCell issue

2004-04-01 Thread Quentin Mathé
Le 1 avr. 04, à 09:18, Markus Hitter a écrit : Am 01.04.2004 um 03:03 schrieb Quentin Mathé: ... but this is impossible to implement without large modifications on NSMatrix for example That's strange since all these classes support clicking by the user already. This is not in relation with the

Re: [PATCH] Proposal to fix NSCell issue

2004-03-31 Thread Markus Hitter
Am 01.04.2004 um 03:03 schrieb Quentin Mathé: Apple has added -performClick: to NSCell ... ... and to NSButtonCell and NSControl. On 10.3.3, Three (similar) descriptions are available. For reference, the one for NSControl: - (void)performClick:(id)sender Can be used to simulate a single mouse c

Re: [PATCH] Proposal to fix NSCell issue

2004-03-31 Thread Quentin Mathé
Le 1 avr. 04, à 01:40, Fred Kiefer a écrit : Sorry, as I wrote, I was not sure. After your mail I checked and it is there on NSButton and NSButtonCell at least in my OpenStep specification (October 19, 1994, not sure if there are different versions). As this issue is becoming a bit strange now,

Re: [PATCH] Proposal to fix NSCell issue

2004-03-31 Thread Fred Kiefer
Quentin Mathé wrote: Le 31 mars 04, à 09:25, Fred Kiefer a écrit : Alexander Malmberg wrote: I'd rather remove [NSCell -performClick:] than extend it, but either way, it'll be easy to do this after this change. here I have to object. performClick: is an interface that is documented by Apple (a

Re: [PATCH] Proposal to fix NSCell issue

2004-03-31 Thread Quentin Mathé
Le 31 mars 04, à 09:25, Fred Kiefer a écrit : Alexander Malmberg wrote: I'd rather remove [NSCell -performClick:] than extend it, but either way, it'll be easy to do this after this change. here I have to object. performClick: is an interface that is documented by Apple (and as far as I remember

Re: [PATCH] Proposal to fix NSCell issue

2004-03-30 Thread Fred Kiefer
Hi Alexander, Alexander Malmberg wrote: I'd rather remove [NSCell -performClick:] than extend it, but either way, it'll be easy to do this after this change. here I have to object. performClick: is an interface that is documented by Apple (and as far as I remember was even in the OpenStep specif

Re: [PATCH] Proposal to fix NSCell issue

2004-03-30 Thread Alexander Malmberg
Quentin Mathé wrote: > Here is an updated set of patches... I hope it's ok now : I removed the > action send in NSButtonCell and also the NSWindow patch (-performClick: > is kept until better solution is found). > > I think it is ok to commit. > ? Some lines seem to be longer than 80 characters

Re: [PATCH] Proposal to fix NSCell issue

2004-03-30 Thread Fred Kiefer
Quentin Mathé wrote: Here is an updated set of patches... I hope it's ok now : I removed the action send in NSButtonCell and also the NSWindow patch (-performClick: is kept until better solution is found). I think it is ok to commit. As I wrote before, I like the patch. There are a few remaining

Re: [PATCH] Proposal to fix NSCell issue

2004-03-30 Thread Quentin Mathé
Here is an updated set of patches... I hope it's ok now : I removed the action send in NSButtonCell and also the NSWindow patch (-performClick: is kept until better solution is found). I think it is ok to commit. ? Quentin. NSButton.h.patch Description: Binary data NSCell.h.patch Descripti

Re: [PATCH] Proposal to fix NSCell issue

2004-03-23 Thread Quentin Mathé
Le 23 mars 04, à 21:07, Fred Kiefer a écrit : Quentin Mathé wrote: Le 23 mars 04, à 01:07, Quentin Mathé a écrit : Well, here is two patches which add -performClickWithFrame:inView: to NSCell and mark performClick: as deprecated. If everybody is ok, I can commit this NSCell modification. Here a

Re: [PATCH] Proposal to fix NSCell issue

2004-03-23 Thread Fred Kiefer
Quentin Mathé wrote: Le 23 mars 04, à 01:07, Quentin Mathé a écrit : Well, here is two patches which add -performClickWithFrame:inView: to NSCell and mark performClick: as deprecated. If everybody is ok, I can commit this NSCell modification. Here are a more complete set of patches to fix the r

Re: [PATCH] Proposal to fix NSCell issue

2004-03-23 Thread Quentin Mathé
Le 23 mars 04, à 01:07, Quentin Mathé a écrit : Well, here is two patches which add -performClickWithFrame:inView: to NSCell and mark performClick: as deprecated. If everybody is ok, I can commit this NSCell modification. Here are a more complete set of patches to fix the related issues : NSBu

Re: [PATCH] Proposal to fix NSCell issue

2004-03-22 Thread Quentin Mathé
Le 20 mars 04, à 02:57, Alexander Malmberg a écrit : When working with cells and views, it's important to remember that the connections between cells and views are not simple. :) In particular, a single cell might be shared by multiple views, so a cell does not have any defined "control view" (exc

Re: [PATCH] Proposal to fix NSCell issue

2004-03-19 Thread Alexander Malmberg
When working with cells and views, it's important to remember that the connections between cells and views are not simple. :) In particular, a single cell might be shared by multiple views, so a cell does not have any defined "control view" (except when it's inside a -...inView: call, and even the

Re: [PATCH] Proposal to fix NSCell issue

2004-03-19 Thread Quentin Mathé
Le 18 mars 04, à 02:11, Fred Kiefer a écrit : Quentin Mathé wrote: In the current situation NSCell performClick: method doesn't work with NSMatrix and cannot be used for an NSCell subclass with embedded cells. Here is a screenshot for the issue with NSMatrix when you call performClick: on a cel

Re: [PATCH] Proposal to fix NSCell issue

2004-03-18 Thread Quentin Mathé
Le 18 mars 04, à 19:10, Fred Kiefer a écrit : I gave this another thought and now I am wondering why we are doing all the explicit drawing at all. We could also just set the highlight attribute and mark the cell as dirty and let the runloop do the drawing for us. And the same when we finish hig

Re: [PATCH] Proposal to fix NSCell issue

2004-03-18 Thread Quentin Mathé
Le 18 mars 04, à 02:11, Fred Kiefer a écrit : Quentin Mathé wrote: In the current situation NSCell performClick: method doesn't work with NSMatrix and cannot be used for an NSCell subclass with embedded cells. Here is a screenshot for the issue with NSMatrix when you call performClick: on a ce

Re: [PATCH] Proposal to fix NSCell issue

2004-03-18 Thread Fred Kiefer
I gave this another thought and now I am wondering why we are doing all the explicit drawing at all. We could also just set the highlight attribute and mark the cell as dirty and let the runloop do the drawing for us. And the same when we finish highlighting. This is surely a lot slower, but we

Re: [PATCH] Proposal to fix NSCell issue

2004-03-17 Thread Fred Kiefer
Quentin Mathé wrote: In the current situation NSCell performClick: method doesn't work with NSMatrix and cannot be used for an NSCell subclass with embedded cells. Here is a screenshot for the issue with NSMatrix when you call performClick: on a cell : … before the performClick: call http://www.q

[PATCH] Proposal to fix NSCell issue

2004-03-17 Thread Quentin Mathé
Hi, In the current situation NSCell performClick: method doesn't work with NSMatrix and cannot be used for an NSCell subclass with embedded cells. Here is a screenshot for the issue with NSMatrix when you call performClick: on a cell : … before the performClick: call http://www.quentinmathe.com/