Re: Problem with ISO9660 and files stored on multiple extents

2017-02-17 Thread Andrei Borzenkov
17.02.2017 21:18, Andrei Borzenkov пишет: > > Not quite. We assume that fragment and block list are mutually > exclusive, while squashfs can pack file tail that does not fill full > block as fragment. So we actually need to do direct_read() And BTW it does not look like direct_read() copes with

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-17 Thread Andrei Borzenkov
16.02.2017 20:42, Carlo Caione пишет: > On Thu, Feb 16, 2017 at 5:52 PM, Andrei Borzenkov wrote: >> 16.02.2017 19:04, Vladimir 'phcoder' Serbinenko пишет: >>> On Thu, Feb 16, 2017, 16:56 Carlo Caione wrote: > >>> Then it's possible that your patch is correct. I don't know why the format >>> chan

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Carlo Caione
On Thu, Feb 16, 2017 at 5:52 PM, Andrei Borzenkov wrote: > 16.02.2017 19:04, Vladimir 'phcoder' Serbinenko пишет: >> On Thu, Feb 16, 2017, 16:56 Carlo Caione wrote: >> Then it's possible that your patch is correct. I don't know why the format >> changes or what the 0 means in this field >> > > L

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Feb 16, 2017, 16:56 Carlo Caione wrote: > On Thu, Feb 16, 2017 at 4:54 PM, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > On Thu, Feb 16, 2017, 14:14 Carlo Caione wrote: > >> > >> On Thu, Feb 16, 2017 at 2:09 PM, Vladimir 'phcoder' Serbinenko > >> wrote: > >> > > >> > > >> > On Thu

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Andrei Borzenkov
16.02.2017 19:04, Vladimir 'phcoder' Serbinenko пишет: > On Thu, Feb 16, 2017, 16:56 Carlo Caione wrote: > >> On Thu, Feb 16, 2017 at 4:54 PM, Vladimir 'phcoder' Serbinenko >> wrote: >>> >>> >>> On Thu, Feb 16, 2017, 14:14 Carlo Caione wrote: On Thu, Feb 16, 2017 at 2:09 PM, Vladimir

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Feb 16, 2017, 14:14 Carlo Caione wrote: > On Thu, Feb 16, 2017 at 2:09 PM, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > On Thu, Feb 16, 2017, 14:04 Carlo Caione wrote: > >> > >> On Thu, Feb 16, 2017 at 12:37 PM, Carlo Caione > wrote: > >> > On Thu, Feb 16, 2017 at 12:32 PM, Thoma

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Carlo Caione
On Thu, Feb 16, 2017 at 4:54 PM, Vladimir 'phcoder' Serbinenko wrote: > > > On Thu, Feb 16, 2017, 14:14 Carlo Caione wrote: >> >> On Thu, Feb 16, 2017 at 2:09 PM, Vladimir 'phcoder' Serbinenko >> wrote: >> > >> > >> > On Thu, Feb 16, 2017, 14:04 Carlo Caione wrote: >> >> >> >> On Thu, Feb 16, 2

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Carlo Caione
On Thu, Feb 16, 2017 at 2:09 PM, Vladimir 'phcoder' Serbinenko wrote: > > > On Thu, Feb 16, 2017, 14:04 Carlo Caione wrote: >> >> On Thu, Feb 16, 2017 at 12:37 PM, Carlo Caione wrote: >> > On Thu, Feb 16, 2017 at 12:32 PM, Thomas Schmitt >> > wrote: >> >> Hi, >> >> >> >> Carlo Caione wrote: >>

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Vladimir 'phcoder' Serbinenko
On Thu, Feb 16, 2017, 14:04 Carlo Caione wrote: > On Thu, Feb 16, 2017 at 12:37 PM, Carlo Caione wrote: > > On Thu, Feb 16, 2017 at 12:32 PM, Thomas Schmitt > wrote: > >> Hi, > >> > >> Carlo Caione wrote: > >>> > I think that the problem > >>> > here is that endless.squash has been stored in tw

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Carlo Caione
On Thu, Feb 16, 2017 at 12:37 PM, Carlo Caione wrote: > On Thu, Feb 16, 2017 at 12:32 PM, Thomas Schmitt wrote: >> Hi, >> >> Carlo Caione wrote: >>> > I think that the problem >>> > here is that endless.squash has been stored in two extents in the >>> > ISO9660 and GRUB doesn't deal fine with tha

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Carlo Caione
On Thu, Feb 16, 2017 at 12:32 PM, Thomas Schmitt wrote: > Hi, > > Carlo Caione wrote: >> > I think that the problem >> > here is that endless.squash has been stored in two extents in the >> > ISO9660 and GRUB doesn't deal fine with that (also according to this >> > comment >> > http://git.savannah

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-16 Thread Thomas Schmitt
Hi, Carlo Caione wrote: > > I think that the problem > > here is that endless.squash has been stored in two extents in the > > ISO9660 and GRUB doesn't deal fine with that (also according to this > > comment > > http://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/iso9660.c#n960 Andrei Bor

Re: Problem with ISO9660 and files stored on multiple extents

2017-02-15 Thread Andrei Borzenkov
16.02.2017 00:30, Carlo Caione пишет: > Hi, > in our ISO images in the ISO9660 partition we ship a squashfs image > containing the full OS image. > At boot GRUB does something like this: > > loopback loop_squash ($eosimage)/endless/endless.squash > loopback loop_img (loop_squash)/endless.img > set

Problem with ISO9660 and files stored on multiple extents

2017-02-15 Thread Carlo Caione
Hi, in our ISO images in the ISO9660 partition we ship a squashfs image containing the full OS image. At boot GRUB does something like this: loopback loop_squash ($eosimage)/endless/endless.squash loopback loop_img (loop_squash)/endless.img set root=(loop_img,gpt3) This is working fine for our sm