bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-07 Thread pelzflorian (Florian Pelz)
On Mon, May 06, 2019 at 09:43:55PM +0200, Ludovic Courtès wrote: >> I agree. I’ll commit the patch below, which works fine for German (at > least before the “Hide” checkbox patch). > > Thanks, > Ludo’. > Fits perfectly. Thank you all of you! Regards, Florian

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-07 Thread Mathieu Othacehe
Hey, > So I guess you can go ahead and push, Mathieu! Pushed as 445bd4d5e5, thanks to both of you for reviewing it :) Mathieu

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread Ludovic Courtès
"pelzflorian (Florian Pelz)" skribis: > On Mon, May 06, 2019 at 08:14:46PM +0200, pelzflorian (Florian Pelz) wrote: >> When creating a user account, the translation for Home Directory >> (“Persönliches Verzeichnis”) gets cut off to “Persönliches Verzeic”, >> but I believe this is not important. >

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread Ludovic Courtès
"pelzflorian (Florian Pelz)" skribis: > On Mon, May 06, 2019 at 12:02:16PM +0200, Ludovic Courtès wrote: >> I would perhaps add that checkbox only for the passphrase, in part > > I disagree, people would expect it (and file bugs) for other passwords > for the same reasons (other people watching w

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread pelzflorian (Florian Pelz)
On Mon, May 06, 2019 at 08:14:46PM +0200, pelzflorian (Florian Pelz) wrote: > When creating a user account, the translation for Home Directory > (“Persönliches Verzeichnis”) gets cut off to “Persönliches Verzeic”, > but I believe this is not important. > This cut-off happens even on higher resolu

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread pelzflorian (Florian Pelz)
Sorry for being late to the feedback party. On Mon, May 06, 2019 at 12:02:16PM +0200, Ludovic Courtès wrote: > I would perhaps add that checkbox only for the passphrase, in part I disagree, people would expect it (and file bugs) for other passwords for the same reasons (other people watching whil

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread Ludovic Courtès
Mathieu Othacehe skribis: >> I would perhaps add that checkbox only for the passphrase, in part >> because when I test an install I prefer to have fewer keystrokes :-), > > The parameter is disabled by default and enabled only for disk > encryption and root/user passwords so I'm not sure I get wh

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread Mathieu Othacehe
Hey Ludo, > I would perhaps add that checkbox only for the passphrase, in part > because when I test an install I prefer to have fewer keystrokes :-), The parameter is disabled by default and enabled only for disk encryption and root/user passwords so I'm not sure I get what you mean. > but al

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-06 Thread Ludovic Courtès
Hello, Mathieu Othacehe skribis: >> #2 would please everybody, but I do not know what widgets Newt >> provides for this. Mathieu, would you know if changing the >> visibility with e.g. a checkbox is doable? > > You'll find a patch attached that adds a checkbox to toggle password > hiding. Every

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-05 Thread pelzflorian (Florian Pelz)
On Sun, May 05, 2019 at 01:04:03PM +0200, Mathieu Othacehe wrote: > > Hello, > > > #2 would please everybody, but I do not know what widgets Newt > > provides for this. Mathieu, would you know if changing the > > visibility with e.g. a checkbox is doable? > > You'll find a patch attached that a

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-05 Thread Mathieu Othacehe
Hello, > #2 would please everybody, but I do not know what widgets Newt > provides for this. Mathieu, would you know if changing the > visibility with e.g. a checkbox is doable? You'll find a patch attached that adds a checkbox to toggle password hiding. Every password input now has such a chec

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-04 Thread pelzflorian (Florian Pelz)
On Fri, May 03, 2019 at 03:50:52PM +0200, Ludovic Courtès wrote: > That’s why I think that seeing what you actually type is useful. > Seeing the password is useful, unless someone is shoulder surfing while you install, which is possible. > Other options include: > > 1. Hiding the passphrase,

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-03 Thread Ludovic Courtès
Julien Lepiller skribis: > Le Fri, 3 May 2019 11:30:18 +0200, > Danny Milosavljevic a écrit : > >> Hi, >> >> On Fri, 3 May 2019 10:54:37 +0200 >> "pelzflorian (Florian Pelz)" wrote: >> >> > When creating an encrypted partition in Manual partitioning (maybe >> > also Guided?) in the Newt insta

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-03 Thread Ludovic Courtès
Hi, "pelzflorian (Florian Pelz)" skribis: > When creating an encrypted partition in Manual partitioning (maybe > also Guided?) in the Newt installer, it asks for a password with which > to encrypt the partition. However only the password confirmation > password entry diplays *** instead of

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-03 Thread Julien Lepiller
Le Fri, 3 May 2019 11:30:18 +0200, Danny Milosavljevic a écrit : > Hi, > > On Fri, 3 May 2019 10:54:37 +0200 > "pelzflorian (Florian Pelz)" wrote: > > > When creating an encrypted partition in Manual partitioning (maybe > > also Guided?) in the Newt installer, it asks for a password with > > w

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-03 Thread Danny Milosavljevic
Hi, On Fri, 3 May 2019 10:54:37 +0200 "pelzflorian (Florian Pelz)" wrote: > When creating an encrypted partition in Manual partitioning (maybe > also Guided?) in the Newt installer, it asks for a password with which > to encrypt the partition. However only the password confirmation > password e

bug#35540: Installer displays encrypted partition password entry in cleartext

2019-05-03 Thread pelzflorian (Florian Pelz)
When creating an encrypted partition in Manual partitioning (maybe also Guided?) in the Newt installer, it asks for a password with which to encrypt the partition. However only the password confirmation password entry diplays *** instead of the typed password, the password entry before display