bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Liliana Marie Prikler
Am Montag, dem 09.10.2023 um 23:03 +0200 schrieb b...@bokr.com: > Hi, > > On +2023-10-09 20:33:38 +0200, Liliana Marie Prikler wrote: > > I don't necessarily agree, but it's not a hard disagree either.  > > I'll try to keep that in mind at least when reviewing your patches > > to not cause confusi

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread bokr
Hi, On +2023-10-09 20:33:38 +0200, Liliana Marie Prikler wrote: > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: > > Hello, > > > > Liliana Marie Prikler writes: > > > > > [...] > > > If you need me to reduce it to four letters, yes, LGTM. > > > > Explicit is better than imp

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hello, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 15:25 -0400 schrieb Maxim Cournoyer: >> Hi Liliana, >> >> Liliana Marie Prikler writes: >> >> > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: >> > > Hello, >> > > >> > > Liliana Marie Prikler writes: >>

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Liliana Marie Prikler
Am Montag, dem 09.10.2023 um 15:25 -0400 schrieb Maxim Cournoyer: > Hi Liliana, > > Liliana Marie Prikler writes: > > > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: > > > Hello, > > > > > > Liliana Marie Prikler writes: > > > > > > > [...] > > > > If you need me to reduce

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hi Liliana, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: >> Hello, >> >> Liliana Marie Prikler writes: >> >> > [...] >> > If you need me to reduce it to four letters, yes, LGTM. >> >> Explicit is better than implicit.  I've been thinking t

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hi Liliana, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer: >> Hi Liliana :-) >> >> Liliana Marie Prikler writes: >> >> > Am Samstag, dem 07.10.2023 um 23:18 -0400 schrieb Maxim Cournoyer: >> > > It's simpler to add features on top of a minima

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Liliana Marie Prikler
Am Montag, dem 09.10.2023 um 14:21 -0400 schrieb Maxim Cournoyer: > Hello, > > Liliana Marie Prikler writes: > > > [...] > > If you need me to reduce it to four letters, yes, LGTM. > > Explicit is better than implicit.  I've been thinking to document > this in our contributing section; e.g. a r

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hello, Liliana Marie Prikler writes: > Am Montag, dem 09.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer: >> Hi Liliana :-) >> >> Liliana Marie Prikler writes: >> >> > Am Samstag, dem 07.10.2023 um 23:18 -0400 schrieb Maxim Cournoyer: >> > > It's simpler to add features on top of a minimal var

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Liliana Marie Prikler
Am Montag, dem 09.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer: > Hi Liliana :-) > > Liliana Marie Prikler writes: > > > Am Samstag, dem 07.10.2023 um 23:18 -0400 schrieb Maxim Cournoyer: > > > It's simpler to add features on top of a minimal variant than to > > > remove them, and helps avoidi

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hi, Maxim Cournoyer writes: > This series introduces default variable bindings for the default > gnu-build-system IMPORTED-MODULES and MODULES values. The lack of a > %default-gnu-modules caused enough confusion, as made apparent by this series. > > Maxim Cournoyer (65): Nevermind the above mi

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-09 Thread Maxim Cournoyer
Hi Liliana :-) Liliana Marie Prikler writes: > Am Samstag, dem 07.10.2023 um 23:18 -0400 schrieb Maxim Cournoyer: >> It's simpler to add features on top of a minimal variant than to >> remove them, and helps avoiding mistakenly changing git-minimal, >> which has many dependents. >> >> * gnu/pac

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-06 Thread Simon Tournier
Hi, On Wed, 04 Oct 2023 at 23:41, Maxim Cournoyer wrote: >> I think we should add coreutils-minimal and sed (or gash-utils?) to the >> ‘git-submodule’ wrapper that already exists. > > That should work for the use case at hand, but we should scan the source > for occurrences of the tools to see i

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-04 Thread Maxim Cournoyer
Hi Ludovic, Ludovic Courtès writes: > Hi, > > Maxim Cournoyer skribis: > >> Attempting to use git-minimal in a --pure environment, I stumbled upon: >> >> /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: >> line 7: basename: command not found >> /gnu/store/grc7

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-04 Thread Simon Tournier
Hi, On Wed, 04 Oct 2023 at 18:14, Ludovic Courtès wrote: > I think we should add coreutils-minimal and sed (or gash-utils?) to the > ‘git-submodule’ wrapper that already exists. Yes, for now it is seems the way forward for fixing the current #66305. It is an increase of git-minimal about ~12%.

bug#65924: git searches coreutils and util-linux commands in PATH

2023-10-04 Thread Ludovic Courtès
Hi, Maxim Cournoyer skribis: > Attempting to use git-minimal in a --pure environment, I stumbled upon: > > /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: > line 7: basename: command not found > /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-

bug#65924: git searches coreutils and util-linux commands in PATH

2023-09-13 Thread Simon Tournier
Hi, On Thu, 14 Sept 2023 at 05:14, Maxim Cournoyer wrote: > > $ guix size git-minimal > > [...] > > total: 147.8 MiB > > > > $ guix size git-minimal util-linux coreutils > > [...] > > total: 195.4 MiB > > > > It increases the size by 33% which is not nothing. :-) [...] > > The question could b

bug#65924: git searches coreutils and util-linux commands in PATH

2023-09-13 Thread Maxim Cournoyer
Hi, Simon Tournier writes: > Hi Maxim, > > On Wed, 13 Sep 2023 at 14:00, Maxim Cournoyer > wrote: > >> The 'git' command should be wrapped to include these in its PATH. > > $ guix size git-minimal > [...] > total: 147.8 MiB > > $ guix size git-minimal util-linux coreutils > [...] > total: 195.

bug#65924: git searches coreutils and util-linux commands in PATH

2023-09-13 Thread Simon Tournier
Hi Maxim, On Wed, 13 Sep 2023 at 14:00, Maxim Cournoyer wrote: > The 'git' command should be wrapped to include these in its PATH. --8<---cut here---start->8--- $ guix size git-minimal [...] total: 147.8 MiB $ guix size git-minimal util-linux coreutils [...]

bug#65924: git searches coreutils and util-linux commands in PATH

2023-09-13 Thread Maxim Cournoyer
Hello, Attempting to use git-minimal in a --pure environment, I stumbled upon: --8<---cut here---start->8--- /gnu/store/grc79ijx09nygvjh67cpk3g405nzr801-profile/libexec/git-core/git-submodule: line 7: basename: command not found /gnu/store/grc79ijx09nygvjh67cp